Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: o1 do not support system prompt and max_tokens #2016

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Laisky
Copy link
Contributor

@Laisky Laisky commented Jan 5, 2025

问题

o1 系列模型不支持 system prompt 和 max_tokens

@laosuan
Copy link

laosuan commented Jan 20, 2025

It also need to work with version="2024-12-01-preview" when use azure openai

@Laisky
Copy link
Contributor Author

Laisky commented Jan 20, 2025

It also need to work with version="2024-12-01-preview" when use azure openai

Could you please provide more details or documentation urls?

@ericjia888
Copy link

It also need to work with version="2024-12-01-preview" when use azure openai

Could you please provide more details or documentation urls?

I hope the document below can be helpful.
https://learn.microsoft.com/en-us/azure/ai-services/openai/how-to/reasoning?tabs=python

@Laisky
Copy link
Contributor Author

Laisky commented Feb 7, 2025

It also need to work with version="2024-12-01-preview" when use azure openai

Could you please provide more details or documentation urls?

I hope the document below can be helpful. https://learn.microsoft.com/en-us/azure/ai-services/openai/how-to/reasoning?tabs=python

Thanks for the heads up! This issue has been fixed.

@ericjia888
Copy link

It also need to work with version="2024-12-01-preview" when use azure openai

Could you please provide more details or documentation urls?

I hope the document below can be helpful. https://learn.microsoft.com/en-us/azure/ai-services/openai/how-to/reasoning?tabs=python

Thanks for the heads up! This issue has been fixed.

Can you provide an approximate release date?

@Laisky
Copy link
Contributor Author

Laisky commented Feb 7, 2025

@ericjia888 Idk when the owner plans to merge or if it will even happen. You can check out my fork: https://github.com/Laisky/one-api

@ericjia888
Copy link

@ericjia888 Idk when the owner plans to merge or if it will even happen. You can check out my fork: https://github.com/Laisky/one-api
@Laisky
I deployed your branch code for local testing and found that o1-mini reported the following error. Could you please help me check it?
msedge_lbeRWvGncG
msedge_K0u3ZsYoeY

@Laisky
Copy link
Contributor Author

Laisky commented Feb 8, 2025

@ericjia888 It looks like this is an Azure issue. Even though the test failed, the channel should still be able to function normally.

Additionally, I just submitted a PR related to the concern you raised: #2065 . You can download the latest version from https://github.com/Laisky/one-api and test it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants