Skip to content

Commit

Permalink
redis-dump-load: Pin the redis package to use 3.5.3 (#9001)
Browse files Browse the repository at this point in the history
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).

Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.

#### How to verify it

Make sure that redis-dump-load for Python 2 builds today.
  • Loading branch information
saiarcot895 authored and lguohan committed Oct 19, 2021
1 parent 967d8ab commit 8555e41
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
25 changes: 25 additions & 0 deletions src/redis-dump-load.patch/0003-use-redis-3.5.3.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
Pin the redis package to version 3.5.3 (the last version that supports both
Python 2 and 3).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

diff --git a/requirements.txt b/requirements.txt
index 7800f0f..3fc0632 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1 +1 @@
-redis
+redis==3.5.3
diff --git a/setup.py b/setup.py
index 8ccf31f..6db9ec4 100644
--- a/setup.py
+++ b/setup.py
@@ -17,7 +17,7 @@ setup(name=package_name,
author_email='oleg@bsdpower.com',
url='http://github.com/p/redis-dump-load',
py_modules=['redisdl'],
- install_requires=['redis'],
+ install_requires=['redis==3.5.3'],
data_files=[
(doc_dir, data_files),
],
1 change: 1 addition & 0 deletions src/redis-dump-load.patch/series
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
0001-Use-pipelines-when-dumping-52.patch
0002-Fix-setup.py-for-test-and-bdist_wheel.patch
0003-use-redis-3.5.3.patch

0 comments on commit 8555e41

Please sign in to comment.