-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redis-dump-load: Pin the redis package to use 3.5.3 #9001
Merged
qiluo-msft
merged 1 commit into
sonic-net:master
from
saiarcot895:redis-pypi-version-fix
Oct 19, 2021
Merged
redis-dump-load: Pin the redis package to use 3.5.3 #9001
qiluo-msft
merged 1 commit into
sonic-net:master
from
saiarcot895:redis-pypi-version-fix
Oct 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This version drops support for Python 2 and only supports Python 3. Because setup.py is being run, it will use the latest version of a package and not the latest stable version (which is still 3.5.3). Therefore, pin the redis package to version 3.5.3, so that it will work for both Python 2 and 3. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
force-pushed
the
redis-pypi-version-fix
branch
from
October 18, 2021 17:22
a9ac9e5
to
9722b38
Compare
yxieca
approved these changes
Oct 18, 2021
Can this be double-committed into 202012 too please? |
liorghub
pushed a commit
to liorghub/sonic-buildimage
that referenced
this pull request
Oct 19, 2021
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This version drops support for Python 2 and only supports Python 3. Because setup.py is being run, it will use the latest version of a package and not the latest stable version (which is still 3.5.3). Therefore, pin the redis package to version 3.5.3, so that it will work for both Python 2 and 3. #### How to verify it Make sure that redis-dump-load for Python 2 builds today.
lguohan
pushed a commit
that referenced
this pull request
Oct 19, 2021
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This version drops support for Python 2 and only supports Python 3. Because setup.py is being run, it will use the latest version of a package and not the latest stable version (which is still 3.5.3). Therefore, pin the redis package to version 3.5.3, so that it will work for both Python 2 and 3. #### How to verify it Make sure that redis-dump-load for Python 2 builds today.
qiluo-msft
added a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Oct 21, 2021
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This version drops support for Python 2 and only supports Python 3. Because setup.py is being run, it will use the latest version of a package and not the latest stable version (which is still 3.5.3). Therefore, pin the redis package to version 3.5.3, so that it will work for both Python 2 and 3. #### How to verify it Make sure that redis-dump-load for Python 2 builds today.
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Dec 13, 2021
…ernal branch Related work items: sonic-net#525, sonic-net#534, sonic-net#909, sonic-net#927, sonic-net#930, sonic-net#934, sonic-net#935, sonic-net#937, sonic-net#938, sonic-net#939, sonic-net#940, sonic-net#943, sonic-net#944, sonic-net#945, sonic-net#946, sonic-net#948, sonic-net#1702, sonic-net#1923, sonic-net#1936, sonic-net#1942, sonic-net#2315, sonic-net#7281, sonic-net#7375, sonic-net#8659, sonic-net#8799, sonic-net#8868, sonic-net#8875, sonic-net#8935, sonic-net#8942, sonic-net#8956, sonic-net#8961, sonic-net#8966, sonic-net#8969, sonic-net#8971, sonic-net#8978, sonic-net#8991, sonic-net#8996, sonic-net#9001, sonic-net#9008, #3146150
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 15, 2022
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This version drops support for Python 2 and only supports Python 3. Because setup.py is being run, it will use the latest version of a package and not the latest stable version (which is still 3.5.3). Therefore, pin the redis package to version 3.5.3, so that it will work for both Python 2 and 3. Make sure that redis-dump-load for Python 2 builds today. Signed-off-by: Zhenggen Xu <zxu@linkedin.com> RB=2942507 G=lnos-reviewers R=pchaudha,pmao,samaity,stexu,zxu A=
AidanCopeland
pushed a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This version drops support for Python 2 and only supports Python 3. Because setup.py is being run, it will use the latest version of a package and not the latest stable version (which is still 3.5.3). Therefore, pin the redis package to version 3.5.3, so that it will work for both Python 2 and 3. #### How to verify it Make sure that redis-dump-load for Python 2 builds today.
guxianghong
pushed a commit
to CentecNetworks/sonic-buildimage
that referenced
this pull request
May 21, 2022
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This version drops support for Python 2 and only supports Python 3. Because setup.py is being run, it will use the latest version of a package and not the latest stable version (which is still 3.5.3). Therefore, pin the redis package to version 3.5.3, so that it will work for both Python 2 and 3. #### How to verify it Make sure that redis-dump-load for Python 2 builds today.
liuyuefengcn
pushed a commit
to liuyuefengcn/sonic-net-buildimage
that referenced
this pull request
Nov 14, 2023
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This version drops support for Python 2 and only supports Python 3. Because setup.py is being run, it will use the latest version of a package and not the latest stable version (which is still 3.5.3). Therefore, pin the redis package to version 3.5.3, so that it will work for both Python 2 and 3. #### How to verify it Make sure that redis-dump-load for Python 2 builds today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis 4.0.0b1 has been uploaded to pip as a prerelease version. This
version drops support for Python 2 and only supports Python 3. Because
setup.py is being run, it will use the latest version of a package and
not the latest stable version (which is still 3.5.3).
Therefore, pin the redis package to version 3.5.3, so that it will work
for both Python 2 and 3.
Signed-off-by: Saikrishna Arcot sarcot@microsoft.com
Why I did it
How I did it
How to verify it
Make sure that redis-dump-load for Python 2 builds today.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)