RADIUS Management User Authentication Feature (#1521)

What I did
Radius Management User Authentication Feature

How I did it
HLD: https://github.com/Azure/SONiC/blob/master/doc/aaa/radius_authentication.md

How to verify it
This is the CLI only. The changes are reflected in the Redis Config DB.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
admin@sonic:~$ show radius
RADIUS global auth_type pap (default)
RADIUS global retransmit 3 (default)
RADIUS global timeout 5 (default)
RADIUS global passkey <EMPTY_STRING> (default)

admin@sonic:~$

admin@sonic:~$ sudo config radius
Usage: config radius [OPTIONS] COMMAND [ARGS]...

RADIUS server configuration

Options:
-?, -h, --help Show this message and exit.

Commands:
add Specify a RADIUS server
authtype Specify RADIUS server global auth_type [chap | pap | mschapv2]
default set its default configuration
delete Delete a RADIUS server
nasip Specify RADIUS server global NAS-IP|IPV6-Address
passkey Specify RADIUS server global passkey
retransmit Specify RADIUS server global retry attempts <0 - 10>
sourceip Specify RADIUS server global source ip
statistics Specify RADIUS server global statistics [enable | disable |...
timeout Specify RADIUS server global timeout <1 - 60>
admin@sonic:~$

config/aaa.py

@@ -1,7 +1,17 @@
 import click
+import ipaddress
+import re
 from swsscommon.swsscommon import ConfigDBConnector
 import utilities_common.cli as clicommon
 
+RADIUS_MAXSERVERS = 8
+RADIUS_PASSKEY_MAX_LEN = 65
+VALID_CHARS_MSG = "Valid chars are ASCII printable except SPACE, '#', and ','"
+
+def is_secret(secret):
+    return bool(re.match('^' + '[^ #,]*' + '$', secret))
+
+
 def add_table_kv(table, entry, key, val):
     config_db = ConfigDBConnector()
     config_db.connect()
@@ -61,20 +71,69 @@ def fallback(option):
 authentication.add_command(fallback)
 
 
+# cmd: aaa authentication debug
+@click.command()
+@click.argument('option', type=click.Choice(["enable", "disable", "default"]))
+def debug(option):
+    """AAA debug [enable | disable | default]"""
+    if option == 'default':
+        del_table_key('AAA', 'authentication', 'debug')
+    else:
+        if option == 'enable':
+            add_table_kv('AAA', 'authentication', 'debug', True)
+        elif option == 'disable':
+            add_table_kv('AAA', 'authentication', 'debug', False)
+authentication.add_command(debug)
+
+
+# cmd: aaa authentication trace
+@click.command()
+@click.argument('option', type=click.Choice(["enable", "disable", "default"]))
+def trace(option):
+    """AAA packet trace [enable | disable | default]"""
+    if option == 'default':
+        del_table_key('AAA', 'authentication', 'trace')
+    else:
+        if option == 'enable':
+            add_table_kv('AAA', 'authentication', 'trace', True)
+        elif option == 'disable':
+            add_table_kv('AAA', 'authentication', 'trace', False)
+authentication.add_command(trace)
+
+
 @click.command()
-@click.argument('auth_protocol', nargs=-1, type=click.Choice(["tacacs+", "local", "default"]))
+@click.argument('auth_protocol', nargs=-1, type=click.Choice(["radius", "tacacs+", "local", "default"]))
 def login(auth_protocol):
-    """Switch login authentication [ {tacacs+, local} | default ]"""
+    """Switch login authentication [ {radius, tacacs+, local} | default ]"""
     if len(auth_protocol) is 0:
         click.echo('Argument "auth_protocol" is required')
         return
+    elif len(auth_protocol) > 2:
+        click.echo('Not a valid command.')
+        return
 
     if 'default' in auth_protocol:
+        if len(auth_protocol) !=1:
+            click.echo('Not a valid command')
+            return
         del_table_key('AAA', 'authentication', 'login')
     else:
         val = auth_protocol[0]
         if len(auth_protocol) == 2:
-            val += ',' + auth_protocol[1]
+            val2 = auth_protocol[1]
+            good_ap = False
+            if val == 'local':
+                if val2 == 'radius' or val2 == 'tacacs+':
+                    good_ap = True
+            elif val == 'radius' or val == 'tacacs+':
+                if val2 == 'local':
+                    good_ap = True
+            if good_ap == True:
+                val += ',' + val2
+            else:
+                click.echo('Not a valid command')
+                return
+
         add_table_kv('AAA', 'authentication', 'login', val)
 authentication.add_command(login)
 
@@ -189,3 +248,249 @@ def delete(address):
     config_db.connect()
     config_db.set_entry('TACPLUS_SERVER', address, None)
 tacacs.add_command(delete)
+
+
+@click.group()
+def radius():
+    """RADIUS server configuration"""
+    pass
+
+
+@click.group()
+@click.pass_context
+def default(ctx):
+    """set its default configuration"""
+    ctx.obj = 'default'
+radius.add_command(default)
+
+
+@click.command()
+@click.argument('second', metavar='<time_second>', type=click.IntRange(1, 60), required=False)
+@click.pass_context
+def timeout(ctx, second):
+    """Specify RADIUS server global timeout <1 - 60>"""
+    if ctx.obj == 'default':
+        del_table_key('RADIUS', 'global', 'timeout')
+    elif second:
+        add_table_kv('RADIUS', 'global', 'timeout', second)
+    else:
+        click.echo('Not support empty argument')
+radius.add_command(timeout)
+default.add_command(timeout)
+
+
+@click.command()
+@click.argument('retries', metavar='<retry_attempts>', type=click.IntRange(0, 10), required=False)
+@click.pass_context
+def retransmit(ctx, retries):
+    """Specify RADIUS server global retry attempts <0 - 10>"""
+    if ctx.obj == 'default':
+        del_table_key('RADIUS', 'global', 'retransmit')
+    elif retries != None:
+        add_table_kv('RADIUS', 'global', 'retransmit', retries)
+    else:
+        click.echo('Not support empty argument')
+radius.add_command(retransmit)
+default.add_command(retransmit)
+
+
+@click.command()
+@click.argument('type', metavar='<type>', type=click.Choice(["chap", "pap", "mschapv2"]), required=False)
+@click.pass_context
+def authtype(ctx, type):
+    """Specify RADIUS server global auth_type [chap | pap | mschapv2]"""
+    if ctx.obj == 'default':
+        del_table_key('RADIUS', 'global', 'auth_type')
+    elif type:
+        add_table_kv('RADIUS', 'global', 'auth_type', type)
+    else:
+        click.echo('Not support empty argument')
+radius.add_command(authtype)
+default.add_command(authtype)
+
+
+@click.command()
+@click.argument('secret', metavar='<secret_string>', required=False)
+@click.pass_context
+def passkey(ctx, secret):
+    """Specify RADIUS server global passkey <STRING>"""
+    if ctx.obj == 'default':
+        del_table_key('RADIUS', 'global', 'passkey')
+    elif secret:
+        if len(secret) > RADIUS_PASSKEY_MAX_LEN:
+            click.echo('Maximum of %d chars can be configured' % RADIUS_PASSKEY_MAX_LEN)
+            return
+        elif not is_secret(secret):
+            click.echo(VALID_CHARS_MSG)
+            return
+        add_table_kv('RADIUS', 'global', 'passkey', secret)
+    else:
+        click.echo('Not support empty argument')
+radius.add_command(passkey)
+default.add_command(passkey)
+
+@click.command()
+@click.argument('src_ip', metavar='<source_ip>', required=False)
+@click.pass_context
+def sourceip(ctx, src_ip):
+    """Specify RADIUS server global source ip <IPAddress>"""
+    if ctx.obj == 'default':
+        del_table_key('RADIUS', 'global', 'src_ip')
+        return
+    elif not src_ip:
+        click.echo('Not support empty argument')
+        return
+
+    if not clicommon.is_ipaddress(src_ip):
+        click.echo('Invalid ip address')
+        return
+
+    v6_invalid_list = [ipaddress.IPv6Address(unicode('0::0')), ipaddress.IPv6Address(unicode('0::1'))]
+    net = ipaddress.ip_network(unicode(src_ip), strict=False)
+    if (net.version == 4):
+        if src_ip == "0.0.0.0":
+            click.echo('enter non-zero ip address')
+            return
+        ip = ipaddress.IPv4Address(src_ip)
+        if ip.is_reserved:
+            click.echo('Reserved ip is not valid')
+            return
+        if ip.is_multicast:
+            click.echo('Multicast ip is not valid')
+            return
+    elif (net.version == 6):
+        ip = ipaddress.IPv6Address(src_ip)
+        if (ip.is_multicast):
+            click.echo('Multicast ip is not valid')
+            return
+        if (ip in v6_invalid_list):
+            click.echo('Invalid ip address')
+            return
+    add_table_kv('RADIUS', 'global', 'src_ip', src_ip)
+radius.add_command(sourceip)
+default.add_command(sourceip)
+
+@click.command()
+@click.argument('nas_ip', metavar='<nas_ip>', required=False)
+@click.pass_context
+def nasip(ctx, nas_ip):
+    """Specify RADIUS server global NAS-IP|IPV6-Address <IPAddress>"""
+    if ctx.obj == 'default':
+        del_table_key('RADIUS', 'global', 'nas_ip')
+        return
+    elif not nas_ip:
+        click.echo('Not support empty argument')
+        return
+
+    if not clicommon.is_ipaddress(nas_ip):
+        click.echo('Invalid ip address')
+        return
+
+    v6_invalid_list = [ipaddress.IPv6Address(unicode('0::0')), ipaddress.IPv6Address(unicode('0::1'))]
+    net = ipaddress.ip_network(unicode(nas_ip), strict=False)
+    if (net.version == 4):
+        if nas_ip == "0.0.0.0":
+            click.echo('enter non-zero ip address')
+            return
+        ip = ipaddress.IPv4Address(nas_ip)
+        if ip.is_reserved:
+            click.echo('Reserved ip is not valid')
+            return
+        if ip.is_multicast:
+            click.echo('Multicast ip is not valid')
+            return
+    elif (net.version == 6):
+        ip = ipaddress.IPv6Address(nas_ip)
+        if (ip.is_multicast):
+            click.echo('Multicast ip is not valid')
+            return
+        if (ip in v6_invalid_list):
+            click.echo('Invalid ip address')
+            return
+    add_table_kv('RADIUS', 'global', 'nas_ip', nas_ip)
+radius.add_command(nasip)
+default.add_command(nasip)
+
+@click.command()
+@click.argument('option', type=click.Choice(["enable", "disable", "default"]))
+def statistics(option):
+    """Specify RADIUS server global statistics [enable | disable | default]"""
+    if option == 'default':
+        del_table_key('RADIUS', 'global', 'statistics')
+    else:
+        if option == 'enable':
+            add_table_kv('RADIUS', 'global', 'statistics', True)
+        elif option == 'disable':
+            add_table_kv('RADIUS', 'global', 'statistics', False)
+radius.add_command(statistics)
+
+
+# cmd: radius add <ip_address_or_domain_name> --retransmit COUNT --timeout SECOND --key SECRET --type TYPE --auth-port PORT --pri PRIORITY
+@click.command()
+@click.argument('address', metavar='<ip_address_or_domain_name>')
+@click.option('-r', '--retransmit', help='Retransmit attempts, default 3', type=click.IntRange(1, 10))
+@click.option('-t', '--timeout', help='Transmission timeout interval, default 5', type=click.IntRange(1, 60))
+@click.option('-k', '--key', help='Shared secret')
+@click.option('-a', '--auth_type', help='Authentication type, default pap', type=click.Choice(["chap", "pap", "mschapv2"]))
+@click.option('-o', '--auth-port', help='UDP port range is 1 to 65535, default 1812', type=click.IntRange(1, 65535), default=1812)
+@click.option('-p', '--pri', help="Priority, default 1", type=click.IntRange(1, 64), default=1)
+@click.option('-m', '--use-mgmt-vrf', help="Management vrf, default is no vrf", is_flag=True)
+@click.option('-s', '--source-interface', help='Source Interface')
+def add(address, retransmit, timeout, key, auth_type, auth_port, pri, use_mgmt_vrf, source_interface):
+    """Specify a RADIUS server"""
+
+    if key:
+        if len(key) > RADIUS_PASSKEY_MAX_LEN:
+            click.echo('--key: Maximum of %d chars can be configured' % RADIUS_PASSKEY_MAX_LEN)
+            return
+        elif not is_secret(key):
+            click.echo('--key: ' + VALID_CHARS_MSG)
+            return
+
+    config_db = ConfigDBConnector()
+    config_db.connect()
+    old_data = config_db.get_table('RADIUS_SERVER')
+    if address in old_data :
+        click.echo('server %s already exists' % address)
+        return
+    if len(old_data) == RADIUS_MAXSERVERS:
+        click.echo('Maximum of %d can be configured' % RADIUS_MAXSERVERS)
+    else:
+        data = {
+            'auth_port': str(auth_port),
+            'priority': pri
+        }
+        if auth_type is not None:
+            data['auth_type'] = auth_type
+        if retransmit is not None:
+            data['retransmit'] = str(retransmit)
+        if timeout is not None:
+            data['timeout'] = str(timeout)
+        if key is not None:
+            data['passkey'] = key
+        if use_mgmt_vrf :
+            data['vrf'] = "mgmt"
+        if source_interface :
+            if (source_interface.startswith("Ethernet") or \
+                source_interface.startswith("PortChannel") or \
+                source_interface.startswith("Vlan") or \
+                source_interface.startswith("Loopback") or \
+                source_interface == "eth0"):
+                data['src_intf'] = source_interface
+            else:
+                click.echo('Not supported interface name (valid interface name: Etherent<id>/PortChannel<id>/Vlan<id>/Loopback<id>/eth0)')
+        config_db.set_entry('RADIUS_SERVER', address, data)
+radius.add_command(add)
+
+
+# cmd: radius delete <ip_address_or_domain_name>
+# 'del' is keyword, replace with 'delete'
+@click.command()
+@click.argument('address', metavar='<ip_address_or_domain_name>')
+def delete(address):
+    """Delete a RADIUS server"""
+
+    config_db = ConfigDBConnector()
+    config_db.connect()
+    config_db.set_entry('RADIUS_SERVER', address, None)
+radius.add_command(delete)

config/main.py

@@ -866,6 +866,7 @@ def config(ctx):
 # Add groups from other modules
 config.add_command(aaa.aaa)
 config.add_command(aaa.tacacs)
+config.add_command(aaa.radius)
 config.add_command(chassis_modules.chassis_modules)
 config.add_command(console.console)
 config.add_command(feature.feature)