Updategraph during NOS->SONiC migration #1521

padmanarayana · 2018-03-21T18:30:00Z

- What I did

Enable updategraph for NOS->SONiC migration case

- How I did it

Enable flag in case of migration
Note : while it is possible to make this change during the build process itself, the change in rc.local is more concise.

- How to verify it

Performed a NOS -> SONiC migration and checked that minigraph was loading

- Description for the changelog
In case of NOS->SONiC migration, enable updategraph.

- A picture of a cute animal (not mandatory but encouraged)

lguohan · 2018-03-23T22:16:35Z

files/image_config/platform/rc.local

@@ -197,6 +197,7 @@ if [ -f /host/image-$sonic_version/platform/firsttime ]; then
        mkdir -p /etc/sonic/old_config
        mv /host/migration/minigraph.xml /etc/sonic/old_config/
        touch /tmp/pending_config_migration
+        [ -f /etc/sonic/updategraph.conf ] && sed -i -e "s/enabled=false/enabled=true/g" /etc/sonic/updategraph.conf


if updategraph does not exist, you should create in this case.

* 9dba93f disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569) * c3963c5 Fix remove ip rif (sonic-net#1535) * 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (sonic-net#1536) * a3d37f1 [console] Display success message after line cleared (sonic-net#1579) * b10c157 RADIUS Management User Authentication Feature (sonic-net#1521) * 59ed6f3 platform pre-check for reboot in master branch (sonic-net#1556) * f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519) * e296a69 No more IP validation as it is more likely a URL (sonic-net#1555) * d5f5382 [CLI][queue counters] add JSON output option for queue counters (sonic-net#1505) * 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (sonic-net#1565) * 149ccbd [techsupport] Update show ip interface command (sonic-net#1562) * 0e84418 Stop PMON docker before cold and soft reboots (sonic-net#1514) * eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (sonic-net#1560) * e57e7f7 cache the bvid to vlan translations (sonic-net#1523) * 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553) * 02b263a [voq/inbandif] Voq inbandif port (sonic-net#1363) * 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552) * 030293c Use 'importlib' module in lieu of deprecated 'imp' module (sonic-net#1450) * 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)

* 9dba93f disk_check: Check & mount RO as RW using tmpfs (#1569) * c3963c5 Fix remove ip rif (#1535) * 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (#1536) * a3d37f1 [console] Display success message after line cleared (#1579) * b10c157 RADIUS Management User Authentication Feature (#1521) * 59ed6f3 platform pre-check for reboot in master branch (#1556) * f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (#1519) * e296a69 No more IP validation as it is more likely a URL (#1555) * d5f5382 [CLI][queue counters] add JSON output option for queue counters (#1505) * 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (#1565) * 149ccbd [techsupport] Update show ip interface command (#1562) * 0e84418 Stop PMON docker before cold and soft reboots (#1514) * eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (#1560) * e57e7f7 cache the bvid to vlan translations (#1523) * 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (#1553) * 02b263a [voq/inbandif] Voq inbandif port (#1363) * 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (#1552) * 030293c Use 'importlib' module in lieu of deprecated 'imp' module (#1450) * 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (#1551)

What I did Radius Management User Authentication Feature How I did it HLD: https://github.com/Azure/SONiC/blob/master/doc/aaa/radius_authentication.md How to verify it This is the CLI only. The changes are reflected in the Redis Config DB. Previous command output (if the output of a command-line utility has changed) New command output (if the output of a command-line utility has changed) admin@sonic:~$ show radius RADIUS global auth_type pap (default) RADIUS global retransmit 3 (default) RADIUS global timeout 5 (default) RADIUS global passkey <EMPTY_STRING> (default) admin@sonic:~$ admin@sonic:~$ sudo config radius Usage: config radius [OPTIONS] COMMAND [ARGS]... RADIUS server configuration Options: -?, -h, --help Show this message and exit. Commands: add Specify a RADIUS server authtype Specify RADIUS server global auth_type [chap | pap | mschapv2] default set its default configuration delete Delete a RADIUS server nasip Specify RADIUS server global NAS-IP|IPV6-Address passkey Specify RADIUS server global passkey retransmit Specify RADIUS server global retry attempts <0 - 10> sourceip Specify RADIUS server global source ip statistics Specify RADIUS server global statistics [enable | disable |... timeout Specify RADIUS server global timeout <1 - 60> admin@sonic:~$

* 9dba93f disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569) * c3963c5 Fix remove ip rif (sonic-net#1535) * 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (sonic-net#1536) * a3d37f1 [console] Display success message after line cleared (sonic-net#1579) * b10c157 RADIUS Management User Authentication Feature (sonic-net#1521) * 59ed6f3 platform pre-check for reboot in master branch (sonic-net#1556) * f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519) * e296a69 No more IP validation as it is more likely a URL (sonic-net#1555) * d5f5382 [CLI][queue counters] add JSON output option for queue counters (sonic-net#1505) * 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (sonic-net#1565) * 149ccbd [techsupport] Update show ip interface command (sonic-net#1562) * 0e84418 Stop PMON docker before cold and soft reboots (sonic-net#1514) * eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (sonic-net#1560) * e57e7f7 cache the bvid to vlan translations (sonic-net#1523) * 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553) * 02b263a [voq/inbandif] Voq inbandif port (sonic-net#1363) * 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552) * 030293c Use 'importlib' module in lieu of deprecated 'imp' module (sonic-net#1450) * 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)

dad1287 [tunneldecaporch] Set default MTU for the overlay loopback interface (sonic-net#1756) 1bc94d1 [orchagent] Fix typo in PortsOrch::initPortSupportedSpeeds (sonic-net#1755) a44e651 [nhg]: Add support for weight in nexthop group member. (sonic-net#1752) 5c625b2 [Bulk mode] Limit the size of bulker (sonic-net#1744) d1cd0fd Fix error msg due to not supported "SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS" attributes (sonic-net#1745) 278770d [sub intf] Fix kernel side processing to enslave sub interface to non-default vrf (sonic-net#1521) 031f536 support flush FDB entries per port and per vlan (sonic-net#1064) 3629d70 [sonic-swss] Add port auto negotiation support to swss (sonic-net#1714) 7c6ebb1 [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (sonic-net#1111) fb06c32 [fabricportsorch] Add fabric support (sonic-net#1459) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>

dad1287 [tunneldecaporch] Set default MTU for the overlay loopback interface (#1756) 1bc94d1 [orchagent] Fix typo in PortsOrch::initPortSupportedSpeeds (#1755) a44e651 [nhg]: Add support for weight in nexthop group member. (#1752) 5c625b2 [Bulk mode] Limit the size of bulker (#1744) d1cd0fd Fix error msg due to not supported "SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS" attributes (#1745) 278770d [sub intf] Fix kernel side processing to enslave sub interface to non-default vrf (#1521) 031f536 support flush FDB entries per port and per vlan (#1064) 3629d70 [sonic-swss] Add port auto negotiation support to swss (#1714) 7c6ebb1 [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (#1111) fb06c32 [fabricportsorch] Add fabric support (#1459) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>

* 9dba93f disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569) * c3963c5 Fix remove ip rif (sonic-net#1535) * 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (sonic-net#1536) * a3d37f1 [console] Display success message after line cleared (sonic-net#1579) * b10c157 RADIUS Management User Authentication Feature (sonic-net#1521) * 59ed6f3 platform pre-check for reboot in master branch (sonic-net#1556) * f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519) * e296a69 No more IP validation as it is more likely a URL (sonic-net#1555) * d5f5382 [CLI][queue counters] add JSON output option for queue counters (sonic-net#1505) * 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (sonic-net#1565) * 149ccbd [techsupport] Update show ip interface command (sonic-net#1562) * 0e84418 Stop PMON docker before cold and soft reboots (sonic-net#1514) * eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (sonic-net#1560) * e57e7f7 cache the bvid to vlan translations (sonic-net#1523) * 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553) * 02b263a [voq/inbandif] Voq inbandif port (sonic-net#1363) * 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552) * 030293c Use 'importlib' module in lieu of deprecated 'imp' module (sonic-net#1450) * 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)

dad1287 [tunneldecaporch] Set default MTU for the overlay loopback interface (sonic-net#1756) 1bc94d1 [orchagent] Fix typo in PortsOrch::initPortSupportedSpeeds (sonic-net#1755) a44e651 [nhg]: Add support for weight in nexthop group member. (sonic-net#1752) 5c625b2 [Bulk mode] Limit the size of bulker (sonic-net#1744) d1cd0fd Fix error msg due to not supported "SAI_SWITCH_ATTR_MAX_NUMBER_OF_TEMP_SENSORS" attributes (sonic-net#1745) 278770d [sub intf] Fix kernel side processing to enslave sub interface to non-default vrf (sonic-net#1521) 031f536 support flush FDB entries per port and per vlan (sonic-net#1064) 3629d70 [sonic-swss] Add port auto negotiation support to swss (sonic-net#1714) 7c6ebb1 [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case (sonic-net#1111) fb06c32 [fabricportsorch] Add fabric support (sonic-net#1459) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>

Observe persistent failure of newly added vs test on testing code change in intfmgrd after migrating to azure pipeline. sonic-net#1521 passed in legacy Jenkins pipeline. What we found is that the code change in the swss compiled with PR change is not properly installed in vs docker for a direct installation using dpkg -i. This is confirmed by verifying pipeline artifacts that md5sum value of /user/bin/intfmgrd changes if we install swss deb aritfact into the docker vs artifact, while that of /usr/bin/orchangent stays unchanged. md5sum before swss install in vs docker # md5sum /usr/bin/orchagent 28307a7805ea6f3bc5057c0257bf46e6 /usr/bin/orchagent # md5sum /usr/bin/intfmgrd fa2b06e20be683286adb47c55635a86d /usr/bin/intfmgrd md5sum after swss install # dpkg -i swss_1.0.0_amd64.deb (Reading database ... 19180 files and directories currently installed.) Preparing to unpack swss_1.0.0_amd64.deb ... Unpacking swss (1.0.0) over (1.0.0) ... Setting up swss (1.0.0) ... # md5sum /usr/bin/orchagent 28307a7805ea6f3bc5057c0257bf46e6 /usr/bin/orchagent # md5sum /usr/bin/intfmgrd e959340709e7aedd7489e69dfd19768f /usr/bin/intfmgrd Signed-off-by: Wenda Ni <wonda.ni@gmail.com>

…-default vrf (sonic-net#1521) Signed-off-by: Wenda Ni <wonda.ni@gmail.com> What I did Change in IntfMgr: Use alias (instead of subIntfAlias before the change) to hold complete sub interface name; use parentAlias (instead of alias before the change) to hold parent port name. Move sub interface creation to the first place before processing fields vrf, proxy arp, and garp. In doing above, a sub interface can receive the same treatment as other types of interfaces (interface type port, type vlan) on vrf, proxy arp, and garp fields, while maintaining an indicator (parentAlias not empty) to receive treatment specific to a sub interface (creation, deletion). Why I did it Fix sonic-net#1277, sonic-net#1510 How I verified it vs test. Extended all test cases to test a sub interface ingress linked to a non-default vrf.

…net (sonic-net#1642) What I did Extended the following vs tests to validate the use case of sub interface ingress linked to a vnet: sub port interface creation sub port interface add ipv4 addresses sub port interface admin status change sub port interface remove ipv4 addresses sub port interface removal Why I did it Add vs test to validate that sonic-net#1521 fixes sonic-net#4238

Updategraph during NOS->SONiC migration

07c43b3

lguohan approved these changes Mar 23, 2018

View reviewed changes

lguohan reviewed Mar 23, 2018

View reviewed changes

lguohan merged commit dba35ee into sonic-net:master Mar 23, 2018

renukamanavalan mentioned this pull request Apr 26, 2021

submodule update: sonic-utilities #7439

Merged

4 tasks

volodymyrsamotiy mentioned this pull request May 28, 2021

[swss] Update submodule pointer #7748

Merged

4 tasks

Junchao-Mellanox mentioned this pull request May 31, 2021

[submodule] Update submodule pointer for sonic-swss #7756

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updategraph during NOS->SONiC migration #1521

Updategraph during NOS->SONiC migration #1521

padmanarayana commented Mar 21, 2018

lguohan Mar 23, 2018

Updategraph during NOS->SONiC migration #1521

Updategraph during NOS->SONiC migration #1521

Conversation

padmanarayana commented Mar 21, 2018

lguohan Mar 23, 2018

Choose a reason for hiding this comment