Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hostcfgd] Fix a bug that tacacs key is wrongly modified #1536

Merged
merged 1 commit into from
Mar 28, 2018
Merged

[hostcfgd] Fix a bug that tacacs key is wrongly modified #1536

merged 1 commit into from
Mar 28, 2018

Conversation

taoyl-ms
Copy link
Contributor

- What I did
Fix a bug introduced by #1444 that /etc/pam.d/common-auth-sonic will have wrong secret value after config aaa authentication login tacacs+.

- How to verify it

config aaa authentication login tacacs+
config tacacs add 10.0.0.3
config tacacs passkey mysecret
config aaa authentication login local
config aaa authentication login tacacs+

Before the fix /etc/pam.d/common-auth-sonic will have value secret=m*****. After the fix it will have correct value secret=mysecret.

@taoyl-ms taoyl-ms merged commit 208ca43 into sonic-net:master Mar 28, 2018
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Dec 16, 2020
@stephenxs
[submodule] Advance submodule head for sonic-swss and sonic-utilities
00e60a0 
sonic-swss:
[Dynamic buffer calc]  Support dynamic buffer calculation (sonic-net#1338)
[dvs] Clean-up dvs_database and dvs_common (sonic-net#1541)
[VxlanMgr] changes for EVPN VXLAN (sonic-net#1266)
Statistics support for Tx and Rx counters of different frame sizes (sonic-net#1536)
[orchagent/phy]: Add firmware info propagation (sonic-net#1540)
[vxlanorch] Use PRI instead of %l to avoid warnings in 32-bit arch (sonic-net#1539)
[FDBSYNCD] Added support for EVPN as described in the PR sonic-net/SONiC#437 (sonic-net#1276)
[everflow] Add retry mechanism for mirror sessions and policers (sonic-net#1486)
Enable ACL table type  mirror_v6 for Innovium Platform (sonic-net#1527)
[fgnhgorch] Change format specifier %lu to %zu for size_t (sonic-net#1529)
[dvs] Fix issue where concurrent netns operations cause test setup to fail (sonic-net#1535)
Add support for headroom pool watermark (sonic-net#1453)
Change gAsicInstance to type string with max length limit (sonic-net#1526)

sonic-utilities:
[Dynamic buffer calc] Support dynamic buffer calculation (sonic-net#973)
show tech with platform dump option (sonic-net#1158)
[kdump]: Parse sonic_platform kernel command line parameter to read the platform identifier string (sonic-net#1291)
[pcieutil] Remove 'pcie-' prefix from arguments (sonic-net#1297)
Added 'detailed' option for 'show interface counters' command (sonic-net#1299)
Fix show ip route summary on pizzabox platforms (sonic-net#1302)
[acl_loader] Fix default DENY rule for V6 dataplane ACLs (sonic-net#1281)
Add show and clear commands for headroom pool watermark  (sonic-net#1144)
[unit test][CLI][pfcwd] Added pfcwd config tests for single and multi ASIC platform. (sonic-net#1248)
[sflow] Fix traceback seen for show sflow interface (sonic-net#1282)
[config/console][consutil] Support enable/disable console switch (sonic-net#1275)
[fast-reboot] Fix fast-reboot when NDP entries are present (sonic-net#1295)
Fast-reboot: add a new flag to ignore ASIC config checksum verification failures (sonic-net#1292)
Kdump improvements (sonic-net#1284)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs mentioned this pull request Dec 16, 2020
Closed
3 tasks
@Sabareesh-Kumar-Anandan Sabareesh-Kumar-Anandan mentioned this pull request Dec 17, 2020
Closed
3 tasks
Sabareesh-Kumar-Anandan pushed a commit to Sabareesh-Kumar-Anandan/sonic-buildimage that referenced this pull request Dec 20, 2020
[sonic-swss] submodule update
5d760a0 
[crm]: Typecast to unit64_t to avoid divide by 0 during overflow (sonic-net#1550)
[vxlanmgr] Fix build error when compiling for armhf (32-bit) (sonic-net#1552)
[Dynamic buffer calc]  Support dynamic buffer calculation (sonic-net#1338)
[dvs] Clean-up dvs_database and dvs_common (sonic-net#1541)
[VxlanMgr] changes for EVPN VXLAN (sonic-net#1266)
Statistics support for Tx and Rx counters of different frame sizes (sonic-net#1536)
[orchagent/phy]: Add firmware info propagation (sonic-net#1540)

Signed-off-by: Sabareesh Kumar Anandan <sanandan@marvell.com>
@jleveque jleveque mentioned this pull request Dec 22, 2020
Merged
jleveque added a commit that referenced this pull request Dec 24, 2020
@jleveque
[sonic-swss] Update submodule (#6270)
a62f45d 
* src/sonic-swss c7ee75f...cadf28f (24):
  > Revert "Add support for headroom pool watermark (#1453)"
  > [VxlanOrch] pytest for EVPN VXLAN (#1318)
  > [restore_neighbors] python3 support for restore_neighbors.py (#1542)
  > [buffermgmt] more build error fixes when compiling for armhf (32-bit) (#1559)
  > Sflow fix to avoid NULL in field. (#1531)
  > [fgnhgorch] Fg Nhg link handling (#1537)
  > [dpb]: make sure port is in admin down state before remove port. (#1513)
  > [FPMSYNCD/FDBSYNCD] EVPN Type-5 route removing prefix-len for host route and removing junk character present in the mac (#1553)
  > Added support for EVPN L3 VXLAN as described in the PR sonic-net/SONiC#437 (#1267)
  > [crm]: Typecast to unit64_t to avoid divide by 0 during overflow (#1550)
  > [vxlanmgr] Fix build error when compiling for armhf (32-bit) (#1552)
  > [Dynamic buffer calc]  Support dynamic buffer calculation (#1338)
  > [dvs] Clean-up dvs_database and dvs_common (#1541)
  > [VxlanMgr] changes for EVPN VXLAN (#1266)
  > Statistics support for Tx and Rx counters of different frame sizes (#1536)
  > [orchagent/phy]: Add firmware info propagation (#1540)
  > [vxlanorch] Use PRI instead of %l to avoid warnings in 32-bit arch (#1539)
  > [FDBSYNCD] Added support for EVPN as described in the PR sonic-net/SONiC#437 (#1276)
  > [everflow] Add retry mechanism for mirror sessions and policers (#1486)
  > Enable ACL table type  mirror_v6 for Innovium Platform (#1527)
  > [fgnhgorch] Change format specifier %lu to %zu for size_t (#1529)
  > [dvs] Fix issue where concurrent netns operations cause test setup to fail (#1535)
  > Add support for headroom pool watermark (#1453)
  > Change gAsicInstance to type string with max length limit (#1526)
renukamanavalan added a commit to renukamanavalan/sonic-buildimage that referenced this pull request Apr 26, 2021
@renukamanavalan
submodule update: sonic-utilities
a199f24 
* 9dba93f disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569)
* c3963c5 Fix remove ip rif (sonic-net#1535)
* 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (sonic-net#1536)
* a3d37f1 [console] Display success message after line cleared (sonic-net#1579)
* b10c157 RADIUS Management User Authentication Feature (sonic-net#1521)
* 59ed6f3 platform pre-check for reboot in master branch (sonic-net#1556)
* f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519)
* e296a69 No more IP validation as it is more likely a URL (sonic-net#1555)
* d5f5382 [CLI][queue counters] add JSON output option for queue counters (sonic-net#1505)
* 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (sonic-net#1565)
* 149ccbd [techsupport] Update show ip interface command (sonic-net#1562)
* 0e84418 Stop PMON docker before cold and soft reboots (sonic-net#1514)
* eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (sonic-net#1560)
* e57e7f7 cache the bvid to vlan translations (sonic-net#1523)
* 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553)
* 02b263a [voq/inbandif] Voq inbandif port (sonic-net#1363)
* 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552)
* 030293c Use 'importlib' module in lieu of deprecated 'imp' module (sonic-net#1450)
* 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)
@renukamanavalan renukamanavalan mentioned this pull request Apr 26, 2021
Merged
4 tasks
lguohan pushed a commit that referenced this pull request Apr 27, 2021
@renukamanavalan
[submodule] update sonic-utilities (#7439)
2ff17b3 
* 9dba93f disk_check: Check & mount RO as RW using tmpfs (#1569)
* c3963c5 Fix remove ip rif (#1535)
* 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (#1536)
* a3d37f1 [console] Display success message after line cleared (#1579)
* b10c157 RADIUS Management User Authentication Feature (#1521)
* 59ed6f3 platform pre-check for reboot in master branch (#1556)
* f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (#1519)
* e296a69 No more IP validation as it is more likely a URL (#1555)
* d5f5382 [CLI][queue counters] add JSON output option for queue counters (#1505)
* 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (#1565)
* 149ccbd [techsupport] Update show ip interface command (#1562)
* 0e84418 Stop PMON docker before cold and soft reboots (#1514)
* eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (#1560)
* e57e7f7 cache the bvid to vlan translations (#1523)
* 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (#1553)
* 02b263a [voq/inbandif] Voq inbandif port (#1363)
* 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (#1552)
* 030293c Use 'importlib' module in lieu of deprecated 'imp' module (#1450)
* 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (#1551)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@ghooo
[config][generic-update] Adding apply-patch, rollback, checkpoints co…
41d8ddc 
…mmands (sonic-net#1536)

#### What I did
Adding apply-patch, rollback, replace, checkpoint, delete-checkpoint, list-checkpoints functionality.

#### How I did it
This PR is implementing the first step in in README.md in the design document: sonic-net/SONiC#736  

#### How to verify it
Using unit-tests

#### Previous command output (if the output of a command-line utility has changed)

#### New command output (if the output of a command-line utility has changed)

```sh
admin@sonic:~$ sudo config apply-patch --help
Usage: config apply-patch [OPTIONS] PATCH_FILE_PATH

  Apply given patch of updates to Config. A patch is a JsonPatch which
  follows rfc6902. This command can be used do partial updates to the config
  with minimum disruption to running processes. It allows addition as well
  as deletion of configs. The patch file represents a diff of ConfigDb(ABNF)
  format or SonicYang format.

  <patch-file-path>: Path to the patch file on the file-system.

Options:
  -f, --format [CONFIGDB|SONICYANG]
                                  format of config of the patch is either
                                  ConfigDb(ABNF) or SonicYang
  -d, --dry-run                   test out the command without affecting
                                  config state
  -v, --verbose                   print additional details of what the
                                  operation is doing
  -h, -?, --help                  Show this message and exit.



admin@sonic:~$ sudo config replace --help
Usage: config replace [OPTIONS] TARGET_FILE_PATH

  Replace the whole config with the specified config. The config is replaced
  with minimum disruption e.g. if ACL config is different between current
  and target config only ACL config is updated, and other config/services
  such as DHCP will not be affected. **WARNING** The target config file
  should be the whole config, not just the part intended to be updated.

  <target-file-path>: Path to the target file on the file-system.

Options:
  -f, --format [CONFIGDB|SONICYANG]
                                  format of target config is either
                                  ConfigDb(ABNF) or SonicYang
  -d, --dry-run                   test out the command without affecting
                                  config state
  -v, --verbose                   print additional details of what the
                                  operation is doing
  -h, -?, --help                  Show this message and exit.



admin@sonic:~$ sudo config rollback --help
Usage: config rollback [OPTIONS] CHECKPOINT_NAME

  Rollback the whole config to the specified checkpoint. The config is
  rolled back with minimum disruption e.g. if ACL config is different
  between current and checkpoint config only ACL config is updated, and
  other config/services such as DHCP will not be affected.

  <checkpoint-name>: The checkpoint name, use `config list-checkpoints`
  command to see available checkpoints.

Options:
  -d, --dry-run   test out the command without affecting config state
  -v, --verbose   print additional details of what the operation is doing
  -?, -h, --help  Show this message and exit.



admin@sonic:~$ sudo config checkpoint --help
Usage: config checkpoint [OPTIONS] CHECKPOINT_NAME

  Take a checkpoint of the whole current config with the specified
  checkpoint name.

  <checkpoint-name>: The checkpoint name, use `config list-checkpoints`
  command to see available checkpoints.

Options:
  -v, --verbose   print additional details of what the operation is doing
  -h, -?, --help  Show this message and exit.



admin@sonic:~$ sudo config delete-checkpoint --help
Usage: config delete-checkpoint [OPTIONS] CHECKPOINT_NAME

  Delete a checkpoint with the specified checkpoint name.

  <checkpoint-name>: The checkpoint name, use `config list-checkpoints`
  command to see available checkpoints.

Options:
  -v, --verbose   print additional details of what the operation is doing
  -h, -?, --help  Show this message and exit.



admin@sonic:~$ sudo config list-checkpoints --help
Usage: config list-checkpoints [OPTIONS]

  List the config checkpoints available.

Options:
  -v, --verbose   print additional details of what the operation is doing
  -?, -h, --help  Show this message and exit.
```
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@renukamanavalan @raphaelt-nvidia
[submodule] update sonic-utilities (sonic-net#7439)
00876a8 
* 9dba93f disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569)
* c3963c5 Fix remove ip rif (sonic-net#1535)
* 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (sonic-net#1536)
* a3d37f1 [console] Display success message after line cleared (sonic-net#1579)
* b10c157 RADIUS Management User Authentication Feature (sonic-net#1521)
* 59ed6f3 platform pre-check for reboot in master branch (sonic-net#1556)
* f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519)
* e296a69 No more IP validation as it is more likely a URL (sonic-net#1555)
* d5f5382 [CLI][queue counters] add JSON output option for queue counters (sonic-net#1505)
* 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (sonic-net#1565)
* 149ccbd [techsupport] Update show ip interface command (sonic-net#1562)
* 0e84418 Stop PMON docker before cold and soft reboots (sonic-net#1514)
* eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (sonic-net#1560)
* e57e7f7 cache the bvid to vlan translations (sonic-net#1523)
* 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553)
* 02b263a [voq/inbandif] Voq inbandif port (sonic-net#1363)
* 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552)
* 030293c Use 'importlib' module in lieu of deprecated 'imp' module (sonic-net#1450)
* 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@renukamanavalan
[submodule] update sonic-utilities (sonic-net#7439)
6e0f5fa 
* 9dba93f disk_check: Check & mount RO as RW using tmpfs (sonic-net#1569)
* c3963c5 Fix remove ip rif (sonic-net#1535)
* 41d8ddc [config][generic-update] Adding apply-patch, rollback, checkpoints commands (sonic-net#1536)
* a3d37f1 [console] Display success message after line cleared (sonic-net#1579)
* b10c157 RADIUS Management User Authentication Feature (sonic-net#1521)
* 59ed6f3 platform pre-check for reboot in master branch (sonic-net#1556)
* f5efe89 [acl] Use a list instead of a comma-separated string for ACL port list (sonic-net#1519)
* e296a69 No more IP validation as it is more likely a URL (sonic-net#1555)
* d5f5382 [CLI][queue counters] add JSON output option for queue counters (sonic-net#1505)
* 176cc4a 1) Loopback interfaces with valid nexthop IP are not ignored/treated as loopback. (sonic-net#1565)
* 149ccbd [techsupport] Update show ip interface command (sonic-net#1562)
* 0e84418 Stop PMON docker before cold and soft reboots (sonic-net#1514)
* eba5c04 Fix Multi-ASIC show specific resursive route by using common parsing function (sonic-net#1560)
* e57e7f7 cache the bvid to vlan translations (sonic-net#1523)
* 38f9f60 sonic-installer: fix py3 issues in bootloader.aboot (sonic-net#1553)
* 02b263a [voq/inbandif] Voq inbandif port (sonic-net#1363)
* 0539789 [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552)
* 030293c Use 'importlib' module in lieu of deprecated 'imp' module (sonic-net#1450)
* 50e5c61 Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551)
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@AkhileshSamineni
Statistics support for Tx and Rx counters of different frame sizes (s…
e0859f7 
…onic-net#1536)

Added Statistics support for Tx and Rx counters of different frames sizes.

Depends on sonic-net/sonic-utilities#1299

Added below stats
SAI_PORT_STAT_ETHER_IN_PKTS_64_OCTETS
SAI_PORT_STAT_ETHER_IN_PKTS_65_TO_127_OCTETS
SAI_PORT_STAT_ETHER_IN_PKTS_256_TO_511_OCTETS
SAI_PORT_STAT_ETHER_IN_PKTS_512_TO_1023_OCTETS
SAI_PORT_STAT_ETHER_IN_PKTS_1024_TO_1518_OCTETS
SAI_PORT_STAT_ETHER_IN_PKTS_1519_TO_2047_OCTETS
SAI_PORT_STAT_ETHER_IN_PKTS_2048_TO_4095_OCTETS
SAI_PORT_STAT_ETHER_IN_PKTS_4096_TO_9216_OCTETS
SAI_PORT_STAT_ETHER_IN_PKTS_9217_TO_16383_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_64_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_65_TO_127_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_128_TO_255_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_256_TO_511_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_512_TO_1023_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_1024_TO_1518_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_1519_TO_2047_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_2048_TO_4095_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_4096_TO_9216_OCTETS
SAI_PORT_STAT_ETHER_OUT_PKTS_9217_TO_16383_OCTETS
SAI_PORT_STAT_ETHER_STATS_JABBERS
SAI_PORT_STAT_ETHER_STATS_FRAGMENTS
SAI_PORT_STAT_ETHER_STATS_UNDERSIZE_PKTS
SAI_PORT_STAT_IP_IN_RECEIVES

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taoyl-ms @lguohan