The "debian" folder of a newly added platform driver is ignored to be uploaded. #7683
Assignees
Labels
Triaged
this issue has been triaged
Comments
|
Hi @jleveque - could you please take a look, thanks. |
|
I agree that this ignore is a bit severe, and could cause vendors to miss adding their debian directory. I will open a PR to remove this line. However, I think each vendor should be responsible for providing one or more |
4 tasks
bluecmd
added a commit
to bluecmd/sonic-buildimage
that referenced
this issue
Apr 7, 2023
Includes the common debian files that we always want to include. This mitigates but does not fully solve sonic-net#7683 as it could be more files that are ignored by this default rule. Signed-off-by: Christian Svensson <blue@cmd.nu>
8 tasks
|
I created a PR to mitigate this issue as I lost a few hours today because of files being hidden from |
lguohan
pushed a commit
that referenced
this issue
Apr 12, 2023
Includes the common debian files that we always want to include. This mitigates but does not fully solve #7683 as it could be more files that are ignored by this default rule. Signed-off-by: Christian Svensson <blue@cmd.nu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
That causes GIT to ignore all files in debian/ used to build Debian package.
A newly added platform will miss debian/ folder to finish their building.
The change is introduced by below PR:
#4803
Is that an expected behavior to ignore debian/ folder automatically and
should we upload them by another way like "git add -f" ?
Steps to reproduce the issue:
Describe the results you received:
Describe the results you expected:
Output of
show version:Output of
show techsupport:Additional information you deem important (e.g. issue happens only occasionally):
The text was updated successfully, but these errors were encountered: