[.gitignore] Do not blanket-ignore all debian directories
#7720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how can we enforce the vendor will be adding the debian in the .gitignore? |
I don't have a good idea to enforce this. Any suggestions are welcome. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Having a blanket statement to ignore all files under
platform/**/debian/can pose issues when a vendor adds a new platform, as any new files under adebian/directory will not show up in a Git changelist, therefore they can be missed in the commit.Resolves #7683
How I did it
Remove the blanket ignore statement from .gitignore. Platform vendors should be responsible for providing one or more .gitignore files to properly ignore generated files in their platform directories.
How to verify it
Which release branch to backport (provide reason below if selected)