Update README.md #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated formatting
|
updated formatting |
lguohan
pushed a commit
that referenced
this pull request
Apr 29, 2019
* Base DHCP relay Docker image on Strech base Docker * Change URL for isc-dhcp source repository * Upgrade isc-dhcp source branch to 4.3.5-3.1 * Update patch #1 to apply to isc-dhcp 4.3.5-3.1 * Update patch #2 to apply to isc-dhcp 4.3.5-3.1 * Update patch #3 to apply to isc-dhcp 4.3.5-3.1 * Update patch #4 to apply to isc-dhcp 4.3.5-3.1 * Remove security patches, as they are now applied as part of 4.3.5-3.1 source * Reorder patches to apply bug fix first, then features * Extend makefile to build debug Docker image * Update commit that series file applies against
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
…c-net#2832) * Base DHCP relay Docker image on Strech base Docker * Change URL for isc-dhcp source repository * Upgrade isc-dhcp source branch to 4.3.5-3.1 * Update patch sonic-net#1 to apply to isc-dhcp 4.3.5-3.1 * Update patch sonic-net#2 to apply to isc-dhcp 4.3.5-3.1 * Update patch sonic-net#3 to apply to isc-dhcp 4.3.5-3.1 * Update patch sonic-net#4 to apply to isc-dhcp 4.3.5-3.1 * Remove security patches, as they are now applied as part of 4.3.5-3.1 source * Reorder patches to apply bug fix first, then features * Extend makefile to build debug Docker image * Update commit that series file applies against
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
7 tasks
Gokulnath-Raja
pushed a commit
to Gokulnath-Raja/sonic-buildimage-work
that referenced
this pull request
May 22, 2023
…nfra changes (sonic-net#18) - Why I did it As part of CVL code update and new features addition, the existing CVL code has to be reorganized and common infra needs to be changed. - How I did it N/A. Please refer to change log for more details. - How to verify it No specific test cases to be executed. Run cvl go test cases using - 'make cvl-test'. - Description for the changelog Modify Makefiles Modify CVL Makefile for cleanall rule Modify Makefile for CVL YIN schema generation Modify Makefile for CVL test YIN schema generation Moved cache, syntax and semantic related code from cvl.go to cvl_cache.go, cvl_syntax.go and cvl_semantics.go respectively . Added new API signatures for integration. Implementation will be added in subsequent PRs. Copied sonic-port.yang and sonic-acl.yang to CVL own's test folder.
lguohan
pushed a commit
that referenced
this pull request
Sep 26, 2023
…bors over iBGP Session (#16705) What I did: Enable Sending BGP Community over internal neighbors over iBGP Session Microsoft ADO: 25268695 Why I did: Without this change BGP community send by e-BGP Peers are not carry-forward to other e-BGP peers. str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52141 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 16:08:26 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52688 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 15:45:51 2023 After the change str2-xxxx-lc2-2(config)# router bgp 65100 str2-xxxx-lc2-2(config-router)# address-family ipv4 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V4 send-community str2-xxxx-lc2-2(config-router-af)# exit str2-xxxx-lc2-2(config-router)# address-family ipv6 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V6 send-community str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52400 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:19 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52947 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:09 2023 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 26, 2023
…bors over iBGP Session (sonic-net#16705) What I did: Enable Sending BGP Community over internal neighbors over iBGP Session Microsoft ADO: 25268695 Why I did: Without this change BGP community send by e-BGP Peers are not carry-forward to other e-BGP peers. str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52141 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 16:08:26 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52688 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 15:45:51 2023 After the change str2-xxxx-lc2-2(config)# router bgp 65100 str2-xxxx-lc2-2(config-router)# address-family ipv4 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V4 send-community str2-xxxx-lc2-2(config-router-af)# exit str2-xxxx-lc2-2(config-router)# address-family ipv6 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V6 send-community str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52400 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:19 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52947 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:09 2023 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 26, 2023
…bors over iBGP Session (sonic-net#16705) What I did: Enable Sending BGP Community over internal neighbors over iBGP Session Microsoft ADO: 25268695 Why I did: Without this change BGP community send by e-BGP Peers are not carry-forward to other e-BGP peers. str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52141 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 16:08:26 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52688 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 15:45:51 2023 After the change str2-xxxx-lc2-2(config)# router bgp 65100 str2-xxxx-lc2-2(config-router)# address-family ipv4 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V4 send-community str2-xxxx-lc2-2(config-router-af)# exit str2-xxxx-lc2-2(config-router)# address-family ipv6 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V6 send-community str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52400 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:19 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52947 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:09 2023 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mssonicbld
pushed a commit
that referenced
this pull request
Oct 20, 2023
…bors over iBGP Session (#16705) What I did: Enable Sending BGP Community over internal neighbors over iBGP Session Microsoft ADO: 25268695 Why I did: Without this change BGP community send by e-BGP Peers are not carry-forward to other e-BGP peers. str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52141 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 16:08:26 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52688 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 15:45:51 2023 After the change str2-xxxx-lc2-2(config)# router bgp 65100 str2-xxxx-lc2-2(config-router)# address-family ipv4 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V4 send-community str2-xxxx-lc2-2(config-router-af)# exit str2-xxxx-lc2-2(config-router)# address-family ipv6 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V6 send-community str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52400 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:19 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52947 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:09 2023 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
shanshri
pushed a commit
to shanshri/sonic-buildimage-sonic-net
that referenced
this pull request
Oct 24, 2023
* Mellanox system drivers backport to kernel 4.9 This series of patches introduces support for Mellanox systems. Most of the patches is a backporting from the kernels 4.10 � 4.14 for Mellanox system drivers that have been applied upstream and a few patches contain current Mellanox upstream work � patches which are in review process for acceptances for kernels 4.16 � 4.17. This series introduces Mellanox i2c controller, mux, platform, hotplug, led, asic drivers, TI voltage controller driver and the extension of Mellanox kernel config. In series file all the patches are listed and all old patches, relevant for old 3.16 kernel are commented out. Signed-off-by: Vadim Pasternak <vadimp@melanox.com> * Mellanox system drivers backport to kernel 4.9 This series of patches introduces support for Mellanox systems. Most of the patches is a backporting from the kernels 4.10 - 4.14 for Mellanox system drivers that have been applied upstream and a few patches contain current Mellanox upstream work patches which are in review process for acceptances for kernels 4.16 - 4.17. This series introduces Mellanox i2c controller, mux, platform, hotplug, led, asic drivers, TI voltage controller driver and the extension of Mellanox kernel config. The patchset includes the bellow commits. And additional we have a code from two work in progress patchsets, which are supposed to be available in 4.17, in review in: http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git http://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git This is to make Mellanox drivers architecture independent and also extend the supported system types, since we have a number of new systems). commit ae3923a284cc696311294022e9b1a49058f07387 Author: Bhumika Goyal <bhumirks@gmail.com> Date: Mon Aug 21 17:42:04 2017 +0530 i2c: busses: make i2c_adapter_quirks const commit 26b1083b4545ec08a7dcfe759323a2e142d60d75 Author: Wolfram Sang <wsa@the-dreams.de> Date: Mon Aug 14 10:23:26 2017 +0200 i2c: mux: mlxcpld: move header file out of I2C realm commit 1da87267006246137a96682404bc0716a10c85a7 Author: Wei Yongjun <weiyongjun1@huawei.com> Date: Thu Jan 12 14:29:04 2017 +0000 i2c: mux: mlxcpld: remove unused including <linux/version.h> commit 649ac63a9ae5e08b7123f2fa98c2bf42f033bdb9 Author: Peter Rosin <peda@axentia.se> Date: Sat Dec 17 21:29:11 2016 +0100 i2c: mux: mlxcpld: fix i2c mux selection caching commit c02b7bf532f7e46f1f9a0e9c3c27ca3f6f134e8d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Nov 10 21:26:23 2016 +0000 i2c: mux: mellanox: add driver commit dca897e28f364724e42f65cf0262fa367512498d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Nov 3 19:17:19 2016 +0000 leds: verify vendor and change license in mlxcpld driver commit be4fdf99fa4dc95aa01144b207caf2cc9fa074d8 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Sep 8 07:25:53 2016 +0000 leds: add driver for Mellanox systems LEDs commit d70eaa386bf9ecc1e5b3002f64eb59172fcec4fd Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed, Nov 1 13:10:42 2017 +0200 mlxsw: i2c: Fix buffer increment counter for write transaction commit 7ca36994a3479e6d9d81baba34a426c47691ea08 Author: Arkadi Sharshevsky <arkadis@mellanox.com> Date: Wed Jun 14 09:27:39 2017 +0200 mlxsw: reg: Add MCIA register for cable info access commit 36ca68bf9919299c95ff80e7cf3c217f4c250cbe Author: Elad Raz <eladr@mellanox.com> Date: Mon Jan 9 11:25:44 2017 +0100 mlxsw: Fix mlxsw_i2c_write return value commit d556e929164fdc6c94848374fc98c40852f97adb Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Nov 16 15:20:46 2016 +0100 mlxsw: minimal: Add I2C support for Mellanox ASICs commit 6882b0aee180f2797b8803bdf699aa45c2e5f2d6 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Nov 16 15:20:44 2016 +0100 mlxsw: Introduce support for I2C bus commit ba20de060094c64a981a4fec8fecc587d076383d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Oct 18 07:26:55 2017 +0000 platform/x86: move Mellanox hardware platform hotplug driver to platform/mellanox commit 6faadbbb7f9da70ce484f98f72223c20125a1009 Author: Christoph Hellwig <hch@lst.de> Date: Thu Sep 14 11:59:30 2017 +0200 dmi: Mark all struct dmi_system_id instances const commit 9a38b67c9877a7371a250454bbbbf521d02fded5 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Dec 14 12:05:15 2016 +0000 platform/x86: mlx-platform: mlxcpld-hotplug driver style fixes commit 63d762b88cb5510f2bfdb5112ced18cde867ae61 Author: Dan Carpenter <dan.carpenter@oracle.com> Date: Sat Jan 7 09:33:34 2017 +0300 platform/x86: mlx-platform: free first dev on error commit afc4715901f0dce3206837a7051af05abf5a1e06 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Oct 27 19:55:54 2016 +0000 platform/x86: mlx-platform: Add mlxcpld-hotplug driver registration commit c3886c9d6076555697551da9b921cf6a6e9cc2b5 Author: kbuild test robot <lkp@intel.com> Date: Fri Oct 28 01:26:50 2016 +0800 platform/x86: mlx-platform: Fix semicolon.cocci warnings commit 6613d18e90385db5cdbe32fe47567a3c11575b2d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Mon Oct 31 07:22:33 2016 +0000 platform/x86: mlx-platform: Move module from arch/x86 commit 304887041d953b6692c0d4a9f8fafb252d32e9a0 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Oct 20 16:28:01 2016 +0000 platform/x86: Introduce support for Mellanox hotplug driver commit d4977c083aeb28cf72c1b019e3f9df13608126dd Author: Vadim Pasternak <vadimp@mellanox.com> Date: Tue Aug 29 20:06:21 2017 +0000 hwmon: (pmbus) Add support for Intel VID protocol VR13 commit 610526527a13e4c91e64ec3dfb4626c5043291c9 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Aug 30 22:02:14 2017 +0000 hwmon: (pmbus) Add support for Texas Instruments tps53679 device In series file all the patches are listed and all old patches, relevant for old 3.16 kernel are commented out. Signed-off-by: Vadim Pasternak <vadimp@melanox.com> * Makefile: uncomment line for applying kernel patches and config This patch uncomments lines in Makefile related to applying patches and configuration changes Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> * config: mellanox kernel configuration It adds explicit records for new configuration attributes which are not set in kernel config. Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
shanshri
pushed a commit
to shanshri/sonic-buildimage-sonic-net
that referenced
this pull request
Oct 24, 2023
* build 4.9.0-3 debian kernel * Mellanox system drivers backport to kernel 4.9 This series of patches introduces support for Mellanox systems. Most of the patches is a backporting from the kernels 4.10 � 4.14 for Mellanox system drivers that have been applied upstream and a few patches contain current Mellanox upstream work � patches which are in review process for acceptances for kernels 4.16 � 4.17. This series introduces Mellanox i2c controller, mux, platform, hotplug, led, asic drivers, TI voltage controller driver and the extension of Mellanox kernel config. In series file all the patches are listed and all old patches, relevant for old 3.16 kernel are commented out. Signed-off-by: Vadim Pasternak <vadimp@melanox.com> * Mellanox system drivers backport to kernel 4.9 This series of patches introduces support for Mellanox systems. Most of the patches is a backporting from the kernels 4.10 - 4.14 for Mellanox system drivers that have been applied upstream and a few patches contain current Mellanox upstream work patches which are in review process for acceptances for kernels 4.16 - 4.17. This series introduces Mellanox i2c controller, mux, platform, hotplug, led, asic drivers, TI voltage controller driver and the extension of Mellanox kernel config. The patchset includes the bellow commits. And additional we have a code from two work in progress patchsets, which are supposed to be available in 4.17, in review in: http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git http://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git This is to make Mellanox drivers architecture independent and also extend the supported system types, since we have a number of new systems). commit ae3923a284cc696311294022e9b1a49058f07387 Author: Bhumika Goyal <bhumirks@gmail.com> Date: Mon Aug 21 17:42:04 2017 +0530 i2c: busses: make i2c_adapter_quirks const commit 26b1083b4545ec08a7dcfe759323a2e142d60d75 Author: Wolfram Sang <wsa@the-dreams.de> Date: Mon Aug 14 10:23:26 2017 +0200 i2c: mux: mlxcpld: move header file out of I2C realm commit 1da87267006246137a96682404bc0716a10c85a7 Author: Wei Yongjun <weiyongjun1@huawei.com> Date: Thu Jan 12 14:29:04 2017 +0000 i2c: mux: mlxcpld: remove unused including <linux/version.h> commit 649ac63a9ae5e08b7123f2fa98c2bf42f033bdb9 Author: Peter Rosin <peda@axentia.se> Date: Sat Dec 17 21:29:11 2016 +0100 i2c: mux: mlxcpld: fix i2c mux selection caching commit c02b7bf532f7e46f1f9a0e9c3c27ca3f6f134e8d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Nov 10 21:26:23 2016 +0000 i2c: mux: mellanox: add driver commit dca897e28f364724e42f65cf0262fa367512498d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Nov 3 19:17:19 2016 +0000 leds: verify vendor and change license in mlxcpld driver commit be4fdf99fa4dc95aa01144b207caf2cc9fa074d8 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Sep 8 07:25:53 2016 +0000 leds: add driver for Mellanox systems LEDs commit d70eaa386bf9ecc1e5b3002f64eb59172fcec4fd Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed, Nov 1 13:10:42 2017 +0200 mlxsw: i2c: Fix buffer increment counter for write transaction commit 7ca36994a3479e6d9d81baba34a426c47691ea08 Author: Arkadi Sharshevsky <arkadis@mellanox.com> Date: Wed Jun 14 09:27:39 2017 +0200 mlxsw: reg: Add MCIA register for cable info access commit 36ca68bf9919299c95ff80e7cf3c217f4c250cbe Author: Elad Raz <eladr@mellanox.com> Date: Mon Jan 9 11:25:44 2017 +0100 mlxsw: Fix mlxsw_i2c_write return value commit d556e929164fdc6c94848374fc98c40852f97adb Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Nov 16 15:20:46 2016 +0100 mlxsw: minimal: Add I2C support for Mellanox ASICs commit 6882b0aee180f2797b8803bdf699aa45c2e5f2d6 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Nov 16 15:20:44 2016 +0100 mlxsw: Introduce support for I2C bus commit ba20de060094c64a981a4fec8fecc587d076383d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Oct 18 07:26:55 2017 +0000 platform/x86: move Mellanox hardware platform hotplug driver to platform/mellanox commit 6faadbbb7f9da70ce484f98f72223c20125a1009 Author: Christoph Hellwig <hch@lst.de> Date: Thu Sep 14 11:59:30 2017 +0200 dmi: Mark all struct dmi_system_id instances const commit 9a38b67c9877a7371a250454bbbbf521d02fded5 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Dec 14 12:05:15 2016 +0000 platform/x86: mlx-platform: mlxcpld-hotplug driver style fixes commit 63d762b88cb5510f2bfdb5112ced18cde867ae61 Author: Dan Carpenter <dan.carpenter@oracle.com> Date: Sat Jan 7 09:33:34 2017 +0300 platform/x86: mlx-platform: free first dev on error commit afc4715901f0dce3206837a7051af05abf5a1e06 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Oct 27 19:55:54 2016 +0000 platform/x86: mlx-platform: Add mlxcpld-hotplug driver registration commit c3886c9d6076555697551da9b921cf6a6e9cc2b5 Author: kbuild test robot <lkp@intel.com> Date: Fri Oct 28 01:26:50 2016 +0800 platform/x86: mlx-platform: Fix semicolon.cocci warnings commit 6613d18e90385db5cdbe32fe47567a3c11575b2d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Mon Oct 31 07:22:33 2016 +0000 platform/x86: mlx-platform: Move module from arch/x86 commit 304887041d953b6692c0d4a9f8fafb252d32e9a0 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Oct 20 16:28:01 2016 +0000 platform/x86: Introduce support for Mellanox hotplug driver commit d4977c083aeb28cf72c1b019e3f9df13608126dd Author: Vadim Pasternak <vadimp@mellanox.com> Date: Tue Aug 29 20:06:21 2017 +0000 hwmon: (pmbus) Add support for Intel VID protocol VR13 commit 610526527a13e4c91e64ec3dfb4626c5043291c9 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Aug 30 22:02:14 2017 +0000 hwmon: (pmbus) Add support for Texas Instruments tps53679 device In series file all the patches are listed and all old patches, relevant for old 3.16 kernel are commented out. Signed-off-by: Vadim Pasternak <vadimp@melanox.com> * Makefile: uncomment line for applying kernel patches and config This patch uncomments lines in Makefile related to applying patches and configuration changes Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> * exit immediately when shell commands fail * config: mellanox kernel configuration It adds explicit records for new configuration attributes which are not set in kernel config. Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> * Mellanox system drivers backport to kernel 4.9 (sonic-net#1) * Mellanox system drivers backport to kernel 4.9 This series of patches introduces support for Mellanox systems. Most of the patches is a backporting from the kernels 4.10 � 4.14 for Mellanox system drivers that have been applied upstream and a few patches contain current Mellanox upstream work � patches which are in review process for acceptances for kernels 4.16 � 4.17. This series introduces Mellanox i2c controller, mux, platform, hotplug, led, asic drivers, TI voltage controller driver and the extension of Mellanox kernel config. In series file all the patches are listed and all old patches, relevant for old 3.16 kernel are commented out. Signed-off-by: Vadim Pasternak <vadimp@melanox.com> * Mellanox system drivers backport to kernel 4.9 This series of patches introduces support for Mellanox systems. Most of the patches is a backporting from the kernels 4.10 - 4.14 for Mellanox system drivers that have been applied upstream and a few patches contain current Mellanox upstream work patches which are in review process for acceptances for kernels 4.16 - 4.17. This series introduces Mellanox i2c controller, mux, platform, hotplug, led, asic drivers, TI voltage controller driver and the extension of Mellanox kernel config. The patchset includes the bellow commits. And additional we have a code from two work in progress patchsets, which are supposed to be available in 4.17, in review in: http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git http://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git This is to make Mellanox drivers architecture independent and also extend the supported system types, since we have a number of new systems). commit ae3923a284cc696311294022e9b1a49058f07387 Author: Bhumika Goyal <bhumirks@gmail.com> Date: Mon Aug 21 17:42:04 2017 +0530 i2c: busses: make i2c_adapter_quirks const commit 26b1083b4545ec08a7dcfe759323a2e142d60d75 Author: Wolfram Sang <wsa@the-dreams.de> Date: Mon Aug 14 10:23:26 2017 +0200 i2c: mux: mlxcpld: move header file out of I2C realm commit 1da87267006246137a96682404bc0716a10c85a7 Author: Wei Yongjun <weiyongjun1@huawei.com> Date: Thu Jan 12 14:29:04 2017 +0000 i2c: mux: mlxcpld: remove unused including <linux/version.h> commit 649ac63a9ae5e08b7123f2fa98c2bf42f033bdb9 Author: Peter Rosin <peda@axentia.se> Date: Sat Dec 17 21:29:11 2016 +0100 i2c: mux: mlxcpld: fix i2c mux selection caching commit c02b7bf532f7e46f1f9a0e9c3c27ca3f6f134e8d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Nov 10 21:26:23 2016 +0000 i2c: mux: mellanox: add driver commit dca897e28f364724e42f65cf0262fa367512498d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Nov 3 19:17:19 2016 +0000 leds: verify vendor and change license in mlxcpld driver commit be4fdf99fa4dc95aa01144b207caf2cc9fa074d8 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Sep 8 07:25:53 2016 +0000 leds: add driver for Mellanox systems LEDs commit d70eaa386bf9ecc1e5b3002f64eb59172fcec4fd Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed, Nov 1 13:10:42 2017 +0200 mlxsw: i2c: Fix buffer increment counter for write transaction commit 7ca36994a3479e6d9d81baba34a426c47691ea08 Author: Arkadi Sharshevsky <arkadis@mellanox.com> Date: Wed Jun 14 09:27:39 2017 +0200 mlxsw: reg: Add MCIA register for cable info access commit 36ca68bf9919299c95ff80e7cf3c217f4c250cbe Author: Elad Raz <eladr@mellanox.com> Date: Mon Jan 9 11:25:44 2017 +0100 mlxsw: Fix mlxsw_i2c_write return value commit d556e929164fdc6c94848374fc98c40852f97adb Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Nov 16 15:20:46 2016 +0100 mlxsw: minimal: Add I2C support for Mellanox ASICs commit 6882b0aee180f2797b8803bdf699aa45c2e5f2d6 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Nov 16 15:20:44 2016 +0100 mlxsw: Introduce support for I2C bus commit ba20de060094c64a981a4fec8fecc587d076383d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Oct 18 07:26:55 2017 +0000 platform/x86: move Mellanox hardware platform hotplug driver to platform/mellanox commit 6faadbbb7f9da70ce484f98f72223c20125a1009 Author: Christoph Hellwig <hch@lst.de> Date: Thu Sep 14 11:59:30 2017 +0200 dmi: Mark all struct dmi_system_id instances const commit 9a38b67c9877a7371a250454bbbbf521d02fded5 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Dec 14 12:05:15 2016 +0000 platform/x86: mlx-platform: mlxcpld-hotplug driver style fixes commit 63d762b88cb5510f2bfdb5112ced18cde867ae61 Author: Dan Carpenter <dan.carpenter@oracle.com> Date: Sat Jan 7 09:33:34 2017 +0300 platform/x86: mlx-platform: free first dev on error commit afc4715901f0dce3206837a7051af05abf5a1e06 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Oct 27 19:55:54 2016 +0000 platform/x86: mlx-platform: Add mlxcpld-hotplug driver registration commit c3886c9d6076555697551da9b921cf6a6e9cc2b5 Author: kbuild test robot <lkp@intel.com> Date: Fri Oct 28 01:26:50 2016 +0800 platform/x86: mlx-platform: Fix semicolon.cocci warnings commit 6613d18e90385db5cdbe32fe47567a3c11575b2d Author: Vadim Pasternak <vadimp@mellanox.com> Date: Mon Oct 31 07:22:33 2016 +0000 platform/x86: mlx-platform: Move module from arch/x86 commit 304887041d953b6692c0d4a9f8fafb252d32e9a0 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Thu Oct 20 16:28:01 2016 +0000 platform/x86: Introduce support for Mellanox hotplug driver commit d4977c083aeb28cf72c1b019e3f9df13608126dd Author: Vadim Pasternak <vadimp@mellanox.com> Date: Tue Aug 29 20:06:21 2017 +0000 hwmon: (pmbus) Add support for Intel VID protocol VR13 commit 610526527a13e4c91e64ec3dfb4626c5043291c9 Author: Vadim Pasternak <vadimp@mellanox.com> Date: Wed Aug 30 22:02:14 2017 +0000 hwmon: (pmbus) Add support for Texas Instruments tps53679 device In series file all the patches are listed and all old patches, relevant for old 3.16 kernel are commented out. Signed-off-by: Vadim Pasternak <vadimp@melanox.com> * Makefile: uncomment line for applying kernel patches and config This patch uncomments lines in Makefile related to applying patches and configuration changes Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> * config: mellanox kernel configuration It adds explicit records for new configuration attributes which are not set in kernel config. Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> * [igb]: support broadcom 54616 phy for Intel igb driver (sonic-net#3) * platform/mellanox: mlxreg-hotplug driver add check for low aggregation register mask It adds verification for low aggregation register mask offset. Only non-zero offset is considered as valid. Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> * path: rename: platform-mellanox-mlxreg-hotplug-driver-add-check-fo.patch It renames platform-mellanox-mlxreg-hotplug-driver-add-check-fo.patch from 0011 to 0012, since 0011 is already exist. Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> * Update kernel with the latest upstream pacthes. Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
shanshri
pushed a commit
to shanshri/sonic-buildimage-sonic-net
that referenced
this pull request
Oct 24, 2023
Fix sonic-net#6866 Unset CONFIG_THERMAL_STATISTICS. Reason: Kernel thermal zones binding to the cooling device together with CONFIG_THERMAL_STATISTICS=y causes kernel crash as out of boundary: trans_table is two-dimensional table allocated per max cooling state (10). If statistics is configured, thermal_cooling_device_stats_update() will be called and will try to update out of boundary: stats->trans_table[stats->state * stats->max_states + new_state]++ Kernel crash with the following stack trace: ``` [ 269.474092] watchdog: watchdog1: watchdog did not stop! [ 269.533625] list_del corruption. prev->next should be ffff9e136bd57418, but was 677ac660ffffffff [ 269.543482] kernel BUG at lib/list_debug.c:53! [ 269.548458] invalid opcode: 0000 [sonic-net#1] SMP PTI [ 269.553326] CPU: 1 PID: 8890 Comm: kexec Tainted: G OE 4.19.0-9-2-amd64 sonic-net#1 Debian 4.19.118-2+deb10u1 [ 269.564891] Hardware name: Mellanox Technologies Ltd. MSN4700/VMOD0010, BIOS 5.11 11/03/2020 [ 269.574323] RIP: 0010:__list_del_entry_valid.cold.1+0x34/0x4c [ 269.580740] Code: 9f 29 a5 e8 68 7a d0 ff 0f 0b 48 c7 c7 20 a0 29 a5 e8 5a 7a d0 ff 0f 0b 48 89 f2 48 89 fe 48 c7 c7 e0 9f 29 a5 e8 46 7a d0 ff <0f> 0b 48 89 fe 48 c7 c7 a8 9f 29 a5 e8 35 7a d0 ff 0f 0b 90 90 90 [ 269.601726] RSP: 0018:ffffaddb83b5fdc0 EFLAGS: 00010246 [ 269.607561] RAX: 0000000000000054 RBX: ffff9e136bd57418 RCX: 0000000000000000 [ 269.615531] RDX: 0000000000000000 RSI: ffff9e136fa566b8 RDI: ffff9e136fa566b8 [ 269.623500] RBP: ffff9e1364bd5070 R08: 00000000000005ce R09: 0000000000000004 [ 269.631470] R10: 0000000000000766 R11: ffffffffa59f66ad R12: ffff9e136bd57400 [ 269.639440] R13: ffffffffa52c6a12 R14: ffff9e1364bd30d0 R15: 0000000000000000 [ 269.647410] FS: 00007f97227af740(0000) GS:ffff9e136fa40000(0000) knlGS:0000000000000000 [ 269.656441] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 269.662857] CR2: 000055cfdb69e158 CR3: 00000004677f6001 CR4: 00000000003606e0 [ 269.670820] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 269.678790] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 269.686760] Call Trace: [ 269.689489] device_shutdown+0xc1/0x210 [ 269.693773] kernel_kexec+0x51/0x96 [ 269.697666] __do_sys_reboot+0x1be/0x210 [ 269.702045] ? kmem_cache_free+0x1aa/0x1d0 [ 269.706618] ? __dentry_kill+0x121/0x170 [ 269.710998] ? _cond_resched+0x15/0x30 [ 269.715181] ? dentry_kill+0x4d/0x190 [ 269.719260] ? _cond_resched+0x15/0x30 [ 269.723444] do_syscall_64+0x53/0x110 [ 269.727531] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 269.733172] RIP: 0033:0x7f97228a3373 [ 269.737161] Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 89 fa be 69 19 12 28 bf ad de e1 fe b8 a9 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 05 c3 0f 1f 40 00 48 8b 15 e9 9a 0c 00 f7 d8 [ 269.758147] RSP: 002b:00007ffe11d30fa8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a9 [ 269.766602] RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007f97228a3373 [ 269.774572] RDX: 0000000045584543 RSI: 0000000028121969 RDI: 00000000fee1dead [ 269.782541] RBP: 0000000000000002 R08: 0000000000000004 R09: 000055cfdb69e160 [ 269.790511] R10: fffffffffffffb8e R11: 0000000000000202 R12: 00007ffe11d31238 [ 269.798482] R13: 0000000000000000 R14: 0000000000000000 R15: 00000000ffffffff [ 269.806443] Modules linked in: nft_chain_route_ipv4(E) xt_TCPMSS(E) sx_bfd(OE) sx_netdev(OE) psample(E) dummy(E) sx_core(OE) 8021q(E) garp(E) mrp(E) mst_pciconf(OE) mst_pci(OE) xt_hl(E) xt_tcpudp(E) ip6_tables(E) nft_compat(E) nft_counter(E) xt_conntrack(E) nf_nat(E) nf_conntrack_netlink(E) nf_conntrack(E) nf_defrag_ipv6(E) nf_defrag_ipv4(E) libcrc32c(E) xfrm_user(E) xfrm_algo(E) intel_rapl(E) mlxsw_minimal(E) sb_edac(E) mlxsw_i2c(E) x86_pkg_temp_thermal(E) mlxsw_core(E) intel_powerclamp(E) devlink(E) kvm_intel(E) bonding(E) kvm(E) i2c_mux_reg(E) i2c_mux(E) mlxreg_hotplug(E) mlxreg_io(E) leds_mlxreg(E) i2c_mlxcpld(E) mlxreg_fan(E) mxm_wmi(E) irqbypass(E) crct10dif_pclmul(E) crc32_pclmul(E) evdev(E) mlx_platform(E) ghash_clmulni_intel(E) intel_cstate(E) sg(E) intel_uncore(E) iTCO_wdt(E) pcspkr(E) [ 269.885239] intel_rapl_perf(E) ioatdma(E) iTCO_vendor_support(E) pcc_cpufreq(E) wmi(E) ebt_vlan(E) ebtable_broute(E) bridge(E) stp(E) llc(E) ebtable_nat(E) nf_tables(E) button(E) nfnetlink(E) ebtable_filter(E) ebtables(E) xdpe12284(E) at24(E) ledtrig_timer(E) tmp102(E) lm75(E) coretemp(E) max1363(E) industrialio_triggered_buffer(E) kfifo_buf(E) industrialio(E) tps53679(E) pmbus(E) pmbus_core(E) i2c_dev(E) ip_tables(E) x_tables(E) autofs4(E) loop(E) ext4(E) crc16(E) mbcache(E) jbd2(E) crc32c_generic(E) fscrypto(E) ecb(E) sd_mod(E) nvme(E) nvme_core(E) nls_utf8(E) nls_cp437(E) nls_ascii(E) vfat(E) fat(E) overlay(E) squashfs(E) zstd_decompress(E) xxhash(E) crc32c_intel(E) gpio_ich(E) ahci(E) aesni_intel(E) libahci(E) aes_x86_64(E) crypto_simd(E) xhci_pci(E) ehci_pci(E) libata(E) igb(E) ehci_hcd(E) [ 269.964036] xhci_hcd(E) cryptd(E) glue_helper(E) scsi_mod(E) i2c_algo_bit(E) i2c_i801(E) lpc_ich(E) dca(E) mfd_core(E) usbcore(E) usb_common(E) [ 269.978536] ---[ end trace 8f56c678b52f9aee ]--- [ 269.983698] RIP: 0010:__list_del_entry_valid.cold.1+0x34/0x4c [ 269.990123] Code: 9f 29 a5 e8 68 7a d0 ff 0f 0b 48 c7 c7 20 a0 29 a5 e8 5a 7a d0 ff 0f 0b 48 89 f2 48 89 fe 48 c7 c7 e0 9f 29 a5 e8 46 7a d0 ff <0f> 0b 48 89 fe 48 c7 c7 a8 9f 29 a5 e8 35 7a d0 ff 0f 0b 90 90 90 [ 270.011117] RSP: 0018:ffffaddb83b5fdc0 EFLAGS: 00010246 [ 270.016958] RAX: 0000000000000054 RBX: ffff9e136bd57418 RCX: 0000000000000000 [ 270.024935] RDX: 0000000000000000 RSI: ffff9e136fa566b8 RDI: ffff9e136fa566b8 [ 270.032912] RBP: ffff9e1364bd5070 R08: 00000000000005ce R09: 0000000000000004 [ 270.040890] R10: 0000000000000766 R11: ffffffffa59f66ad R12: ffff9e136bd57400 [ 270.048866] R13: ffffffffa52c6a12 R14: ffff9e1364bd30d0 R15: 0000000000000000 [ 270.056844] FS: 00007f97227af740(0000) GS:ffff9e136fa40000(0000) knlGS:0000000000000000 [ 270.065889] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 270.072312] CR2: 000055cfdb69e158 CR3: 00000004677f6001 CR4: 00000000003606e0 [ 270.080289] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 270.088268] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 ``` A temporary solution is to disable this config and to work with the linux community on fixing it. The solution requires fan driver update which is not trivial and will take some time to have it available on next-net before can be backported to SONiC linux-kernel. It was tested on: HwSKU: ACS-MSN2410 HwSKU: Mellanox-SN2700
rchandramouli
added a commit
to rchandramouli/sonic-buildimage
that referenced
this pull request
Oct 26, 2023
Without this change, the modules were built but not packaged in the final .bin. The final sonic-broadcom.bin has been tested for bootup on Celestica's Silverstone platform. admin@sonic:~$ uname -a Linux sonic 6.1.0-11-2-amd64 sonic-net#1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4 (2023-08-08) x86_64 GNU/Linux admin@sonic:~$ show platform summary Platform: x86_64-cel_silverstone-r0 HwSKU: Silverstone ASIC: broadcom ASIC Count: 1 Serial Number: R4009B2F062504LK200024 Model Number: N/A Hardware Revision: N/A admin@sonic:~$ show version | head SONiC Software Version: SONiC.g0aad6c67c-rachandr SONiC OS Version: 12 Distribution: Debian 12.2 Kernel: 6.1.0-11-2-amd64 Build commit: 0aad6c67c Build date: Thu Oct 26 07:13:47 UTC 2023 Built by: rachandr@AZUHPS14 Platform: x86_64-cel_silverstone-r0 Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com>
yxieca
pushed a commit
that referenced
this pull request
Oct 26, 2023
…kernel 6.1 and bookworm (#16954) * sonic-platform-modules-cel: broadcom: adapt for kernel 6.1 and bookworm The i2c_driver->remove API declaration has been updated to return void instead of int, as part of cleanup patches in 6.1. More details can be referred from here: [1]. Update the remove API definition in the modules accordingly and cleanup variables that go unused from the remove API. Update python build commands for bookworm. The packaging based on calling setup.py is deprecated and using build module/pip utility is the recommended method for python packaging/installation. Further details can be referred to from here: [2], [3]. The build module is picky about the package information file, which needs to be either setup.py or pyproject.toml. Additionally, fix formatting inconsistencies in debian/changelog reported by `dh_installchangelogs` during the build. Tested the changes by compiling the changes as below: make sonic-slave-bash NOBUSTER=1 NOBULLSEYE=1 sudo dpkg -i target/debs/bookworm/linux-headers-6.1.0-11-2-*.deb cd platform/broadcom/sonic-platform-modules-cel KVERSION=6.1.0-11-2-amd64 dpkg-buildpackage Also verified the python scripts under the sonic-platform-modules-cel with pyflakes to ensure no new errors are flagged (with exception of unused modules). References: [1] - torvalds/linux@ed5c2f5f [2] - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.htm [3] - 0b20a48 (Update Python build commands for Bookworm, 2023-09-07) Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * platform/pddf: i2c: adapt for kernel 6.1 and bookworm * Fixup i2c_driver->remove API due to changes in the function prototype (ref: [1]). * Cleanup `MODULE_SUPPORTED_DEVICE` macros that were cleaned up in the upstream (ref: [2]). * Sanitize python packaging and installation using the `build` module instead of calling the setup.py directly (ref: [3]. [4]). Tested the changes by compiling pddf module as below: make sonic-slave-bash NOBUSTER=1 NOBULLSEYE=1 sudo dpkg -i target/debs/bookworm/linux-headers-6.1.0-11-2-*.deb cd platform/pddf/i2c KVERSION=6.1.0-11-2-amd64 dpkg-buildpackage References: [1] - torvalds/linux@ed5c2f5f [2] - torvalds/linux@6417f031 [2] - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.htm [3] - 0b20a48 (Update Python build commands for Bookworm, 2023-09-07) Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * platform/broadcom: include platform-modules-cel in builds With pddf modules patched for 6.1, platform-modules-cel can be compiled and included in the final image. Testing by building sonic-broadcom.bin/sonic-broadcom-dnx.bin. Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * pddf/i2c: revert correct rootdir for pip install The pip install directory has been set to test-pkg1/ for testing the build and incorrectly retained as is. Revert this to the correct path $(PACKAGE_PRE_NAME). Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * platform/broadcom: include pddf/modules-cel in the base package Without this change, the modules were built but not packaged in the final .bin. The final sonic-broadcom.bin has been tested for bootup on Celestica's Silverstone platform. admin@sonic:~$ uname -a Linux sonic 6.1.0-11-2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4 (2023-08-08) x86_64 GNU/Linux admin@sonic:~$ show platform summary Platform: x86_64-cel_silverstone-r0 HwSKU: Silverstone ASIC: broadcom ASIC Count: 1 Serial Number: R4009B2F062504LK200024 Model Number: N/A Hardware Revision: N/A admin@sonic:~$ show version | head SONiC Software Version: SONiC.g0aad6c67c-rachandr SONiC OS Version: 12 Distribution: Debian 12.2 Kernel: 6.1.0-11-2-amd64 Build commit: 0aad6c67c Build date: Thu Oct 26 07:13:47 UTC 2023 Built by: rachandr@AZUHPS14 Platform: x86_64-cel_silverstone-r0 Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> --------- Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com>
yxieca
pushed a commit
that referenced
this pull request
Nov 7, 2023
…kernel 6.1 and bookworm (#16954) * sonic-platform-modules-cel: broadcom: adapt for kernel 6.1 and bookworm The i2c_driver->remove API declaration has been updated to return void instead of int, as part of cleanup patches in 6.1. More details can be referred from here: [1]. Update the remove API definition in the modules accordingly and cleanup variables that go unused from the remove API. Update python build commands for bookworm. The packaging based on calling setup.py is deprecated and using build module/pip utility is the recommended method for python packaging/installation. Further details can be referred to from here: [2], [3]. The build module is picky about the package information file, which needs to be either setup.py or pyproject.toml. Additionally, fix formatting inconsistencies in debian/changelog reported by `dh_installchangelogs` during the build. Tested the changes by compiling the changes as below: make sonic-slave-bash NOBUSTER=1 NOBULLSEYE=1 sudo dpkg -i target/debs/bookworm/linux-headers-6.1.0-11-2-*.deb cd platform/broadcom/sonic-platform-modules-cel KVERSION=6.1.0-11-2-amd64 dpkg-buildpackage Also verified the python scripts under the sonic-platform-modules-cel with pyflakes to ensure no new errors are flagged (with exception of unused modules). References: [1] - torvalds/linux@ed5c2f5f [2] - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.htm [3] - 0b20a48 (Update Python build commands for Bookworm, 2023-09-07) Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * platform/pddf: i2c: adapt for kernel 6.1 and bookworm * Fixup i2c_driver->remove API due to changes in the function prototype (ref: [1]). * Cleanup `MODULE_SUPPORTED_DEVICE` macros that were cleaned up in the upstream (ref: [2]). * Sanitize python packaging and installation using the `build` module instead of calling the setup.py directly (ref: [3]. [4]). Tested the changes by compiling pddf module as below: make sonic-slave-bash NOBUSTER=1 NOBULLSEYE=1 sudo dpkg -i target/debs/bookworm/linux-headers-6.1.0-11-2-*.deb cd platform/pddf/i2c KVERSION=6.1.0-11-2-amd64 dpkg-buildpackage References: [1] - torvalds/linux@ed5c2f5f [2] - torvalds/linux@6417f031 [2] - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.htm [3] - 0b20a48 (Update Python build commands for Bookworm, 2023-09-07) Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * platform/broadcom: include platform-modules-cel in builds With pddf modules patched for 6.1, platform-modules-cel can be compiled and included in the final image. Testing by building sonic-broadcom.bin/sonic-broadcom-dnx.bin. Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * pddf/i2c: revert correct rootdir for pip install The pip install directory has been set to test-pkg1/ for testing the build and incorrectly retained as is. Revert this to the correct path $(PACKAGE_PRE_NAME). Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * platform/broadcom: include pddf/modules-cel in the base package Without this change, the modules were built but not packaged in the final .bin. The final sonic-broadcom.bin has been tested for bootup on Celestica's Silverstone platform. admin@sonic:~$ uname -a Linux sonic 6.1.0-11-2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4 (2023-08-08) x86_64 GNU/Linux admin@sonic:~$ show platform summary Platform: x86_64-cel_silverstone-r0 HwSKU: Silverstone ASIC: broadcom ASIC Count: 1 Serial Number: R4009B2F062504LK200024 Model Number: N/A Hardware Revision: N/A admin@sonic:~$ show version | head SONiC Software Version: SONiC.g0aad6c67c-rachandr SONiC OS Version: 12 Distribution: Debian 12.2 Kernel: 6.1.0-11-2-amd64 Build commit: 0aad6c67c Build date: Thu Oct 26 07:13:47 UTC 2023 Built by: rachandr@AZUHPS14 Platform: x86_64-cel_silverstone-r0 Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> --------- Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 17, 2023
…bors over iBGP Session (sonic-net#16705) What I did: Enable Sending BGP Community over internal neighbors over iBGP Session Microsoft ADO: 25268695 Why I did: Without this change BGP community send by e-BGP Peers are not carry-forward to other e-BGP peers. str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52141 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 16:08:26 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52688 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 15:45:51 2023 After the change str2-xxxx-lc2-2(config)# router bgp 65100 str2-xxxx-lc2-2(config-router)# address-family ipv4 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V4 send-community str2-xxxx-lc2-2(config-router-af)# exit str2-xxxx-lc2-2(config-router)# address-family ipv6 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V6 send-community str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52400 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:19 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52947 Paths: (1 available, best sonic-net#1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:09 2023 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mssonicbld
pushed a commit
that referenced
this pull request
Nov 18, 2023
…bors over iBGP Session (#16705) What I did: Enable Sending BGP Community over internal neighbors over iBGP Session Microsoft ADO: 25268695 Why I did: Without this change BGP community send by e-BGP Peers are not carry-forward to other e-BGP peers. str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52141 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 16:08:26 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52688 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) Last update: Tue Sep 26 15:45:51 2023 After the change str2-xxxx-lc2-2(config)# router bgp 65100 str2-xxxx-lc2-2(config-router)# address-family ipv4 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V4 send-community str2-xxxx-lc2-2(config-router-af)# exit str2-xxxx-lc2-2(config-router)# address-family ipv6 str2-xxxx-lc2-2(config-router-af)# neighbor INTERNAL_PEER_V6 send-community str2-xxxx-lc1-2# show bgp ipv6 20c0:a801::/64 BGP routing table entry for 20c0:a801::/64, version 52400 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65500 2603:10e2:400::6 from 2603:10e2:400::6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:19 2023 str2-xxxx-lc1-2# show ip bgp 192.168.35.128/25 BGP routing table entry for 192.168.35.128/25, version 52947 Paths: (1 available, best #1, table default) Not advertised to any peer 65000 65502 3.3.3.6 from 3.3.3.6 (3.3.3.6) Origin IGP, localpref 100, valid, internal, best (First path received) **Community: 1111:1111** Last update: Tue Sep 26 16:10:09 2023 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
yxieca
pushed a commit
that referenced
this pull request
Nov 22, 2023
…kernel 6.1 and bookworm (#16954) * sonic-platform-modules-cel: broadcom: adapt for kernel 6.1 and bookworm The i2c_driver->remove API declaration has been updated to return void instead of int, as part of cleanup patches in 6.1. More details can be referred from here: [1]. Update the remove API definition in the modules accordingly and cleanup variables that go unused from the remove API. Update python build commands for bookworm. The packaging based on calling setup.py is deprecated and using build module/pip utility is the recommended method for python packaging/installation. Further details can be referred to from here: [2], [3]. The build module is picky about the package information file, which needs to be either setup.py or pyproject.toml. Additionally, fix formatting inconsistencies in debian/changelog reported by `dh_installchangelogs` during the build. Tested the changes by compiling the changes as below: make sonic-slave-bash NOBUSTER=1 NOBULLSEYE=1 sudo dpkg -i target/debs/bookworm/linux-headers-6.1.0-11-2-*.deb cd platform/broadcom/sonic-platform-modules-cel KVERSION=6.1.0-11-2-amd64 dpkg-buildpackage Also verified the python scripts under the sonic-platform-modules-cel with pyflakes to ensure no new errors are flagged (with exception of unused modules). References: [1] - torvalds/linux@ed5c2f5f [2] - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.htm [3] - 0b20a48 (Update Python build commands for Bookworm, 2023-09-07) Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * platform/pddf: i2c: adapt for kernel 6.1 and bookworm * Fixup i2c_driver->remove API due to changes in the function prototype (ref: [1]). * Cleanup `MODULE_SUPPORTED_DEVICE` macros that were cleaned up in the upstream (ref: [2]). * Sanitize python packaging and installation using the `build` module instead of calling the setup.py directly (ref: [3]. [4]). Tested the changes by compiling pddf module as below: make sonic-slave-bash NOBUSTER=1 NOBULLSEYE=1 sudo dpkg -i target/debs/bookworm/linux-headers-6.1.0-11-2-*.deb cd platform/pddf/i2c KVERSION=6.1.0-11-2-amd64 dpkg-buildpackage References: [1] - torvalds/linux@ed5c2f5f [2] - torvalds/linux@6417f031 [2] - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.htm [3] - 0b20a48 (Update Python build commands for Bookworm, 2023-09-07) Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * platform/broadcom: include platform-modules-cel in builds With pddf modules patched for 6.1, platform-modules-cel can be compiled and included in the final image. Testing by building sonic-broadcom.bin/sonic-broadcom-dnx.bin. Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * pddf/i2c: revert correct rootdir for pip install The pip install directory has been set to test-pkg1/ for testing the build and incorrectly retained as is. Revert this to the correct path $(PACKAGE_PRE_NAME). Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> * platform/broadcom: include pddf/modules-cel in the base package Without this change, the modules were built but not packaged in the final .bin. The final sonic-broadcom.bin has been tested for bootup on Celestica's Silverstone platform. admin@sonic:~$ uname -a Linux sonic 6.1.0-11-2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-4 (2023-08-08) x86_64 GNU/Linux admin@sonic:~$ show platform summary Platform: x86_64-cel_silverstone-r0 HwSKU: Silverstone ASIC: broadcom ASIC Count: 1 Serial Number: R4009B2F062504LK200024 Model Number: N/A Hardware Revision: N/A admin@sonic:~$ show version | head SONiC Software Version: SONiC.g0aad6c67c-rachandr SONiC OS Version: 12 Distribution: Debian 12.2 Kernel: 6.1.0-11-2-amd64 Build commit: 0aad6c67c Build date: Thu Oct 26 07:13:47 UTC 2023 Built by: rachandr@AZUHPS14 Platform: x86_64-cel_silverstone-r0 Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com> --------- Signed-off-by: Ramasamy Chandramouli <rachandr@celestica.com>
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
Revert "Revert "[YANG] add yang model for `MUX_LINKMGR|MUXLOGGER` (sonic-net#1…
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 29, 2024
#### Why I did it
Dropping control character (message sent when XSUB connects to XPUB as part of ZMQ Proxy setup to notify that subscription has been made) in do capture has been flaky since control character is not guaranteed to be the first message sent if there are events (like event-down-ctr) being published to XSUB.
Scenarios
1) Control character is sent and is first message when starting capture service
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`eventd#eventd#eventd: :- do_capture: Received subscription message when XSUB connects to XPUB`
2) Events like event-down ctr is sent before control character
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 17 sonic-events-host`
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 0 0 4 0 0 0 1 d 103 {"sonic-events-host:event-stopped-ctr":{"ctr_name":"EVENTD","timestamp":"2024-08-27T00:02:51.407518Z"}} 1 r 36 3357542f-bae1-458f-a804-660e620d21f5 1 s 1 9 1 t 19 1724716971407591080`
`heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`do_capture: Received subscription message when XSUB connects to XPUB`
3) Control character is not sent at all
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
4) Control character is delayed and not caught when starting capture service, but is then caught after causing deserialize error.
`do_capture: Receiving event from source: 22 serialization::archive 18 17 sonic-events-host, will read second part of event`
`deserialize: deserialize Failed: input stream errorstr[0:64]:(#1) data type: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&`
`zmq_read_part: Failed to deserialize part rc=-2`
`zmq_read_part: last:errno=11`
`zmq_message_read: Failure to read part1 rc=-2`
`zmq_message_read: last:errno=11`
We can cover these scenarios by just dropping the control character inside zmq_message_read as part of events_common in swsscommon (different PR). In this PR we will remove such handling logic and make sure that empty events that will be sent by control character are ignored.
##### Work item tracking
- Microsoft ADO **(number only)**:28728116
#### How I did it
Remove logic for handling control character
#### How to verify it
UT and sonic-mgmt test cases.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 4, 2024
#### Why I did it
Dropping control character (message sent when XSUB connects to XPUB as part of ZMQ Proxy setup to notify that subscription has been made) in do capture has been flaky since control character is not guaranteed to be the first message sent if there are events (like event-down-ctr) being published to XSUB.
Scenarios
1) Control character is sent and is first message when starting capture service
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`eventd#eventd#eventd: :- do_capture: Received subscription message when XSUB connects to XPUB`
2) Events like event-down ctr is sent before control character
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 17 sonic-events-host`
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 0 0 4 0 0 0 1 d 103 {"sonic-events-host:event-stopped-ctr":{"ctr_name":"EVENTD","timestamp":"2024-08-27T00:02:51.407518Z"}} 1 r 36 3357542f-bae1-458f-a804-660e620d21f5 1 s 1 9 1 t 19 1724716971407591080`
`heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`do_capture: Received subscription message when XSUB connects to XPUB`
3) Control character is not sent at all
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
4) Control character is delayed and not caught when starting capture service, but is then caught after causing deserialize error.
`do_capture: Receiving event from source: 22 serialization::archive 18 17 sonic-events-host, will read second part of event`
`deserialize: deserialize Failed: input stream errorstr[0:64]:(sonic-net#1) data type: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&`
`zmq_read_part: Failed to deserialize part rc=-2`
`zmq_read_part: last:errno=11`
`zmq_message_read: Failure to read part1 rc=-2`
`zmq_message_read: last:errno=11`
We can cover these scenarios by just dropping the control character inside zmq_message_read as part of events_common in swsscommon (different PR). In this PR we will remove such handling logic and make sure that empty events that will be sent by control character are ignored.
##### Work item tracking
- Microsoft ADO **(number only)**:28728116
#### How I did it
Remove logic for handling control character
#### How to verify it
UT and sonic-mgmt test cases.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 4, 2024
#### Why I did it
Dropping control character (message sent when XSUB connects to XPUB as part of ZMQ Proxy setup to notify that subscription has been made) in do capture has been flaky since control character is not guaranteed to be the first message sent if there are events (like event-down-ctr) being published to XSUB.
Scenarios
1) Control character is sent and is first message when starting capture service
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`eventd#eventd#eventd: :- do_capture: Received subscription message when XSUB connects to XPUB`
2) Events like event-down ctr is sent before control character
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 17 sonic-events-host`
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 0 0 4 0 0 0 1 d 103 {"sonic-events-host:event-stopped-ctr":{"ctr_name":"EVENTD","timestamp":"2024-08-27T00:02:51.407518Z"}} 1 r 36 3357542f-bae1-458f-a804-660e620d21f5 1 s 1 9 1 t 19 1724716971407591080`
`heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`do_capture: Received subscription message when XSUB connects to XPUB`
3) Control character is not sent at all
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
4) Control character is delayed and not caught when starting capture service, but is then caught after causing deserialize error.
`do_capture: Receiving event from source: 22 serialization::archive 18 17 sonic-events-host, will read second part of event`
`deserialize: deserialize Failed: input stream errorstr[0:64]:(sonic-net#1) data type: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&`
`zmq_read_part: Failed to deserialize part rc=-2`
`zmq_read_part: last:errno=11`
`zmq_message_read: Failure to read part1 rc=-2`
`zmq_message_read: last:errno=11`
We can cover these scenarios by just dropping the control character inside zmq_message_read as part of events_common in swsscommon (different PR). In this PR we will remove such handling logic and make sure that empty events that will be sent by control character are ignored.
##### Work item tracking
- Microsoft ADO **(number only)**:28728116
#### How I did it
Remove logic for handling control character
#### How to verify it
UT and sonic-mgmt test cases.
mssonicbld
pushed a commit
that referenced
this pull request
Sep 4, 2024
#### Why I did it
Dropping control character (message sent when XSUB connects to XPUB as part of ZMQ Proxy setup to notify that subscription has been made) in do capture has been flaky since control character is not guaranteed to be the first message sent if there are events (like event-down-ctr) being published to XSUB.
Scenarios
1) Control character is sent and is first message when starting capture service
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`eventd#eventd#eventd: :- do_capture: Received subscription message when XSUB connects to XPUB`
2) Events like event-down ctr is sent before control character
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 17 sonic-events-host`
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 0 0 4 0 0 0 1 d 103 {"sonic-events-host:event-stopped-ctr":{"ctr_name":"EVENTD","timestamp":"2024-08-27T00:02:51.407518Z"}} 1 r 36 3357542f-bae1-458f-a804-660e620d21f5 1 s 1 9 1 t 19 1724716971407591080`
`heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`do_capture: Received subscription message when XSUB connects to XPUB`
3) Control character is not sent at all
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
4) Control character is delayed and not caught when starting capture service, but is then caught after causing deserialize error.
`do_capture: Receiving event from source: 22 serialization::archive 18 17 sonic-events-host, will read second part of event`
`deserialize: deserialize Failed: input stream errorstr[0:64]:(#1) data type: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&`
`zmq_read_part: Failed to deserialize part rc=-2`
`zmq_read_part: last:errno=11`
`zmq_message_read: Failure to read part1 rc=-2`
`zmq_message_read: last:errno=11`
We can cover these scenarios by just dropping the control character inside zmq_message_read as part of events_common in swsscommon (different PR). In this PR we will remove such handling logic and make sure that empty events that will be sent by control character are ignored.
##### Work item tracking
- Microsoft ADO **(number only)**:28728116
#### How I did it
Remove logic for handling control character
#### How to verify it
UT and sonic-mgmt test cases.
mssonicbld
pushed a commit
that referenced
this pull request
Sep 4, 2024
#### Why I did it
Dropping control character (message sent when XSUB connects to XPUB as part of ZMQ Proxy setup to notify that subscription has been made) in do capture has been flaky since control character is not guaranteed to be the first message sent if there are events (like event-down-ctr) being published to XSUB.
Scenarios
1) Control character is sent and is first message when starting capture service
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`eventd#eventd#eventd: :- do_capture: Received subscription message when XSUB connects to XPUB`
2) Events like event-down ctr is sent before control character
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 17 sonic-events-host`
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 0 0 4 0 0 0 1 d 103 {"sonic-events-host:event-stopped-ctr":{"ctr_name":"EVENTD","timestamp":"2024-08-27T00:02:51.407518Z"}} 1 r 36 3357542f-bae1-458f-a804-660e620d21f5 1 s 1 9 1 t 19 1724716971407591080`
`heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`do_capture: Received subscription message when XSUB connects to XPUB`
3) Control character is not sent at all
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
4) Control character is delayed and not caught when starting capture service, but is then caught after causing deserialize error.
`do_capture: Receiving event from source: 22 serialization::archive 18 17 sonic-events-host, will read second part of event`
`deserialize: deserialize Failed: input stream errorstr[0:64]:(#1) data type: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&`
`zmq_read_part: Failed to deserialize part rc=-2`
`zmq_read_part: last:errno=11`
`zmq_message_read: Failure to read part1 rc=-2`
`zmq_message_read: last:errno=11`
We can cover these scenarios by just dropping the control character inside zmq_message_read as part of events_common in swsscommon (different PR). In this PR we will remove such handling logic and make sure that empty events that will be sent by control character are ignored.
##### Work item tracking
- Microsoft ADO **(number only)**:28728116
#### How I did it
Remove logic for handling control character
#### How to verify it
UT and sonic-mgmt test cases.
vvolam
pushed a commit
to vvolam/sonic-buildimage
that referenced
this pull request
Sep 12, 2024
#### Why I did it
Dropping control character (message sent when XSUB connects to XPUB as part of ZMQ Proxy setup to notify that subscription has been made) in do capture has been flaky since control character is not guaranteed to be the first message sent if there are events (like event-down-ctr) being published to XSUB.
Scenarios
1) Control character is sent and is first message when starting capture service
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`eventd#eventd#eventd: :- do_capture: Received subscription message when XSUB connects to XPUB`
2) Events like event-down ctr is sent before control character
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 17 sonic-events-host`
`eventd#eventd#eventd: :- run: Dropping Message: 22 serialization::archive 18 0 0 4 0 0 0 1 d 103 {"sonic-events-host:event-stopped-ctr":{"ctr_name":"EVENTD","timestamp":"2024-08-27T00:02:51.407518Z"}} 1 r 36 3357542f-bae1-458f-a804-660e620d21f5 1 s 1 9 1 t 19 1724716971407591080`
`heartbeat_ctrl: Set heartbeat_ctrl pause=1`
`do_capture: Received subscription message when XSUB connects to XPUB`
3) Control character is not sent at all
`eventd#eventd#eventd: :- heartbeat_ctrl: Set heartbeat_ctrl pause=1`
4) Control character is delayed and not caught when starting capture service, but is then caught after causing deserialize error.
`do_capture: Receiving event from source: 22 serialization::archive 18 17 sonic-events-host, will read second part of event`
`deserialize: deserialize Failed: input stream errorstr[0:64]:(sonic-net#1) data type: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&`
`zmq_read_part: Failed to deserialize part rc=-2`
`zmq_read_part: last:errno=11`
`zmq_message_read: Failure to read part1 rc=-2`
`zmq_message_read: last:errno=11`
We can cover these scenarios by just dropping the control character inside zmq_message_read as part of events_common in swsscommon (different PR). In this PR we will remove such handling logic and make sure that empty events that will be sent by control character are ignored.
##### Work item tracking
- Microsoft ADO **(number only)**:28728116
#### How I did it
Remove logic for handling control character
#### How to verify it
UT and sonic-mgmt test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated formatting