-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #2
Conversation
Updated formatting
## 3. initramfs-tools with loop device support | ||
Run the script to build the .deb file into ./deps directory. | ||
## Prerequisites | ||
**1.** Build environment - Preferably use [the Dockerfile](https://github.com/Azure/sonic-build-tools/blob/master/sonic-slave/Dockerfile), or use Debian Jessie and manually install packages appearing in the Dockerfile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this 1. does not format well in github.com, can you check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dell - Internal Use - Confidential
Added a space after 1.
From: lguohan [mailto:notifications@github.com]
Sent: Tuesday, August 02, 2016 4:09 PM
To: Azure/sonic-buildimage sonic-buildimage@noreply.github.com
Cc: Buck, Amy Amy_Buck@Dell.com; Author author@noreply.github.com
Subject: Re: [Azure/sonic-buildimage] Update README.md (#2)
In README.mdhttps://github.com//pull/2#discussion_r73254981:
-# Prerequisite
-## 1. Build environment
-Preferably use the Dockerfile, or use Debian Jessie and manually install packages appearing in the Dockerfile.
-## 2. Linux kernel with switch drivers
-Build the Azure/sonic-linux-kernel project and copy the output .deb file into ./deps directory.
-## 3. initramfs-tools with loop device support
-Run the script to build the .deb file into ./deps directory.
+## Prerequisites
+1. Build environment - Preferably use the Dockerfile, or use Debian Jessie and manually install packages appearing in the Dockerfile.
this 1. does not format well in github.com, can you check.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/2/files/3bc2f7b051a939154b4b94bb651780d30325acd4#r73254981, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AToLHI161lIspRY3Yx6wmTD9igYJObMCks5qb84ggaJpZM4Ja18Y.
close it for now and wait for new PR in the future |
- What I did Fixed vanilla teamd bug, which prevented teamd to have a correct view of kernel state. Check bug #2 from the message Changed schema for LACP port id. Changed severity of an error message. Removed logic to disable warm_start_read mode, when teamd started. It didn't work in system restart mode, because interfaces were added one by one, and it's impossible to say when everything is added. - How I did it I've added team_refresh() on every port addition I extract port id from the port name. Currently I support only "EthernetX" scheme. We need to add more schemes if we change port scheme. _err -> _info ... - How to verify it Build the image, install on your DUT, reboot it once, then reboot it on WR mode checking LACP state on remote side. The state shouldn't flip.
* Base DHCP relay Docker image on Strech base Docker * Change URL for isc-dhcp source repository * Upgrade isc-dhcp source branch to 4.3.5-3.1 * Update patch #1 to apply to isc-dhcp 4.3.5-3.1 * Update patch #2 to apply to isc-dhcp 4.3.5-3.1 * Update patch #3 to apply to isc-dhcp 4.3.5-3.1 * Update patch #4 to apply to isc-dhcp 4.3.5-3.1 * Remove security patches, as they are now applied as part of 4.3.5-3.1 source * Reorder patches to apply bug fix first, then features * Extend makefile to build debug Docker image * Update commit that series file applies against
…c-net#2832) * Base DHCP relay Docker image on Strech base Docker * Change URL for isc-dhcp source repository * Upgrade isc-dhcp source branch to 4.3.5-3.1 * Update patch sonic-net#1 to apply to isc-dhcp 4.3.5-3.1 * Update patch sonic-net#2 to apply to isc-dhcp 4.3.5-3.1 * Update patch sonic-net#3 to apply to isc-dhcp 4.3.5-3.1 * Update patch sonic-net#4 to apply to isc-dhcp 4.3.5-3.1 * Remove security patches, as they are now applied as part of 4.3.5-3.1 source * Reorder patches to apply bug fix first, then features * Extend makefile to build debug Docker image * Update commit that series file applies against
* change package name to sonic-utilities
…onic-net#2) * [yang-models]: First version of yang models for Port, VLan and ACL. RB= G=lnos-reviewers R=pchaudhary,pmao,rmolina,samaity,sfardeen,zxu A= * [yangModelTesting.py]: Test code for POC. Minor Corrections in yang model files. * [sonic-interface.yang]: Interface yang model. Minor changes in yang tree and other models. * [Sonic Yang Tree]: Modified YANG models as per Guidelines. Guideline doc: https://github.com/Azure/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md
* Fix the stack-overflow issue in AclOrch::getTableById() In case the table_id and m_mirrorTableId/m_mirrorTableId are empty The function would be called recursively without ending. ``` If we have some rule that does not have table defined, it will trigger this issue. (gdb) bt #0 0x00007f77ac5af3a9 in swss::Logger::write (this=0x7f77ac801ec0 <swss::Logger::getInstance()::m_logger>, prio=swss::Logger::SWSS_DEBUG, fmt=0x7f77ac5f1690 ":> %s: enter") at logger.cpp:209 #1 0x00000000004a5792 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2617 #2 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 #3 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 ... #20944 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 #20945 0x00000000004ad3ce in AclOrch::doAclRuleTask (this=this@entry=0x1c722a0, consumer=...) at aclorch.cpp:2437 #20946 0x00000000004b04cd in AclOrch::doTask (this=0x1c722a0, consumer=...) at aclorch.cpp:2141 #20947 0x00000000004231b2 in Orch::doTask (this=0x1c722a0) at orch.cpp:369 #20948 0x000000000041c4e9 in OrchDaemon::start (this=this@entry=0x1c19960) at orchdaemon.cpp:376 #20949 0x0000000000409ffc in main (argc=<optimized out>, argv=0x7ffe2e392d68) at main.cpp:295 (gdb) p table_id $1 = "" (gdb) p m_mirrorTableId $2 = "" (gdb) p m_mirrorV6TableId $3 = "" ``` Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
Signed-off-by: Andrew Sapronov <andrew.sapronov@gmail.com>
11/2 Pull latest changes from master
VRRP MF CLI & OC-YANG support
Signed-off-by: Andrew Sapronov <andrew.sapronov@gmail.com>
* [cbf] Added initial CBF support (sonic-net#2) * Added CBF NHG support to NhgOrch * Added NhgMapOrch to handle DSCP_TO_FC and EXP_TO_FC tables * Added UT for the new NhgOrch function and NhgMapOrch Support sonic-net/SONiC#796 Co-authored-by: Alexandru Banu <v-albanu@microsoft.com>
The follwing commit is added in sonic-utilities b034f0c (HEAD -> 202012, origin/202012) [config][muxcable] add support to enable/disable ycable telemetry (sonic-net#2… (sonic-net#2304) The follwing commit is added in sonic-platform-daemons 978667c (HEAD -> 202012, origin/202012) [ycabled] add capability to enable/disable telemetry (sonic-net#279) (sonic-net#280 Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
…11684) The follwing commit is added in sonic-utilities b034f0c (HEAD -> 202012, origin/202012) [config][muxcable] add support to enable/disable ycable telemetry (#2… (#2304) The follwing commit is added in sonic-platform-daemons 978667c (HEAD -> 202012, origin/202012) [ycabled] add capability to enable/disable telemetry (#279) (#280 Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
#### Why I did it Update sonic-host-services submodule to include below commits: ``` bc8698d Merge pull request #21 from abdosi/feature 557a110 Fix the issue where if dest port is not specified in ACL rule than for multi-asic where we create NAT rule to forward traffic from Namespace to host fail with exception. 6e45acc (master) Merge pull request #14 from abdosi/feature 4d6cad7 Merge remote-tracking branch 'upstream/master' into feature bceb13e Install libyang to azure pipeline (#20) 82299f5 Merge pull request #13 from SuvarnaMeenakshi/cacl_fabricns 15d3bf4 Merge branch 'master' into cacl_fabricns de54082 Merge pull request #16 from ZhaohuiS/feature/caclmgrd_external_client_warning_log b4b368d Add warning log if destination port is not defined d4bb96d Merge branch 'master' into cacl_fabricns 35c76cb Add unit-test and fix typo. 17d44c2 Made Changes to be Python 3.7 compatible 978afb5 Aligning Code 1fbf8fb Merge remote-tracking branch 'upstream/master' into feature 7b8c7d1 Added UT for the changes 91c4c42 Merge pull request #9 from ZhaohuiS/feature/caclmgrd_external_client 7c0b56a Add 4 test cases for external_client_acl, including single port and port range for ipv4 and ipv6 b71e507 Merge remote-tracking branch 'origin/master' into HEAD d992dc0 Merge branch 'master' into feature/caclmgrd_external_client bd7b172 DST_PORT is configuralbe in json config file for EXTERNAL_CLIENT_ACL f9af7ae [CLI] Move hostname, mgmt interface/vrf config to hostcfgd (#2) 70ce6a3 Merge pull request #10 from sujinmkang/cold_reset 29be8d2 Added Support to render Feature Table using Device running metadata. Also added support to render 'has_asic_scope' field of Feature Table. 3437e35 [caclmgrd][chassis]: Add ip tables rules to accept internal docker traffic from fabric asic namespaces. 8720561 Fix and add hardware reboot cause determination tests 0dcc7fe remove the empty bracket if no hardware reboot cause minor e47d831 fix the wrong expected result comparision ef86b53 Fix startswith Attribute error 8a630bb fix mock patch 8543ddf update the reboot cause logic and update the unit test 53ad7cd fix the mock patch function 7c8003d fix the reboot-cause regix for test 1ba611f fix typo 25379d3 Add unit test case a56133b Add hardware reboot cause as actual reboot cause for soft reboot failed c7d3833 Support Restapi/gnmi control plane acls f6ea036 caclmgrd: Don't block traffic to mgmt by default a712fc4 Update test cases adc058b caclmgrd: Don't block traffic to mgmt by default 06ff918 Merge pull request #7 from bluecmd/patch-1 e3e23bc ci: Rename sonic-buildimage repository e83a858 Merge pull request #4 from kamelnetworks/acl-ip2me-test f5a2e50 [caclmgrd]: Tests for IP2ME rules generation ```
Currently, ASAN sometimes reports the BufferOrch::m_buffer_type_maps and QosOrch::m_qos_maps as leaked. However, their lifetime is the lifetime of a process so they are not really 'leaked'. This also adds a simple way to add more suppressions later if required. Example of ASAN report: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) #1 0x55ca1da9f789 in __static_initialization_and_destruction_0 /__w/2/s/orchagent/bufferorch.cpp:39 #2 0x55ca1daa02af in _GLOBAL__sub_I_bufferorch.cpp /__w/2/s/orchagent/bufferorch.cpp:1321 #3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) #1 0x55ca1da6d2da in __static_initialization_and_destruction_0 /__w/2/s/orchagent/qosorch.cpp:80 #2 0x55ca1da6ecf2 in _GLOBAL__sub_I_qosorch.cpp /__w/2/s/orchagent/qosorch.cpp:2000 #3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) - What I did Added an lsan suppression config with static variable leak suppression - Why I did it To suppress ASAN false positives - How I verified it Run a test that produces the static variable leaks report and checked that report has these leaks suppressed. Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
…EV-225_features_are_enabled_in_the_build_radius Enable RADIUS flag
…EV-225_features_are_enabled_in_the_build_radius Enable RADIUS flag
…ing fastboot Fix fastreboot path to shutdown SLB neighbors during fastboot This issue was found when the new build on internal branch started failing. Build failure log: ``` Applying patch ../sonic-utilities.patch/0002-Stopping-all-BGP-SLB-neighbors-if-they-re-presented-.patch patching file scripts/fast-reboot Hunk sonic-net#1 succeeded at 43 with fuzz 1 (offset 7 lines). Hunk sonic-net#2 FAILED at 123. Hunk sonic-net#3 succeeded at 502 with fuzz 1 (offset 81 lines). Hunk sonic-net#4 succeeded at 582 (offset 95 lines). 1 out of 4 hunks FAILED -- rejects in file scripts/fast-reboot ``` Repro'd this locally: ``` vadixit@DevVM-20:~/workspace/Networking-acs-buildimage/src/sonic-utilities$ quilt push -a Applying patch patches/0002-Stopping-all-BGP-SLB-neighbors-if-they-re-presented-.patch patching file scripts/fast-reboot Hunk sonic-net#1 succeeded at 42 with fuzz 1 (offset 6 lines). Hunk sonic-net#2 FAILED at 123. Hunk sonic-net#3 succeeded at 489 with fuzz 1 (offset 68 lines). Hunk sonic-net#4 succeeded at 569 (offset 82 lines). 1 out of 4 hunks FAILED -- rejects in file scripts/fast-reboot Patch patches/0002-Stopping-all-BGP-SLB-neighbors-if-they-re-presented-.patch does not apply (enforce with -f) ``` Issue fixed with this change: ``` vadixit@DevVM-20:~/workspace/Networking-acs-buildimage/src/sonic-utilities$ quilt push -a Applying patch patches/0001-fast-reboot-patch-Handle-SLB-neighbors-shutdown-duri.patch patching file scripts/fast-reboot Now at patch patches/0001-fast-reboot-patch-Handle-SLB-neighbors-shutdown-duri.patch ``` Additionally, changed the series file and renamed the 0002 patch as 0001 patch as this is the only patch on this branch right now.
…h expression (sonic-net#19) Why I did it Adding YValidator support so that xpath expression (must/when/leafref) can be evaluated using custom xpath engine. Custom xpath engine will be integrated in subsequent PR. How I did it N/A. Please refer to change log for more details. How to verify it No specific test cases to be executed. Run cvl go test cases using - 'make cvl-test'. Description for the changelog Modifying cvl.go for adding new data structure to store cache in CVL session cache, add YValidator data type. Adding API to get Redis table name from YANG list. Modifying cvl_api.go and cvl_cache.go due to change in session cache. Modifying cvl_syntax.go due to change in API name. Modifying cvl_semantics.go to add various API which can operate on YValidator nodes.
…ial-number-from-STATE_DB Add serial_num field into device_info
[submodule sonic-utilities update] to latest head: * 24d0d1c Update portstat (sonic-net#2877) * 0b87808 [Add display support for serial field in show chassis modules status C…] * 75ca81e [202205][config]Support multi-asic Golden Config override with fix (#… …2825) (sonic-net#2862) * ec47214 [fix show interface neighbor expected empty issue (sonic-net#2465)] * d1f4413 [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan (sonic-net#2… …852) * 051f28c [db-migrator] Fix hwsku match for 6100 and add errors when hwsku is N… …one (sonic-net#2821) * cd08aa6 [show][muxcable] add some new commands health, reset-cause, queue_inf… …o support for muxcable (sonic-net#2853)
Updated formatting