-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Add CPU thermal control for Nvidia platforms #10202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
keboliu
previously approved these changes
Mar 11, 2022
@sujinmkang would you please help to review? |
liat-grozovik
previously requested changes
Mar 20, 2022
platform/mellanox/mlnx-platform-api/sonic_platform/cpu_thermal_control.py
Show resolved
Hide resolved
sujinmkang
approved these changes
Mar 21, 2022
liat-grozovik
approved these changes
Mar 21, 2022
sujinmkang
dismissed
liat-grozovik’s stale review
March 21, 2022 16:54
change request looks addressed all.
liat-grozovik
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 24, 2022
…#5309) Add test case for PR sonic-net/sonic-buildimage#10202 - How did you do it? Mock changing CPU temperature and verify cooling level is updated by algorithm accordingly - How did you verify/test it? Run the new test and passed. - Any platform specific information? Mellanox/Nvidia SN4800 platform
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-mgmt
that referenced
this pull request
Apr 13, 2022
…sonic-net#5309) Add test case for PR sonic-net/sonic-buildimage#10202 - How did you do it? Mock changing CPU temperature and verify cooling level is updated by algorithm accordingly - How did you verify/test it? Run the new test and passed. - Any platform specific information? Mellanox/Nvidia SN4800 platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add CPU thermal control for Nvidia platforms which will be enabled for platforms that have heavy CPU load. Now it is only enabled on 4800, and it will be enabled on future platforms.
How I did it
Check CPU pack temperature and update cooling level accordingly
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)