Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add test case for CPU thermal control algorithm #5309

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

Junchao-Mellanox
Copy link
Contributor

Change-Id: I6b84375769673b22dfb2e2e21e27c14e895838aa

Description of PR

Summary:
Add test case for PR sonic-net/sonic-buildimage#10202

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

Add test case for PR sonic-net/sonic-buildimage#10202

How did you do it?

Mock changing CPU temperature and verify cooling level is updated by algorithm accordingly

How did you verify/test it?

Run the new test and passed.

Any platform specific information?

Mellanox/Nvidia SN4800 platform

Supported testbed topology if it's a new test case?

N/A

Documentation

Change-Id: I6b84375769673b22dfb2e2e21e27c14e895838aa
@liat-grozovik
Copy link
Collaborator

@Junchao-Mellanox can the test run against 202012 and above? if only on master and above i suggest to exclude some branches.
can you please double check?

Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@Junchao-Mellanox
Copy link
Contributor Author

Junchao-Mellanox commented Mar 24, 2022

Hi Liat, the case will only run on SN4800 for now, it might also be run on future platforms, but any existing platforms do not support this test case. So I assume the following existing line is good enough to skip it for now:

pytest_require(dut_platform == "x86_64-nvidia_sn4800-r0", 'This test case is only for platform x86_64-nvidia_sn4800-r0, skipping...')

@liat-grozovik liat-grozovik merged commit 42d4503 into sonic-net:master Mar 24, 2022
xwjiang-ms pushed a commit to xwjiang-ms/sonic-mgmt that referenced this pull request Apr 13, 2022
…sonic-net#5309)

Add test case for PR sonic-net/sonic-buildimage#10202

- How did you do it?
Mock changing CPU temperature and verify cooling level is updated by algorithm accordingly

- How did you verify/test it?
Run the new test and passed.

- Any platform specific information?
Mellanox/Nvidia SN4800 platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants