[Ci]: check if there is a sonic dirty version issue #10445
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| steps: | ||
| - script: | | ||
| . functions.sh | ||
| SONIC_VERSION=$(sonic_get_version) | ||
| echo "SONIC_VERSION=$SONIC_VERSION" | ||
| if [[ "$SONIC_VERSION" == *dirty* ]]; then | ||
| # Print the detail dirty info | ||
| git status --untracked-files=no -s --ignore-submodules | ||
|
|
||
| # Exit with error, if it is a PR build | ||
|
There was a problem hiding this comment. We can block official build if the issue has fixed in all release branches. There was a problem hiding this comment. It seems that this step will change in future. There was a problem hiding this comment. The check-dirty-version.yml is a template file. |
||
| if [ "$(Build.Reason)" == "PullRequest" ]; then | ||
| echo "Build failed for the dirty version: $SONIC_VERSION" 1>&2 | ||
| exit 1 | ||
| fi | ||
| fi | ||
| displayName: "Check the dirty version" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it too late. If we detect dirty, we don't need to build at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qiluo-msft , the dirty is detected after build, during the build, we do not know which target introduce the dirty issue. In most cases, no one changes the source code, if some one changes it, it has value to wait for the build complete and detect it.
The check only impacts someone tries to do some bad thing, and not have any impact on the other cases.