[Ci]: check if there is a sonic dirty version issue #10445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
commented
Apr 2, 2022
| # Print the detail dirty info | ||
| git status --untracked-files=no -s --ignore-submodules | ||
|
|
||
| # Exit with error, if it is a PR build |
There was a problem hiding this comment.
We can block official build if the issue has fixed in all release branches.
There was a problem hiding this comment.
It seems that this step will change in future.
Can we use a template in master branch?
There was a problem hiding this comment.
The check-dirty-version.yml is a template file.
xumia
force-pushed
the
check-dirty-version
branch
from
b06db58 to
c715d22
Compare
xumia
added
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
liushilongbuaa
previously approved these changes
Apr 7, 2022
| # Print the detail dirty info | ||
| git status --untracked-files=no -s --ignore-submodules | ||
|
|
||
| # Exit with error, if it is a PR build |
There was a problem hiding this comment.
It seems that this step will change in future.
Can we use a template in master branch?
|
@liushilongbuaa , please help review again, fix a bash string any string comparing issue, and verify it works as expected. See the check in #10495 |
qiluo-msft
reviewed
Apr 8, 2022
| @@ -131,3 +131,4 @@ jobs: | |||
| make $BUILD_OPTIONS target/sonic-$(GROUP_NAME).bin | |||
| fi | |||
| displayName: "Build sonic image" | |||
| - template: check-dirty-version.yml | |||
There was a problem hiding this comment.
@qiluo-msft , the dirty is detected after build, during the build, we do not know which target introduce the dirty issue. In most cases, no one changes the source code, if some one changes it, it has value to wait for the build complete and detect it.
The check only impacts someone tries to do some bad thing, and not have any impact on the other cases.
qiluo-msft
approved these changes
Apr 8, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Apr 11, 2022
Why I did it [Ci]: check if there is a sonic dirty version issue If there is a dirty version issue in PR build, the build will be failed.
qiluo-msft
pushed a commit
that referenced
this pull request
Apr 11, 2022
Why I did it [Ci]: check if there is a sonic dirty version issue If there is a dirty version issue in PR build, the build will be failed.
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 20, 2022
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
[Ci]: check if there is a sonic dirty version issue
If there is a dirty version issue in PR build, the build will be failed.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)