Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gbsyncd and swss inter dependency #10501

Closed
anamehra opened this issue Apr 8, 2022 · 1 comment · Fixed by #10504
Closed

Fix gbsyncd and swss inter dependency #10501

anamehra opened this issue Apr 8, 2022 · 1 comment · Fixed by #10504
Assignees
@abdosi
Labels
Triaged this issue has been triaged

Comments

@anamehra
Copy link
Contributor

anamehra commented Apr 8, 2022

Description

In current software, it appears that gbsyncd restart is required when syncd and swss services restart manually or due to a failure. If gbsyncd service does not restart, swss keeps failing until systemd puts the service in failed state. It appears that gbsyncd is required to be restarted when swss restart, like syncd which is restated every time swss restarts.

This bug is to investigate the swss - gbsyncd interdependency and remove any dependency if possible, otherwise define systemd and peer service dependency properly for restartability.

gbsyncd is not defined as restartable process in systemd, that also needs to be fixed if required for restart capability.

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):
@anamehra
Copy link
Contributor Author

anamehra commented Apr 8, 2022

Hi @abdosi , FYI-

@jimmyzhai jimmyzhai mentioned this issue Apr 8, 2022
Merged
6 tasks
@prsunny prsunny added the Triaged this issue has been triaged label Apr 13, 2022
jimmyzhai added a commit that referenced this issue Apr 20, 2022
@jimmyzhai
[gearbox] Add peer gbsyncd for swss if gearbox exists (#10504)
128d762 
Fix the issues #10501 and #9733

If having gearbox, we need:
    * add gbsyncd as a peer since swss also has dependency on gbsyncd
    * add service gbsyncd to FEATURE table if it is missing
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this issue Jun 20, 2022
@yxieca
Merged PR 6004325: Manual merge github master to internal
19c4542 
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdosi abdosi

Labels
Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[gearbox] Add peer gbsyncd for swss if gearbox exists jimmyzhai/sonic-buildimage
3 participants
@prsunny @anamehra @abdosi