Streaming structured events implementation #10801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Please add unit tests. |
|
please resolve conflicts and build issues |
Add lua code and formatter for rsyslog plugin
renukamanavalan
commented
Aug 4, 2022
renukamanavalan
commented
Aug 4, 2022
renukamanavalan
commented
Aug 4, 2022
| for(long unsigned int j = 3; j < params.size(); j++) { | ||
| auto delimPos = params[j].find(':'); | ||
| string resultValue = matchResults[j + 1].str(); | ||
| if(delimPos == string::npos) { // no lua code |
There was a problem hiding this comment.
Can we pre-parse this also as
struct {
string param_name;
string lua_code;
} param_list[]
You may simply check "if params[i].lua_code.empty()) { ... } else { use lua code}
* Add python tool to publish events for testing * Copy events publish tool to /usr/sbin * Add functionality to read from file * Add ability to read tag from file and take source as param * Add changes per peer review Co-authored-by: Ubuntu <zain@zb-dev-vm.022x1jpnpm4u1iy2d325acts3c.yx.internal.cloudapp.net>
|
This pull request introduces 2 alerts when merging edfde1e into 5d9a463 - view on LGTM.com new alerts:
|
stats & options update
|
This pull request introduces 2 alerts when merging ce3bcd8 into 46ebd06 - view on LGTM.com new alerts:
|
|
Depends on swsscommon PR #670 |
* Add volume test * Update volume test with comments
…navalan/sonic-buildimage into syslog_telemetry_shared
|
This pull request introduces 2 alerts when merging b6cf34b into 83704d9 - view on LGTM.com new alerts:
|
* Fix PR comments * Update with PR review comments * Fix LGTM warnings of publish tool * Fix bug in unit test * Change to ip to match yang model * Add changes per peer review
|
PR #11848 is created. Hence closing this. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Implementation of HLD PR #954
Depends on swsscommon PR #649 and corresponding submodule update.
How I did it
How to verify it
With this PR in, you flap BGP and use events_tool to see the published events.
With telemetry PR #111 in and corresponding submodule update done in buildimage, one could run gnmi_cli to capture BGP flap events.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)