Streaming structured events implementation #11848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
renukamanavalan
approved these changes
Aug 26, 2022
renukamanavalan
approved these changes
Aug 31, 2022
liushilongbuaa
added a commit
that referenced
this pull request
Sep 6, 2022
This reverts commit 6a54bc4.
1 task
yejianquan
added a commit
to yejianquan/sonic-buildimage
that referenced
this pull request
Sep 30, 2022
This reverts commit 6a54bc4.
stephenxs
reviewed
Oct 19, 2022
| { | ||
| swss::Logger::setMinPrio(swss::Logger::SWSS_DEBUG); | ||
| SWSS_LOG_INFO("The eventd service started"); | ||
| SWSS_LOG_ERROR("ERR:The eventd service started"); |
There was a problem hiding this comment.
Why do we print an error here?
There was a problem hiding this comment.
Leaked behind. We will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Implementation of HLD PR #954
How I did it
How to verify it
With this PR in, you flap BGP and use events_tool to see the published events.
With telemetry PR #111 in and corresponding submodule update done in buildimage, one could run gnmi_cli to capture BGP flap events.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)