Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[installer] FIX. ONIE installer error issue: #1152

Merged
merged 2 commits into from
Nov 15, 2017
Merged

[installer] FIX. ONIE installer error issue: #1152

merged 2 commits into from
Nov 15, 2017

Conversation

pollyhsu2git
Copy link
Contributor

- What I did
FIX: ONIE install failure

- How I did it
FIX the failure based on the discussion with the Accton ONIE contributor

- How to verify it

  1. Cloned the master pull on 2017-11-14 (commit id: 50b4868)
  2. Updated the revision
  3. Built the target image, sonic-broadcom.bin
  4. ONIE-installed (3) at the AS5712-54X device and booted it up OK

- Description for the changelog
Removed the intermediate /tmp manipulation around specific ONIE TAR ball name, which will result in the ONIE installation failure

- A picture of a cute animal (not mandatory but encouraged)

[installer] FIX. ONIE installer error issue:
9781cc4 
mv: can't rename '//tmp/onie-support.tar.bz2': No such file or directory
@lguohan
Copy link
Collaborator

lguohan commented Nov 15, 2017

why use intermediate /tmp folder to store onie tar ball will result ONIE installation failure?

What is the failure? I do not see the failure on the latest build on another platform. Can you explain more on the nature of the failure.

@pollyhsu2git
Copy link
Contributor Author

pollyhsu2git commented Nov 15, 2017 •
edited
Loading

@lguohan, based on the discussion with our ONIE contributor:

  1. ONIE has the revision, Change onie-support default filename on 3 Feb, which added more describe with machine type in filename https://github.com/opencomputeproject/onie/commit/7118374d7c3a87f2345a931142a316dfe8ab0043#diff-9b8c37d0abc0c3b6ef899533e6e5686e
  2. We use the latest ONIE installer here, which brings (1) to trigger the SONiC ONIE installation failure as the following:
    <#####
    Success: Support tarball created: /tmp/onie-support-accton_as7712_32x.tar.bz2
    mv: can't rename '//tmp/onie-support.tar.bz2': No such file or directory
    Failure: Unable to install image: tftp://192.168.3.199/sonic-broadcom-l_n324-10.bin
    #####>
  3. In other word, those who use the ONIE installer built older than 3 Feb will not have such issue.

@lguohan
Copy link
Collaborator

lguohan commented Nov 15, 2017

issue is clear now. if you look at the onie-support, it does many file operations. I would prefer to do those in the /tmp which is in ram (much faster), and then move it to disk. Can you still keep the logic.

lguohan
lguohan requested changes Nov 15, 2017
View reviewed changes
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onie-support should first store the file in /tmp and then move to flash. It saves the disk operations.

@pollyhsu2git
Copy link
Contributor Author

@lguohan, the requested revision to restore the /tmp operation was done~

@lguohan lguohan merged commit a99b5e9 into sonic-net:master Nov 15, 2017
@pollyhsu2git pollyhsu2git deleted the update-onie-installer branch November 20, 2017 04:16
abdosi added a commit that referenced this pull request Dec 21, 2020
@abdosi
[submodule update] sonic-utilities
c70b4cd 
fd3e0174971599fa7f9d73ff1a997583eb090fd5 (HEAD -> 201911, origin/201911) [Multi-asic] Enhanced Feature Table configuration for multi-asic platforms (#1152)
12f03b195609c07762d8c8efd80dc548ddd4fe78 Add FW dump with new SAI implementation (#1298)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@gechiang gechiang mentioned this pull request Dec 23, 2020
Merged
lguohan pushed a commit that referenced this pull request Dec 28, 2020
@gechiang
[sonic-utilities] Update sonic-utilities submodule to pick set of new…
721c68c 
… fixes (#6282)

submodule sonic-utilities in sonic-buildimage has not been updated for a while and there were many fixes needed to be picked up to ease debug/development in master branch.

Here are the list of changes that this update will bring in:

* de14939 2020-12-27 | Revert "[pytest][qos][config] Added pytests for "config qos reload" commands (#1266)" (HEAD -> master, origin/master, origin/HEAD) [Guohan Lu]
* ef3370d 2020-12-24 | [fast-reboot]: Stop sflow during fast-reboot (#1296) [jangidrk]
* ff1db4d 2020-12-24 | [fast-reboot]: Update fast-reboot-dump.py to handle invalid parsing of genetlink type hostif object id attribute (#1318) [jangidrk]
* d63d11d 2020-12-23 | Added show ip/v6 route summary support for multi-asic platform (#1320) [gechiang]
* 6202a81 2020-12-23 | [pytest][qos][config] Added pytests for "config qos reload" commands (#1266) [Mahesh Maddikayala]
* f555e9e 2020-12-23 | [CRM]Add support for snat, dnat and ipmc crm resources (#1258) [Prabhu Sreenivasan]
* f44e57e 2020-12-22 | Retain fgnhg state db table entry during warm reboot (#1315) [weixchen1215]
* 5e18bf5 2020-12-23 | Fix exception handling in python3 (#1324) [bingwang-ms]
* b6221f4 2020-12-22 | [config] Add unit tests for 'config interface breakout' command (#1223) [Praveen Chaudhary]
* 150642e 2020-12-22 | [dropcounters] Fix clear for non-root users (#1253) [Danny Allen]
* becf5b5 2020-12-21 | Kubernetes support commands update (#1133) [Renuka Manavalan]
* aad2c38 2020-12-19 | VXLAN config and show utilities (#870) [Rajesh Sankaran]
* 9419627 2020-12-17 | [Multi-asic] Enhanced Feature Table configuration for multi-asic platforms (#1152) [abdosi]
* 155f6d5 2020-12-17 | [config vlan]: Remove `-t` flag from docker exec command (#1317) [Lawrence Lee]
* 281b157 2020-12-17 | [fast-reboot-dump] Fix exception in struct.pack (#1309) [bingwang-ms]
* 269c317 2020-12-16 | Mgmt vrf/SNMP agent validations and bug fixes (#1289) [Suman Kumar]
* 394b202 2020-12-16 | [Dynamic buffer calc] Support dynamic buffer calculation (#973) [Stephen Sun]
* 6dd5d31 2020-12-14 | show tech with platform dump option (#1158) [Sujin Kang]
* 6255384 2020-12-13 | [kdump]: Parse sonic_platform kernel command line parameter to read the platform identifier string (#1291) [rajendra-dendukuri]
* 0603c0b 2020-12-13 | [pcieutil] Remove 'pcie-' prefix from arguments (#1297) [Joe LeVeque]
* 10ffc28 2020-12-13 | Added 'detailed' option for 'show interface counters' command (#1299) [Akhilesh Samineni]
* 980ea0d 2020-12-11 | Fix show ip route summary on pizzabox platforms (#1302) [gechiang]
* af1bb47 2020-12-10 | [acl_loader] Fix default DENY rule for V6 dataplane ACLs (#1281) [Danny Allen]
* 57a0b41 2020-12-09 | Add show and clear commands for headroom pool watermark  (#1144) [Neetha John]
* d414970 2020-12-08 | [unit test][CLI][pfcwd] Added pfcwd config tests for single and multi ASIC platform. (#1248) [Mahesh Maddikayala]
* 2b4a58c 2020-12-08 | [sflow] Fix traceback seen for show sflow interface (#1282) [Garrick He]
* e22980f 2020-12-09 | [config/console][consutil] Support enable/disable console switch (#1275) [Blueve]
* 2f263c4 2020-12-08 | [fast-reboot] Fix fast-reboot when NDP entries are present (#1295) [shlomibitton]
* 326e534 2020-12-07 | Fast-reboot: add a new flag to ignore ASIC config checksum verification failures (#1292) [Vaibhav Hemant Dixit]
* 042254e 2020-12-04 | Kdump improvements (#1284) [rajendra-dendukuri]
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@abdosi
[Multi-asic] Enhanced Feature Table configuration for multi-asic plat…
9419627 
…forms (sonic-net#1152)

Enhanced Feature Table configuration for multi-asic platforms
to programmed for all config db's.
@StormLiangMS StormLiangMS mentioned this pull request Mar 7, 2023
Merged
8 tasks
StormLiangMS added a commit that referenced this pull request Mar 7, 2023
@StormLiangMS
[submodule advance] Advance/sonic sairedis 202211 #14121
e57197b 
Why I did it
cf9a66b - Fix issue: bulk counter feature is disabled ([Broadcom]: Update Broadcom SDK/SAI package #1205) (4 hours ago) [Lior Avramov]
8b1583b - [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([Makefile]: variable ENABLE_SYNCD_RPC is always empty string #1201) (4 hours ago) [Andriy Yurkiv]
50d8e21 - [syncd]: Enable port bulk API ([platform] Accton AS7712-32X. Update for sensors and sfputil. #1197) (4 hours ago) [Nazarii Hnydyn]
a72438a - Use new value of STATE_DB FAST_REBOOT entry ([device/accton]: Update Accton-AS5712_54X #1196) (4 hours ago) [Aryeh Feigin]
d78ce86 - validation support for SAI_ATTR_VALUE_TYPE_JSON ([installer] FIX. ONIE installer error issue: #1152) (4 hours ago) [svshah-intel]
How I did it
How to verify it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pollyhsu2git @lguohan @stcheng