Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-utilities] Update sonic-utilities submodule to pick set of new fixes #6282

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Conversation

gechiang
Copy link
Collaborator

@gechiang gechiang commented Dec 23, 2020

- Why I did it
submodule sonic-utilities in sonic-buildimage has not been updated for a while and there were many fixes needed to be picked up to ease debug/development in master branch.
Here are the list of changes that this update will bring in:

  1. Added show ip/v6 route summary support for multi-asic platform ([Broadcom]: Update OpenNSL modules to be compatible with kernel 3.16.0-5 #1320)
  2. [pytest][qos][config] Added pytests for "config qos reload" commands (merge from community #1266)
  3. [CRM]Add support for snat, dnat and ipmc crm resources (Add 'make reset' target with warning prompt to reset Git repo and all submodules #1258)
  4. Retain fgnhg state db table entry during warm reboot ([device]: Remove unused qos.json file #1315)
  5. Fix exception handling in python3 ([database docker]: Prevent supervisor from restarting configdb-load.sh if it exits too quickly #1324)
  6. [config] Add unit tests for 'config interface breakout' command (Added psuutil support for S6100/Z9100 Dell Platforms #1223)
  7. [dropcounters] Fix clear for non-root users ([sonic-py-swsssdk]: Update submodule pointer #1253)
  8. Kubernetes support commands update ([doc]: change build badge url to new build server #1133)
  9. VXLAN config and show utilities ([Broadcom]: Update SAI version #870)
  10. [Multi-asic] Enhanced Feature Table configuration for multi-asic platforms ([installer] FIX. ONIE installer error issue: #1152)
  11. [config vlan]: Remove -t flag from docker exec command (docker sonic-slave's kernel source and headers is incorrect? #1317)
  12. [fast-reboot-dump] Fix exception in struct.pack ([Submodule update]: Update sairedis to the latest version #1309)
  13. Mgmt vrf/SNMP agent validations and bug fixes ([Submodule update]: Update swss-common #1289)
  14. [Dynamic buffer calc] Support dynamic buffer calculation ([Broadcom]: Update libsai version to 3.0.3.2-2 #973)
  15. show tech with platform dump option ([swss] update swss submodule to include all latest changes #1158)
  16. [kdump]: Parse sonic_platform kernel command line parameter to read the platform identifier string (Revert "[DHCP relay]: Add patch to always undef VLAN_TCI_PRESENT so as not to treat VLAN-tagged packets differently (#1254)" #1291)
  17. [pcieutil] Remove 'pcie-' prefix from arguments (Revert "psusutil sysfs attribute changes for hwmon" #1297)
  18. Added 'detailed' option for 'show interface counters' command (Add support for Accton AS7712-32X platform #1299)
  19. Fix show ip route summary on pizzabox platforms ([minigraph.py] Crashes upon <DhcpRelays></DhcpRelays> in VlanInterface section #1302)

- Description for the changelog
[sonic-utilities] Update sonic-utilities submodule to pick set of new fixes

@jleveque
Copy link
Contributor

Looks like PFCWD unit tests are failing with "Root privileges are required for this operation". Not sure why this wasn't seen before. Looks like @smaheshm modified these recently. Maybe he can help troubleshoot?

@smaheshm
Copy link
Contributor

Looks like PFCWD unit tests are failing with "Root privileges are required for this operation". Not sure why this wasn't seen before. Looks like @smaheshm modified these recently. Maybe he can help troubleshoot?

Let me take a look. Looks like there's a difference between how sonic-buildimage repo runs tests vs sonic-utilities repo.

lguohan
lguohan previously approved these changes Dec 24, 2020
@lguohan
Copy link
Collaborator

lguohan commented Dec 24, 2020

need to fix the unit test failure.

gechiang and others added 2 commits December 27, 2020 06:25
unit tests are running for sonic utilitie repo

Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan
lguohan previously approved these changes Dec 27, 2020
@lguohan
Copy link
Collaborator

lguohan commented Dec 27, 2020

there are about 23 commits picked up in sonic-utilities repo, the description only listed 19 commits.

@lguohan
Copy link
Collaborator

lguohan commented Dec 27, 2020

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/8207/

issue caused by this pr. 6202a81

reverted.

07:11:55 Sunday 27 December 2020 15:11:54 +0000 (0:00:00.059) 0:00:21.107 *******
07:12:51 fatal: [vlab-01]: FAILED! => {"changed": true, "cmd": "config load_minigraph -y", "delta": "0:00:47.452274", "end": "2020-12-27 15:12:41.680371", "msg": "non-zero return code", "rc": 1, "start": "2020-12-27 15:11:54.228097", "stderr": "Warning: Stopping telemetry.service, but it can still be activated by:\n telemetry.timer\nTraceback (most recent call last):\n File "/usr/local/bin/config", line 8, in \n sys.exit(config())\n File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 764, in call\n return self.main(*args, **kwargs)\n File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 717, in main\n rv = self.invoke(ctx)\n File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1137, in invoke\n return _process_result(sub_ctx.command.invoke(sub_ctx))\n File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1137, in invoke\n return _process_result(sub_ctx.command.invoke(sub_ctx))\n File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 956, in invoke\n return ctx.invoke(self.callback, **ctx.params)\n File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 555, in invoke\n return callback(*args, **kwargs)\n File "/usr/local/lib/python3.7/dist-packages/click/decorators.py", line 17, in new_func\n return f(get_current_context(), *args, **kwargs)\n File "/usr/local/lib/python3.7/dist-packages/config/main.py", line 1673, in reload\n sonic_version_file = device_info.get_sonic_version_file()\nAttributeError: module 'sonic_py_common.device_info' has no attribute 'get_sonic_version_file'", "stderr_lines": ["Warning: Stopping telemetry.service, but it can still be activated by:", " telemetry.timer", "Traceback (most recent call last):", " File "/usr/local/bin/config", line 8, in ", " sys.exit(config())", " File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 764, in call", " return self.main(*args, **kwargs)", " File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 717, in main", " rv = self.invoke(ctx)", " File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1137, in invoke", " return _process_result(sub_ctx.command.invoke(sub_ctx))", " File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1137, in invoke", " return _process_result(sub_ctx.command.invoke(sub_ctx))", " File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 956, in invoke", " return ctx.invoke(self.callback, **ctx.params)", " File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 555, in invoke", " return callback(*args, **kwargs)", " File "/usr/local/lib/python3.7/dist-packages/click/decorators.py", line 17, in new_func", " return f(get_current_context(), *args, **kwargs)", " File "/usr/local/lib/python3.7/dist-packages/config/main.py", line 1673, in reload", " sonic_version_file = device_info.get_sonic_version_file()", "AttributeError: module 'sonic_py_common.device_info' has no attribute 'get_sonic_version_file'"], "stdout": "Executing stop of service telemetry...\nExecuting stop of service swss...\nExecuting stop of service lldp...\nExecuting stop of service pmon...\nExecuting stop of service bgp...\nRunning command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json --write-to-db\nRunning command: pfcwd start_default\nRunning command: /usr/local/bin/sonic-cfggen -d -y /etc/sonic/sonic_version.yml -t /usr/share/sonic/templates/sonic-environment.j2,/etc/sonic/sonic-environment\nRunning command: config qos reload --no-dynamic-buffer", "stdout_lines": ["Executing stop of service telemetry...", "Executing stop of service swss...", "Executing stop of service lldp...", "Executing stop of service pmon...", "Executing stop of service bgp...", "Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json --write-to-db", "Running command: pfcwd start_default", "Running command: /usr/local/bin/sonic-cfggen -d -y /etc/sonic/sonic_version.yml -t /usr/share/sonic/templates/sonic-environment.j2,/etc/sonic/sonic-environment", "Running command: config qos reload --no-dynamic-buffer"]}

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan merged commit 721c68c into sonic-net:master Dec 28, 2020
@smaheshm
Copy link
Contributor

Looks like PFCWD unit tests are failing with "Root privileges are required for this operation". Not sure why this wasn't seen before. Looks like @smaheshm modified these recently. Maybe he can help troubleshoot?

Let me take a look. Looks like there's a difference between how sonic-buildimage repo runs tests vs sonic-utilities repo.

sonic-net/sonic-utilities#1340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants