Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service to config hostname based on configdb #1174

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Add service to config hostname based on configdb #1174

merged 1 commit into from
Nov 22, 2017

Conversation

taoyl-ms
Copy link
Contributor

- What I did
Read hostname from DEVICE_METADATA, and set hostname, /etc/hostname. and /etc/hosts according to it.

@taoyl-ms
Copy link
Contributor Author

This will resolve #869.

lguohan
lguohan reviewed Nov 22, 2017
View reviewed changes
files/image_config/hostname/hostname-config.service
[Unit]
Description=Update hostname based on configdb
Requires=database.service
After=database.service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we get the hostname in the first place in case of no dhcp. Some one will put the minigraph in the device, and then call config load-minigraph. Will that restart this hostname-config service to reconfigure the hostname?

Copy link
Contributor Author

@taoyl-ms taoyl-ms Nov 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In current version of config load_minigraph it calls the commands in this bash script directly instead of restart this service. I can later modify sonic_utilities to simply restart this service instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonic-net/sonic-utilities#154

@taoyl-ms taoyl-ms merged commit 617b3e4 into master Nov 22, 2017
@stcheng stcheng deleted the taoyl/hostname branch November 23, 2017 00:54
@daall daall mentioned this pull request Nov 4, 2020
Merged
3 tasks
@madhanmellanox madhanmellanox mentioned this pull request Nov 5, 2020
Closed
3 tasks
lguohan pushed a commit that referenced this pull request Nov 6, 2020
@daall
[utilities] Update sonic-utilities submodule (#5814)
cea364a 
Add a switch to route_check to control whether write log to syslog (#1215)
[consutil] Store console port state in STATE_DB (#1208)
[sfputil] Display 'N/A' for non-SFP ports (#1078)
Show FG_NHG CLI Commands Added (#1056)
[show] remove 'device2interface_dict' in show interface neighbor expected (#1188)
Add license file, remove third-party licenses file (#1192)
[fwutil]: Set min log priority to INFO. (#1191)
[CLI][show][platform] Added ASIC count in the output. (#1185)
fdbshow and nbrshow use SonicV2Connector with decode_responses=True, and remove all the decode() (#1187)
Remove stdeb.cfg; no longer used now that we build as wheel (#1182) 
[counterpoll] Disable Counter Poll When Entering Fast Reboot (#1174) 
Fixes the issue with show interface counters and for pfc and queue counters. (#1180)
[config/show] Add CLI support for proxy arp (#1168)
[consutil] Add brief option to show line command (#1176)
Modify fast-reboot script to use BGP service script to stop bgp service (#1177)
[config/console] Support update console configuration related commands (#1166)
[consutil] Fix issue where the show line command crash if no ttyUSB exists (#1173)
[watermarkstat] Add unit tests for watermarkstat show commands (#1157)
Fix exception for ipaddress in python2 (#1164) 
[celestica] consutil to support customize tty device name (#1155)

Signed-off-by: Danny Allen <daall@microsoft.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@daall @santhosh-kt
[utilities] Update sonic-utilities submodule (sonic-net#5814)
413fe08 
Add a switch to route_check to control whether write log to syslog (sonic-net#1215)
[consutil] Store console port state in STATE_DB (sonic-net#1208)
[sfputil] Display 'N/A' for non-SFP ports (sonic-net#1078)
Show FG_NHG CLI Commands Added (sonic-net#1056)
[show] remove 'device2interface_dict' in show interface neighbor expected (sonic-net#1188)
Add license file, remove third-party licenses file (sonic-net#1192)
[fwutil]: Set min log priority to INFO. (sonic-net#1191)
[CLI][show][platform] Added ASIC count in the output. (sonic-net#1185)
fdbshow and nbrshow use SonicV2Connector with decode_responses=True, and remove all the decode() (sonic-net#1187)
Remove stdeb.cfg; no longer used now that we build as wheel (sonic-net#1182) 
[counterpoll] Disable Counter Poll When Entering Fast Reboot (sonic-net#1174) 
Fixes the issue with show interface counters and for pfc and queue counters. (sonic-net#1180)
[config/show] Add CLI support for proxy arp (sonic-net#1168)
[consutil] Add brief option to show line command (sonic-net#1176)
Modify fast-reboot script to use BGP service script to stop bgp service (sonic-net#1177)
[config/console] Support update console configuration related commands (sonic-net#1166)
[consutil] Fix issue where the show line command crash if no ttyUSB exists (sonic-net#1173)
[watermarkstat] Add unit tests for watermarkstat show commands (sonic-net#1157)
Fix exception for ipaddress in python2 (sonic-net#1164) 
[celestica] consutil to support customize tty device name (sonic-net#1155)

Signed-off-by: Danny Allen <daall@microsoft.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@tahmed-dev
[counterpoll] Disable Counter Poll When Entering Fast Reboot (sonic-n…
ca92e36 
…et#1174)

Counter polling is enabled via enable_counters script when booting
into new image and these configuration is written to config_db.
However, subsequent fast-reboot into the same image will have counter
polling enabled by default. This affect fast-reboot time. As a workaround,
we will disable counter poll when entering fast-reboot.

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this pull request Apr 14, 2022
@abdosi @qbdwlr
Moved SAI Header to git tag v1.8.1 (sonic-net#816)
0d3749d 
What I did:

Moved the SAI header to v1.8.1.
   7cd3a7ed84db3fc9cec13496a5339b6fe1888bb7 (HEAD, tag: v1.8.1, origin/v1.8) Update SAI version to V1.8.1 (sonic-net#1218)
   5913e4cdd0c9c7ae859baa2e18086327b39a94da Fix error when compiling Broadcom SAI with v1.8.0 (sonic-net#1216)
   5a98bc3c7e86c01f3cf702054f9af7c7c5ca6daf (HEAD, tag: v1.8.0, origin/master, origin/HEAD, master) Update version to 1.8.0 (sonic-net#1207)
   b3244ceceb45184ffe37da55bb9a98ef126050ce saineighbor.h: Updated SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_INDEX and deprecated SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_IMPOSE_INDEX (sonic-net#1202)
   8731ca6e09c7ba99b0b009e5821d80598e216756 Add source/dest/double NAPT entry available attributes (sonic-net#1194)
   f053d899feb9517f2db43ee462589a30572b5ed1 Add switch attributes for hash offset configuration. (sonic-net#1195)
   13e5cd6940f9a0da1878d00f08e5941e09f16e7f PRBS RX State Data Type (sonic-net#1179)
   9755845a06525a3c17f03e7b936a70783e8ef068 Packet header based VRF classification (sonic-net#1185)
   2369ecb59fff1a5cae948d41eea06bf8b71330b2 SAI versioning (sonic-net#1183)
   744279839c176e68b19734657975e3f5ec6f1a32 Replaced SAI_SWITCH_ATTR_MACSEC_OBJECT_ID with SAI_SWITCH_ATTR_MACSEC_OBJECT_LIST (sonic-net#1199)
   584c724864fe565357e82d097ddcc7363bddefac [CI] Set up CI&PR with Azure Pipelines (sonic-net#1200)
   08192237963174cc60edae9b4812a39c43b291fd Add attribute to query available packet DMA pool size (sonic-net#1198)
   f092ef1e3ce695fc3f9552721025695312b961a2 Add IPv6 flow label hash attribute. (sonic-net#1192)
   cbc9562bb7a8f2c3a79702b99be55f3b3afa6957 Override VRF (sonic-net#1186)
   1eb35afdb2146baf40e6c2b8f2f8bfe99075eaee Add SAI_SWITCH_ATTR_SWITCH_HARDWARE_INFO format for GB MDIO sysfs access   (sonic-net#1171)
   b2d4c9a57c7f00b2632c35ca5eb3dd6480f7916a Switch scoped tunnel attributes (sonic-net#1173)
   96adc95bf8316e1905143d9ecd21f32a43e80d7f Enhancements for MPLS support (sonic-net#1181)
   3dcf1f2028da4060b345ad78e8a0c87d225bf5d0 Support for ACL extensions in metadata (sonic-net#1178)
   24076be95b871e8f82ecaeb908cad951dc68896c [meta] Add support for allow empty list tag (sonic-net#1190)
   a2b3344cdde0bf5a4f8e98e1c676a658c0c615b0 spell check fixes (sonic-net#1189)
   bf4271bab6e8884bd96050bcba44e3134adaaec3 Do not call sai_metadata_sai get APIs before checking if they are allocated (sonic-net#1182)
   5d5784dc3dbfc713c92ae7d2c472680b837bb002 [macsec]: Separate XPN configuration attribute from read-only attribute (sonic-net#1169)
   6d5a9bf5ad17cb82621cabbe2449524320930606 [macsec]: add SAI_MACSEC_ATTR_SUPPORTED_CIPHER_SUITE_LIST (sonic-net#1172)
   e72c8f3a0cc543cb228554be82c97a63db917740 [meta] Print each tool version in Makefile (sonic-net#1177)
   8f19677da88c7494d563ef7c5acb0529ecbd0b6e [meta] Add check for START, END and RANBE_BASE enums (sonic-net#1175)
   24ad7906f145930b2e25682b6248909289d39e72 [meta] Create sai_switch_pointers_t struct (sonic-net#1174)
   4f5f84df3fcd0e146707df41d3e2837c48f7c760 Tunnel loopback packet action as resource (sonic-net#1163)
   8a0e82c57aa0e22e696158735516904e7dc14052 [meta] Add create only oid attribute check on switch object (sonic-net#1170)
   14cf50772e478551920963ecf11f4fd019a0c106 Remove obsolete stub folder (sonic-net#1168)
   f14f406340e4f5f1b1d674f6fdd5fd861a54c877 [meta] Use safer calloc for integer overflow check (sonic-net#1166)

Also this PR include changes of this sonic-net#815

SAI commit b2d4c9a57c7f00b2632c35ca5eb3dd6480f7916a Switch scoped tunnel attributes (sonic-net#1173) needed change in sai_redis_switch.cpp and sai_vs_switch.cpp for compilation.

How I verify:

Verify Build is fine of libsairedis*.deb, syncd*.deb, swss*.deb

Co-authored-by: Ann Pokora <apokora@juniper.net>
Yakiv-Huryk added a commit to Yakiv-Huryk/sonic-buildimage that referenced this pull request Jan 3, 2023
@Yakiv-Huryk
[202205][submodule] advance sonic-sairedis pointer
ae8c3ea 
Update sonic-sairedis submodule pointer to include the following:

0994449 [asan] suppress the static variable leaks (sonic-net#1085) (sonic-net#1159)
6fc86a9 Switch to using stock gcovr 5.2 (sonic-net#1174) (sonic-net#1190)
e7ded51 Create fabric ports for switch_type fabric (sonic-net#1189)
f498261 * Add Voqs to Virtual Switch (sonic-net#1162)

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
liat-grozovik pushed a commit that referenced this pull request Jan 3, 2023
@Yakiv-Huryk
[202205][submodule] advance sonic-sairedis pointer (#13237)
49b91ef 
Update sonic-sairedis submodule pointer to include the following:

0994449 [asan] suppress the static variable leaks (#1085) (#1159)
6fc86a9 Switch to using stock gcovr 5.2 (#1174) (#1190)
e7ded51 Create fabric ports for switch_type fabric (#1189)
f498261 * Add Voqs to Virtual Switch (#1162)

Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
liat-grozovik pushed a commit that referenced this pull request Jan 5, 2023
@nazariig
[submodule]: Advance sonic-sairedis submodule. (#13270)
ba5c26a 
Update sonic-sairedis submodule pointer to include the following:

402eb14 [ppi]: Enable bulk API. (#1171)
86bb828 Switch to using stock gcovr 5.2 (#1174)
1c9ca78 Manage LANES mapping on VOQ system (#1127)
5887d31 Fix for [EVPN] When MAC moves from remote end point to local, ASIC DB fields are not updated properly for the mac #11503Update NotificationProcessor.cpp (#1118)
559bd5b [ci][asan] add DVS tests run with ASAN (#1139)
4ab46b5 Initialize attr variables in Legacy.switch_get and LegacyFdbEntry.fdb_entry_get (#1169)
4e24c77 The meta_sai_validate_fdb_entry() validates the input FDB entry for the (#1154)

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
This was referenced Feb 11, 2023
Merged
Merged
StormLiangMS added a commit that referenced this pull request Feb 15, 2023
@StormLiangMS
[submodules] advance sonic-sairedis for 202211 #13799
fd0e614 
Why I did it
sonic-sairedis

53488e9 - [sai_failure_dump]Invoking dump during SAI failure (Update Mellanox buffer profiles config #1198) (15 hours ago) [Sudharsan Dhamal Gopalarathnam]
85921af - [Mellanox] Enable DSCP remapping by using SAI attribute ([Nephos] Updating download link for SAI and SDK #1188) (15 hours ago) [Stephen Sun]
82f2cd7 - Switch to using stock gcovr 5.2 (Add service to config hostname based on configdb #1174) (15 hours ago) [Saikrishna Arcot]
3a6c60d - [ppi]: Enable bulk API. ([Aboot] Declare flash_size for all platform #1171) (15 hours ago) [Nazarii Hnydyn]
f1303cb - Use github code scanning instead of LGTM (#1160) (15 hours ago) [Liu Shilong]
b1972d9 - Fix for [EVPN] When MAC moves from remote end point to local, ASIC DB fields are not updated properly for the mac #11503Update NotificationProcessor.cpp ([libteam] Add fallback support for single-member-port LAG #1118) (15 hours ago) [anilkpan]
How I did it
How to verify it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SAI-shared-user SAI-shared-user SAI-shared-user approved these changes

@lguohan lguohan lguohan approved these changes

@stcheng stcheng Awaiting requested review from stcheng

Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taoyl-ms @lguohan @SAI-shared-user @stcheng