[docker-orchagent]: ports.json.j2 template fixed

[Mrak-IW]

• ports.json file is generating correctly now, without excess comma in case if
  the last port in list has no port speed setting in the redis-db

Signed-off-by: Denis Maslov Denis.Maslov@cavium.com

- What I did
ports.json.j2 fixed to generate valid ports.json with speed configuration

- How I did it
The principle of comma placement changed

- How to verify it
Set port speed for some ports in config_db or minigraph.

1. Perform:

   docker exec -ti swss bash
   cat /etc/swss/config.d/ports.json
   [
       {
           "PORT_TABLE:Ethernet2": {
               "speed": "40000"
           },
           "OP": "SET"
       }
       ,{
           "PORT_TABLE:Ethernet5": {
               "speed": "100000"
           },
           "OP": "SET"
       }
   ]

   The last entry must be without comma after it.

- Description for the changelog
ports.json file is generating correctly now, without excess comma in case if
the last port in list has no port speed setting in the redis-db

- A picture of a cute animal (not mandatory but encouraged)
^._.^

[lguohan]

do we need another if here, we can probably do { % set ns = {'firstPrinted': True} %}

[Mrak-IW]

Unfortunately, we can't change variable in a loop in a straight way. You couldn't be able to notice that changes inside the loop itself.
You also can not simply call the function like {% ns.update({'firstPrinted': True}) %}. It leads to error and ports.json is empty as a result.
The main idea was that this function must be called to calculate that if condition. Unfortunately, I have not found another way to do it.

[stcheng]

I wonder an alternative approach is to remove the port from the PORT in the minigraph.py file.
As long as we don't want the port exists here, we don't want the port to be populated out from the minigraph.py file.

I'll fix it in the master branch.