[201911] Add dhcp6relay as dhcprelay submodule #12052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyyeh
changed the title
saiarcot895
reviewed
Sep 17, 2022
saiarcot895
reviewed
Sep 17, 2022
kellyyeh
force-pushed
the
201911-dhcp6relay
branch
2 times, most recently
from
d9205f3
to
3f2daa4
Compare
saiarcot895
reviewed
Sep 19, 2022
saiarcot895
reviewed
Sep 19, 2022
| {% if VLAN and vlan_name in VLAN and 'dhcp_servers' in VLAN[vlan_name] and VLAN[vlan_name]['dhcp_servers']|length > 0 %} | ||
| {% set _dummy = monitor_instance.update({'flag': True}) %} | ||
| {%- endif %} | ||
| {% if DHCP_RELAY and vlan_name in DHCP_RELAY and DHCP_RELAY[vlan_name]['dhcpv6_servers']|length > 0 %} |
There was a problem hiding this comment.
this part may be removed also if only v4 messages are monitored(line9-11, line23, line33)
kellyyeh
force-pushed
the
201911-dhcp6relay
branch
from
f6af0cc
to
9044bda
Compare
kellyyeh
force-pushed
the
201911-dhcp6relay
branch
from
9044bda
to
a6c00c9
Compare
saiarcot895
approved these changes
Sep 27, 2022
kellyyeh
requested review from
yxieca
and removed request for
pettershao-ragilenetworks
|
@kellyyeh please fill in the PR template. especially the how to verify part. Thanks. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kellyyeh
force-pushed
the
201911-dhcp6relay
branch
from
4041d39
to
fab2cb0
Compare
kellyyeh
force-pushed
the
201911-dhcp6relay
branch
from
fab2cb0
to
695d19c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add dhcp6relay in 201911 branch, and make it a submodule
How I did it
Cherry-picked below PR's and made compatible for stretch/201911
Add DHCPv6 minigraph parsing support #8870
Parse DHCP Table #8988
Replace isc-dhcp with DHCPv6 Relay in dhcp_relay docker #8884
Change dhcp6relay to be a submodule, and rename it to dhcprelay #10711
How to verify it
Ran full dhcpv6 test suite with sonic-mgmt master branch and passed
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)