-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine SED_DPKG: install dependencies from apt source #126
Conversation
This may cause same problem as before - packages built from sources will be overridden by packages from apt Also apt get install -f does not fail if package failed to install, if always returns 0 |
|
i vote that it is better to manually install all the dependencies instead of using apt-get -f to install all the 'unknown' dependencies recursively. |
Let's keep this pull request and discussion open. I submitted another PR #128 for a quick build fix to unblock all others. |
@marian-pritsak , can you explain this "packages built from sources will be overridden by packages from apt" a little bit more? usually, our customized packages have higher version number, so it would not be possible to be override by default package. |
As an example, consider a case when only redis-server is installed into docker-database, but we forgot about redis-tools:
The logs above show us that redis-server depends on redis-tools, and this makes first command fail, but then Here we end up in a situation, where build finishes successfully, but required packages are not installed into docker. This mistake will be noticed only when dockers are deployed to switch. Having said that, I would suggest to catch such mistakes during build with clear error message from dpkg tool instead of debugging missing binaries on switch whenever we can. Similar issue was fixed in this PR |
@marian-pritsak Please check my latest commit which remove your possibility of this kind of mistakes, and keep all the previous features. Do you feel better? |
I find the updated change hacky. It is better to install everything that we know and we think are needed instead of relying on -f to auto-solve the dependency issues. |
commit 0a0e69c seems hacky, i tend to agree with marian |
…4193) * [Mellanox]Integrate hw-mgmt 7.0000.3012 * [sonic-linux-kernel]Advance the submodule head Advance the sonic-linux-kernel [sFlow]: Patch to fix skb_over_panic in psample driver (#120) Added support in the kernel for fullcone 3-tuple unique nat. (#100) Adding support to compile ARM architecture (#102) [ixgbe] Support bcm54616s external phy in ixgbe (#122) Fix i2c ISMT DMA buffer alignment issue (#123) [mellanox]: Add SN4700 patches. (#126)
…4193) * [Mellanox]Integrate hw-mgmt 7.0000.3012 * [sonic-linux-kernel]Advance the submodule head Advance the sonic-linux-kernel [sFlow]: Patch to fix skb_over_panic in psample driver (#120) Added support in the kernel for fullcone 3-tuple unique nat. (#100) Adding support to compile ARM architecture (#102) [ixgbe] Support bcm54616s external phy in ixgbe (#122) Fix i2c ISMT DMA buffer alignment issue (#123) [mellanox]: Add SN4700 patches. (#126)
Update sonic-snmpagent submodule with PRs: 89b7b2c [Multi-asic]: Namespace support for LLDP and Sensor tables (#131) fcb8955 Simplify test code (#132) a677876 [Multi-asic]: Support multi-asic platform (#126) update sonic-py-swsssdk submodule with PRs: 132f8d5 [MultiDB]: use python class composition to avoid confusion in base class (#74) Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
following PR's : Implement cbgpPeer2State in CiscoBgp4MIB (#119) Fix index nodes in LLDP tables whose access right is not-accessible. (#112) Fix quagga/FRR parser on IPv6 BGP sessions (#122) [lint] Fix some syntax errors or warnings (#127) Update README.md: Add lgtm badges (#128) [Multi-asic]: Support multi-asic platform (#126) Simplify test code (#132) [Multi-asic]: Namespace support for LLDP and Sensor tables (#131) Fix undefined variable and warning message (#134) Fix SNMP AgentX socket connection timeout when using Namespace.get_all() (#140) [Namespace] Fix interfaces counters in InterfacesMIB RFC 2863 (#141) Fix LGTM reported alert of PR#141 (#142)
* [brcmsai]: Updated BRCM SAI Debina package to 3.7.5.1-2 (sonic-net#4916) Fix for Copp Rules not having Policer Rate-Limit applied. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * [nephos]: upgrade Nephos SAI version to c749df (sonic-net#4814) Verified with Nephos nps8365 based platform Accton AS7116-54x. * "[config]: Multi ASIC loopback changes (sonic-net#4895) Resubmitting the changes for (sonic-net#4825) with fixes for sonic-bgpcdgd test failures Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> * [mellanox]: Support warm reboot on MSN4700 (sonic-net#4910) * [Submodule Update] Sonic-platform-common [sfp_base] Update return value documentation of channel-specific methods (sonic-net#98) [SfpBase] Fix key name typo in docstring (sonic-net#99) [sfp] Tweak key names of some transceiver info fields (sonic-net#97) [sfputil] Make SfpUtilHelper.get_physical_to_logical noexcept as in SfpUtilBase (sonic-net#96) * [Submodule update] sonic-platform-daemons [xcvrd] Update key names in 'get_media_settings_value()' (sonic-net#63) [xcvrd] Tweak some transceiver info key names (sonic-net#62) * [Submodule update] sonic-utilities [sfpshow][mock_state_db] Tweak key names of some transceiver info fields (sonic-net#958) [config] Fix syntax error (sonic-net#966) [config] Fix indentation level in _get_disabled_services_list() (sonic-net#965) * [Submodule Update] sonic-swss [aclorch] Use IPv6 Next Header internally for protocol number on MLNX platform (sonic-net#1343) * [Submodule Update] Add support for attribute capability query in lua script (sonic-net#362) * Cherry-pick was not clean. Fixing it. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * [telemetry] Call sonic-cfggen Once (sonic-net#4901) sonic-cfggen call is slow and this is taking place in the SONiC boot up process. The change uses templates to assemble all required vars into single template file. With this change, telemetry now calls once into sonic-cfggen. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com> * [mgmt docker] move pycryptodome installation to the end of the docker building (sonic-net#4917) * [mgmt docker] move pycryptodome installation to the end of the docker building Signed-off-by: Ying Xie <ying.xie@microsoft.com> * pin down the version to current: 3.9.8 * comment * Add support for bcmsh and bcmcmd utlitites in multi ASIC devices (sonic-net#4926) Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> This PR has changes to support accessing the bcmsh and bcmcmd utilities on multi ASIC devices Changes done - move the link of /var/run/sswsyncd from docker-syncd-brcm.mk to docker_image_ctl.j2 - update the bcmsh and bcmcmd scripts to take -n [ASIC_ID] as an argument on multi ASIC platforms * [caclmgrd] Improve code reuse (sonic-net#4931) Improve code reuse in `generate_block_ip2me_traffic_iptables_commands()` function. * [Submodule Update] sonic-utilities Intf table migration for APP_DB entries during warmboot (sonic-net#980) [Multi NPU] Time Improvements to the config reload/load_minigraph commands (sonic-net#917) * [Submodule Update] sonic-py-swssdk [MultiDB]: use python class composition to avoid confusion in base class (sonic-net#74) * [Submodule update] sonic-snmpagent. Movent to 201911 Branch with with following PR's : Implement cbgpPeer2State in CiscoBgp4MIB (sonic-net#119) Fix index nodes in LLDP tables whose access right is not-accessible. (sonic-net#112) Fix quagga/FRR parser on IPv6 BGP sessions (sonic-net#122) [lint] Fix some syntax errors or warnings (sonic-net#127) Update README.md: Add lgtm badges (sonic-net#128) [Multi-asic]: Support multi-asic platform (sonic-net#126) Simplify test code (sonic-net#132) [Multi-asic]: Namespace support for LLDP and Sensor tables (sonic-net#131) Fix undefined variable and warning message (sonic-net#134) Fix SNMP AgentX socket connection timeout when using Namespace.get_all() (sonic-net#140) [Namespace] Fix interfaces counters in InterfacesMIB RFC 2863 (sonic-net#141) Fix LGTM reported alert of PR#141 (sonic-net#142) * [bgpcfgd] - Fix a key error during delete (sonic-net#4946) * [Submodule Update] sonic-utilities Fix the None Type Exception when Interface Table does not exist (cold boot) as part of db migration (sonic-net#986) * Fix the below frr start.sh jija2 exception in 201911 image syslog: (sonic-net#4958) File "/usr/local/bin/sonic-cfggen", line 380, in <module> main() File "/usr/local/bin/sonic-cfggen", line 354, in main print(template.render(data)) File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 1090, in render self.environment.handle_exception() File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 832, in handle_exception reraise(*rewrite_traceback_stack(source=source)) File "<template>", line 1, in top-level template code File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 471, in getattr return getattr(obj, attribute) jinja2.exceptions.UndefinedError: 'WARM_RESTART' is undefined Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * [Submodule update] sonic-snmpagent [201911] Fix interface counters in RFC1213 (sonic-net#144) * [docker-ptf] Add support for spytest to ptf container (sonic-net#4410) - Install apt and pip dependencies - Define traffic generator service Signed-off-by: Danny Allen <daall@microsoft.com> * [arista] update Arista drivers submodules (sonic-net#4967) Merge most of the changes that recently made it to master. This will be the last such merge operation and future commits will only cherry-pick fixes and targeted features. Major fixes and features, - reboot cause enhancement with more hardware reboot cause reporting - fix reboot cause parsing issue with 201811 release - fix get_change_event logic - fix error message on missing sysfs entry by our plugins - final piece of the platform refactors for fan and sensor reporting through the platform API * [201911][devices] Update SFP keys to align with new standard (sonic-net#4976) Align SFP key names with new standard defined in sonic-net/sonic-platform-common#97 - hardwarerev -> hardware_rev - serialnum -> serial - manufacturename -> manufacturer - modelname -> model - Connector -> connector * [201911][sonic-telemetry] Update submodule (sonic-net#4987) Point submodule to new 201911 branch of sonic-telemetry and update pointer to the current HEAD of the 201911 branch * src/sonic-telemetry aaa9188...01b5365 (1): > [testdata] Update SFP keys to align with new standard (sonic-net#39) * [201911][sudoers] Add `sonic_installer list` to read-only commands (sonic-net#4997) `sonic_installer list` is a read-only command. Specify it as such in the sudoers file. This will also ensure the new `show boot` command, which calls `sudo sonic_installer list` under the hood doesn't fail due to permissions. * [caclmgrd] Filter DHCP packets based on dest port only (sonic-net#4995) Co-authored-by: abdosi <58047199+abdosi@users.noreply.github.com> Co-authored-by: gracelicd <39251567+gracelicd@users.noreply.github.com> Co-authored-by: arlakshm <55814491+arlakshm@users.noreply.github.com> Co-authored-by: Stephen Sun <5379172+stephenxs@users.noreply.github.com> Co-authored-by: Abhishek Dosi <abdosi@microsoft.com> Co-authored-by: Tamer Ahmed <tamer.ahmed@microsoft.com> Co-authored-by: Ying Xie <yxieca@users.noreply.github.com> Co-authored-by: Joe LeVeque <jleveque@users.noreply.github.com> Co-authored-by: Prince Sunny <prince.sunny@microsoft.com> Co-authored-by: Danny Allen <daall@microsoft.com> Co-authored-by: Samuel Angebault <staphylo@arista.com>
a659219 [SONIC_SFP] adding abstract methods for reading and writing the eeprom address space within platform api (sonic-net#126) 848f4a6 Add third-party licenses (sonic-net#138) c2ecd9a Add license file (sonic-net#137) 403747a [sonic-platform-common] Add new platform API for SONiC Physical MIB Extension feature (sonic-net#134) 19b8545 [sonic_y_cable] fix the unpacking (sonic-net#135) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
a659219 [SONIC_SFP] adding abstract methods for reading and writing the eeprom address space within platform api (#126) 848f4a6 Add third-party licenses (#138) c2ecd9a Add license file (#137) 403747a [sonic-platform-common] Add new platform API for SONiC Physical MIB Extension feature (#134) 19b8545 [sonic_y_cable] fix the unpacking (#135) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
1) Added jenkinsfile, build and test scripts for sanity checking of sonic-mgmt-common PRs. Test stage runs cvl and translib go test cases. Also added periodic sanity for latest sonic-mgmt-common code. 2) Modified sonic-mgmt-framework PR & sceduled sanities to download and build latest sonic-mgmt-common fist. Cleaned up build script to include only sonic-mgmt-framework related stuffs. Translib, cvl specific steps are moved to sonic-mgmt-common's build script. 3) Introduced a test stage for sonic-mgmt-framework sanity. It runs REST server go test cases. 4) Modified sonic-telemetry build script to clone and build sonic-mgmt-common first. Removed dependency on sonic-mgmt-framework. Signed-off-by: Sachin Holla <sachin.holla@broadcom.com>
a659219 [SONIC_SFP] adding abstract methods for reading and writing the eeprom address space within platform api (sonic-net#126) 848f4a6 Add third-party licenses (sonic-net#138) c2ecd9a Add license file (sonic-net#137) 403747a [sonic-platform-common] Add new platform API for SONiC Physical MIB Extension feature (sonic-net#134) 19b8545 [sonic_y_cable] fix the unpacking (sonic-net#135) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
…m address space within platform api (sonic-net#126) * [sonic_sfp] adding abstract methods for platform api's Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
* [sonic-ax-impl]: Add SNMP support for multi-asic platform: - Modify interface, lag, queue related functions to get data from all databases. - Update implementation of the following MIBS to get data from all databases: - InterfaceMIB - InterfaceMIBObjects - CiscoSystemExtMIB - csqIfQosGroupStatsTable * Fix as per review comments. Test case for init_namespace_dbs * Remove whitespace. * Add namespace support to IpCidrRouteTable MIB. * Add testcases for multiple namesapce for below MIBS: InterfaceMIB InterfaceMIBObjects cpfcIfPriorityTable * Remove debug print messages. * Modified as per review comments. Added a new class for Namespace related functions. Updated single namespace testcase to load database_config.json. * Changes made as per LGTM comments and review comments. * Minor fix to remove import of module not being used. * Fix PortChannel name in asic1 mock table. * Remove import of libraries that are not required. * Corrections in namespace database json files. * Add namespace test case for csqIfQosGroupStatsTable. * Fix SonicV2Connector mock __init__ function to match changes in swsssdk. * Change function name as per review comment. Add mock connect function to get mock db filenames.
Update sonic-sub-port-intf-hld.md
79edf66 Longxiang Lyu Wed Aug 17 08:12:37 2022 +0800 Fix azure pipeline (#118) 8e0f2c6 Longxiang Lyu Wed Aug 17 08:36:07 2022 +0800 Update linkmgr health after getting default route update (#117) b14ffb8 Jing Zhang Wed Aug 17 15:44:37 2022 -0700 [active-active] post mux metrics events (#123) a30dbb3 Jing Zhang Thu Aug 18 18:16:04 2022 -0700 Update handleMuxConfigNotification logic (#125) e14aaba Jing Zhang Tue Aug 23 10:02:17 2022 -0700 [active-active] Remove unnecessary mux wait timeout logs (#122) cc83717 Longxiang Lyu Fri Sep 2 02:17:53 2022 +0800 Fix mux config (#128) 5429281 Mai Bui Thu Sep 1 17:44:04 2022 -0400 [linkmgrd] Replace memset function in link_prober (#126) b5aaec1 Jing Zhang Fri Sep 9 14:01:03 2022 -0700 [active-active] shutdown link prober when starting as isolated (#130) 75f02cf Jing Zhang Tue Sep 13 10:34:32 2022 -0700 [active-standby] update warmboot reconciliation logic (#129) a5a9f90 Hua Liu Fri Sep 16 09:54:32 2022 +0800 Install libyang to azure pipeline (#132) 6fe4f0f Jing Zhang Tue Sep 20 10:10:16 2022 -0700 [Active-Active] flaky LinkmgrdBootupSequence unit tests (#134) ea68e8c Jing Zhang Wed Sep 21 10:52:18 2022 -0700 Post switchover reasons to STATE DB (#131) 60c35b5 Jing Zhang Thu Sep 22 13:00:41 2022 -0700 [Active-Active] server side admin forwarding state sync up (#133) 08e1be5 Jing Zhang Mon Sep 26 10:59:27 2022 -0700 [Active-Active] avoid being stuck in unknown after process init (#136) 2579988 Jing Zhang Mon Oct 3 09:40:55 2022 -0700 [Active-Standby] fix syslog flood caused by unkown -> standby switchovers (#137) 7e9f670 Jing Zhang Wed Oct 5 10:03:45 2022 -0700 [Active-Active] Retry config mux mode standby (#139) 23feb3b Jing Zhang Wed Oct 5 15:22:58 2022 -0700 [Active-Active] Post link prober stats to state db (#140) e650098 Jing Zhang Fri Oct 7 15:27:17 2022 -0700 [Active-Active] Update default route shutdown heartbeat logic (#141) d0653e7 Jing Zhang Tue Oct 11 10:22:02 2022 -0700 [Active-Standby] avoid posting mux metrics event when receiving unsolicited mux state notification (#142) dcf6460 Longxiang Lyu Fri Oct 21 12:15:42 2022 +0800 [active-active] Add support to send/handle mux probe request (#147) fdf42ed Longxiang Lyu Fri Oct 21 10:34:47 2022 +0800 Fix link prober state event report twice issue (#149) 5fd19a3 Longxiang Lyu Mon Oct 17 09:20:27 2022 +0800 [active-active] Fix config reload (#145) sign-off: Jing Zhang zhangjing@microsoft.com
Update sonic-py-swsssdk submodule pointer to include the following: * e30a1e1 Throw exception when not use swsssdk in UT. ([sonic-net#126](sonic-net/sonic-py-swsssdk#126)) Signed-off-by: dprital <drorp@nvidia.com>
Update sonic-py-swsssdk submodule pointer to include the following: 7f008a1 Fix UT test_BlockUseSwsssdk() (sonic-net#128) e30a1e1 Throw exception when not use swsssdk in UT. (sonic-net#126) Signed-off-by: dprital <drorp@nvidia.com>
Why I did it [Submodule][202211] Advance sonic-restapi pointer The branch 202012 has already updated to commit 47e4b53. 4f6f979 Fix the redis security issue CVE-2023-28858 and CVE-2023-28859 (#139) 47e4b53 Fix adv_pfx len for ipv6 (#135) 44121be Support ipv6 prefix lenght greater than 64 and check for adv_prefix (#134) 99c467d Add API support for adv prefix and custom monitoring (#133) 347684a Use github code scanning instead of LGTM (#132) 86543d0 Updates to route PATCH API (#129) a1af82c Install libyang to azure pipeline (#128) 2007c4c Increase coverage threshold (#126) Work item tracking Microsoft ADO (number only): 17705422 How I did it How to verify it
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
…lly (#15520) #### Why I did it src/sonic-gnmi ``` * 01fe667 - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #134 from FengPan-Frank/fenpan_dialout_rename (3 days ago) [Feng-msft] |\ | * 994c69c - Rename --enable-dialout option into ENABLE_DIALOUT to follow the convention. (3 days ago) [Feng Pan] |/ * a9126da - Update makefile to support armhf (#132) (3 days ago) [ganglv] * 0d80c0d - prevent potential panic: return immediately if there exists error (#113) (7 days ago) [Mai Bui] * 3c0fca3 - Merge pull request #131 from FengPan-Frank/fenpan_dialout (7 days ago) [Feng-msft] |\ | * c3d3266 - Add build flag into gnmi as --enable-dialout. (8 days ago) [Feng Pan] |/ * fd78c42 - add semgrep (#126) (2 weeks ago) [Mai Bui] * 214fa1c - TranslClient: Use new translib subscription APIs (#122) (3 weeks ago) [Sachin Holla] * 87d8eb3 - (origin/202305) TranslClient: use PathValidator to sanitize the request paths (#112) (3 weeks ago) [Sachin Holla] ``` #### How I did it #### How to verify it #### Description for the changelog
…ck to prevent JSON decoder errors (from PR sonic-net#126 in sonic-host-services repo)
No description provided.