Throw exception when not use swsssdk in UT. #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E test will validate with this PR: sonic-net/sonic-buildimage#12036 |
|
This PR depends on another PR merge first: sonic-net/sonic-buildimage#12185 |
|
The code change in this PR validated with this PR: sonic-net/sonic-buildimage#12036 |
qiluo-msft
reviewed
Sep 28, 2022
qiluo-msft
reviewed
Sep 28, 2022
qiluo-msft
reviewed
Sep 28, 2022
| @@ -26,12 +26,6 @@ | |||
| extras_require={ | |||
| 'high_perf': high_performance_deps | |||
| }, | |||
| entry_points={ | |||
| 'console_scripts': [ | |||
There was a problem hiding this comment.
Sorry for misleading. console_scripts variable should be defined at file global scope. It is not a parameter for setup function.
qiluo-msft
reviewed
Sep 29, 2022
test/test_moduleLoad.py
Outdated
| @@ -34,3 +34,11 @@ def test__dbConfig(self): | |||
| for namespace in list(dbConfig.get_ns_list()): | |||
| self.assertEqual(dbConfig.get_dbid('PFC_WD_DB', namespace), 5) | |||
| self.assertEqual(dbConfig.get_dbid('APPL_DB', namespace), 0) | |||
|
|
|||
| def test_BlockUseSwsssdk(): | |||
| # change | |||
qiluo-msft
approved these changes
Oct 5, 2022
EdenGri
pushed a commit
to EdenGri/sonic-py-swsssdk
that referenced
this pull request
Oct 30, 2022
#### Why I did it swsssdk been deprecated after 202205 branch, all use should switch to sonic-swss-common. #### How I did it Throw exception when load swsssdk for none UT usage. #### How to verify it Pass all UT. #### Which release branch to backport (provide reason below if selected) #### Description for the changelog Throw exception when load swsssdk for none UT usage. #### Link to config_db schema for YANG module changes #### A picture of a cute animal (not mandatory but encouraged)
EdenGri
pushed a commit
to EdenGri/sonic-py-swsssdk
that referenced
this pull request
Oct 30, 2022
#### Why I did it swsssdk been deprecated after 202205 branch, all use should switch to sonic-swss-common. #### How I did it Throw exception when load swsssdk for none UT usage. #### How to verify it Pass all UT. #### Which release branch to backport (provide reason below if selected) #### Description for the changelog Throw exception when load swsssdk for none UT usage. #### Link to config_db schema for YANG module changes #### A picture of a cute animal (not mandatory but encouraged)
EdenGri
pushed a commit
to EdenGri/sonic-py-swsssdk
that referenced
this pull request
Oct 31, 2022
This reverts commit e30a1e1.
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Oct 31, 2022
Update sonic-py-swsssdk submodule pointer to include the following: * e30a1e1 Throw exception when not use swsssdk in UT. ([sonic-net#126](sonic-net/sonic-py-swsssdk#126)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
swsssdk been deprecated after 202205 branch, all use should switch to sonic-swss-common.
How I did it
Throw exception when load swsssdk for none UT usage.
How to verify it
Pass all UT.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Throw exception when load swsssdk for none UT usage.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)