[202205] Don't create the members@ array in config_db for PC when reading from… #14028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… minigraph (sonic-net#13660) Fixes sonic-net#11873. When loading from minigraph, for port channels, don't create the members@ array in config_db in the PORTCHANNEL table. This is no longer needed or used. In addition, when adding a port channel member from the CLI, that member doesn't get added into the members@ array, resulting in a bit of inconsistency. This gets rid of that inconsistency.
yxieca
approved these changes
Mar 1, 2023
5 tasks
arlakshm
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 6, 2023
Description of PR With sonic-net/sonic-buildimage#14028, lag members are not added in PORTCHANNEL table in config_db anymore. Fix Fix test_voq_intfs to retrieve lag members from PORTCHANNEL_MEMBER table.
wangxin
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Mar 7, 2023
Description of PR With sonic-net/sonic-buildimage#14028, lag members are not added in PORTCHANNEL table in config_db anymore. Fix Fix test_voq_intfs to retrieve lag members from PORTCHANNEL_MEMBER table.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… minigraph (#13660)
Fixes #11873.
When loading from minigraph, for port channels, don't create the members@ array in config_db in the PORTCHANNEL table. This is no longer needed or used.
In addition, when adding a port channel member from the CLI, that member doesn't get added into the members@ array, resulting in a bit of inconsistency. This gets rid of that inconsistency.
Cherry-pick of #13660.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)