Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E1031] enable emc2305 fan controller timeout feature #14401

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

qnos
Copy link
Contributor

@qnos qnos commented Mar 24, 2023

Why I did it

There is rare condition, emc2305 hold SMBus and cause SMBus completion wait timed out.

MSFT ADO: 16520748

How I did it

Enable EMC2305 SMBus timeout feature, 30ms period of inactivity will reset the interface.

How to verify it

Use 'i2cget -y -f 23 0x4d 0x20 b' to read EMC2305 configuration register and check DIS_TO bit not set.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Why I did it
There is rare condition, emc2305 hold SMBus and cause SMBus completion wait timed out.

How I did it
Enable EMC2305 SMBus timeout feature, 30ms period of inactivity will reset the interface.

How to verify it
Use 'i2cget -y -f 23 0x4d 0x20 b' to read EMC2305 configuration register and check DIS_TO bit not set.

Signed-off-by: Eric Zhu <erzhu@celestica.com>
@qnos qnos requested a review from lguohan as a code owner March 24, 2023 02:17
@assrinivasan
Copy link
Contributor

@prgeor @yxieca please help review, thanks

@prgeor
Copy link
Contributor

prgeor commented Mar 24, 2023

@lguohan please help merge

@assrinivasan
Copy link
Contributor

@yxieca please help cherry-pick to 202205
@qiluo-msft please help cherry-pick to 202012

Thanks!

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 15, 2023
…ic-net#14401)

Why I did it
There is rare condition, emc2305 hold SMBus and cause SMBus completion wait timed out.

How I did it
Enable EMC2305 SMBus timeout feature, 30ms period of inactivity will reset the interface.

How to verify it
Use 'i2cget -y -f 23 0x4d 0x20 b' to read EMC2305 configuration register and check DIS_TO bit not set.

Signed-off-by: Eric Zhu <erzhu@celestica.com>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 15, 2023
…ic-net#14401)

Why I did it
There is rare condition, emc2305 hold SMBus and cause SMBus completion wait timed out.

How I did it
Enable EMC2305 SMBus timeout feature, 30ms period of inactivity will reset the interface.

How to verify it
Use 'i2cget -y -f 23 0x4d 0x20 b' to read EMC2305 configuration register and check DIS_TO bit not set.

Signed-off-by: Eric Zhu <erzhu@celestica.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #15493

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #15494

mssonicbld pushed a commit that referenced this pull request Jun 16, 2023
)

Why I did it
There is rare condition, emc2305 hold SMBus and cause SMBus completion wait timed out.

How I did it
Enable EMC2305 SMBus timeout feature, 30ms period of inactivity will reset the interface.

How to verify it
Use 'i2cget -y -f 23 0x4d 0x20 b' to read EMC2305 configuration register and check DIS_TO bit not set.

Signed-off-by: Eric Zhu <erzhu@celestica.com>
mssonicbld pushed a commit that referenced this pull request Jun 16, 2023
)

Why I did it
There is rare condition, emc2305 hold SMBus and cause SMBus completion wait timed out.

How I did it
Enable EMC2305 SMBus timeout feature, 30ms period of inactivity will reset the interface.

How to verify it
Use 'i2cget -y -f 23 0x4d 0x20 b' to read EMC2305 configuration register and check DIS_TO bit not set.

Signed-off-by: Eric Zhu <erzhu@celestica.com>
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 21, 2023
…ic-net#14401)

Why I did it
There is rare condition, emc2305 hold SMBus and cause SMBus completion wait timed out.

How I did it
Enable EMC2305 SMBus timeout feature, 30ms period of inactivity will reset the interface.

How to verify it
Use 'i2cget -y -f 23 0x4d 0x20 b' to read EMC2305 configuration register and check DIS_TO bit not set.

Signed-off-by: Eric Zhu <erzhu@celestica.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202012: #15571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants