Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] don't install rsync if vcache is disabled #14407

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

k-v1
Copy link
Contributor

@k-v1 k-v1 commented Mar 24, 2023

Why I did it

We don't need to install rsync in every docker container if vcache is disabled.

How I did it

Install rsync in pre_run_buildinfo script only if vcache is enabled.

How to verify it

@lguohan lguohan requested a review from xumia March 27, 2023 21:13
@xumia
Copy link
Collaborator

xumia commented Mar 28, 2023

LGTM, the build failure may be caused by not running the command "apt-get update". I sent another PR to fix it, #14439. @k-v1, you also cherry-pick the commit in your PR, or rerun the test after the PR merged.

Step 14/77 : RUN apt-get install -y gnupg
 ---> Running in 803670deee75
Reading package lists...
Building dependency tree...
Reading state information...
Package gnupg is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'gnupg' has no installation candidate
The command '/bin/sh -c apt-get install -y gnupg' returned a non-zero code: 100

@xumia
Copy link
Collaborator

xumia commented Mar 28, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants