Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipmitool to SONIC rootfs #1448

Closed
wants to merge 2 commits into from
Closed

Add ipmitool to SONIC rootfs #1448

wants to merge 2 commits into from

Conversation

jostar-yang
Copy link
Contributor

- What I did
add ipmitool to rootfs
- How I did it
add ipmitool to build_debian.sh
- How to verify it
User can use ipmitool in rootfs
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

lguohan
lguohan reviewed Mar 3, 2018
View reviewed changes
build_debian.sh
@@ -221,7 +221,8 @@ sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y in
unzip \
gdisk \
sysfsutils \
grub2-common
grub2-common \
ipmitool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this into pmon docker? will it work?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jleveque

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ipmitool is common utility. It should put to "/usr/bin" for user application can access BMC.
If there is any concern on SONIC project, please tell me how to add ipmitool cmd to pmon docker.
I need to study and test on as7716-32XB BMC project. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We study pmon docker and ipmitool use. We think ipmitool is like i2c-tool that are common utility tool. Ipmitool should put to /usr/bin or usr/sbin in SONiC rootfs, not put to any docker container. For BMC project, user only can access i2c from ipmitool. For non-MBC project, user can access i2c from i2c-tool.

@lguohan
Copy link
Collaborator

lguohan commented Aug 12, 2018

ipmitool has been added to docker-platform-monitor.

@lguohan lguohan closed this May 2, 2019
@jostar-yang jostar-yang deleted the 20180302_a0001 branch August 6, 2019 02:46
lguohan pushed a commit that referenced this pull request Oct 14, 2020
@nazariig
[submodule]: Advance swss submodule. (#5611)
0155a15 
- [portsorch]: Set proper initial forwarding state for LAG member #1448

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
abdosi added a commit that referenced this pull request Oct 21, 2020
@abdosi
[submodule update] sonic-swss
0e1b9a5 
  [portsorch]: Set proper initial forwarding state for LAG member
  (#1448)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request Jan 14, 2021
@nazariig @abdosi
[portsorch]: Set proper initial forwarding state for LAG member (soni…
b274365 
…c-net#1448)

* [portsorch]: Set proper initial forwarding state for LAG member.
* [portsorch]: Fix review comments.
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@nazariig @santhosh-kt
[submodule]: Advance swss submodule. (sonic-net#5611)
ba83c3d 
- [portsorch]: Set proper initial forwarding state for LAG member sonic-net#1448

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@DavidZagury DavidZagury mentioned this pull request Mar 3, 2021
Closed
4 tasks
@vdahiya12 vdahiya12 mentioned this pull request Mar 9, 2021
Merged
4 tasks
vdahiya12 added a commit that referenced this pull request Mar 10, 2021
@vdahiya12
[sonic-utilities] submodule update (#6992)
ddf51c7 
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (#1460)
e32b5ac Add soft-reboot reboot type (#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (#1416)
79ccd03 [show] cli support for show muxcable cableinfo (#1448)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
daall added a commit to daall/sonic-buildimage that referenced this pull request Mar 10, 2021
@daall
[202012][submodule] Update sonic-utilities submodule
a7a78cc 
- [acl-loader] Improve input validation for acl_loader (sonic-net#1479)
- [show] cli support for show muxcable cableinfo (sonic-net#1448)

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall mentioned this pull request Mar 10, 2021
Merged
4 tasks
lguohan pushed a commit that referenced this pull request Mar 11, 2021
@daall
[202012][submodule] Update sonic-utilities submodule (#7012)
e88579b 
* [202012][submodule] Update sonic-utilities submodule
- [acl-loader] Improve input validation for acl_loader (#1479)
- [show] cli support for show muxcable cableinfo (#1448)

Signed-off-by: Danny Allen <daall@microsoft.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@vdahiya12
[show] cli support for show muxcable cableinfo (sonic-net#1448)
79ccd03 
Summary:
This PR provides the support for adding CLI commands for retrieving cable vendor name and part number information of the muxcable.
In particular these Cli commands are supported:
show muxcable cableinfo <port>

Approach
added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py

What is the motivation for this PR?
To add the support for Cli for muxcable to be utilized for retrieving cable vendor name and part number information of the muxcable.

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@vdahiya12 @raphaelt-nvidia
[sonic-utilities] submodule update (sonic-net#6992)
433a4f4 
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (sonic-net#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (sonic-net#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (sonic-net#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460)
e32b5ac Add soft-reboot reboot type (sonic-net#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (sonic-net#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (sonic-net#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (sonic-net#1416)
79ccd03 [show] cli support for show muxcable cableinfo (sonic-net#1448)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@vdahiya12
[sonic-utilities] submodule update (sonic-net#6992)
7463823 
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (sonic-net#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (sonic-net#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (sonic-net#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460)
e32b5ac Add soft-reboot reboot type (sonic-net#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (sonic-net#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (sonic-net#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (sonic-net#1416)
79ccd03 [show] cli support for show muxcable cableinfo (sonic-net#1448)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@nazariig
[portsorch]: Set proper initial forwarding state for LAG member (soni…
7880c7e 
…c-net#1448)

* [portsorch]: Set proper initial forwarding state for LAG member.
* [portsorch]: Fix review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan left review comments

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jostar-yang @lguohan @stcheng