[lldpmgrd] Fix potential race condition when interfaces are created #1469

jleveque · 2018-03-07T20:01:37Z

Resolves [LLDP] lldp portidsubtype was NOT set to "locally assigned" but "mac address" #1457

- What I did

Patch lldpctl/lldpcli so that it returns an error code if specified port doesn't exist
- Removed lldpd submodule; now cloning source repo and applying patch during build
Add retry logic to lldpmgrd so that it will continually retry lldpcli commands which return an error code
Cause swsscommon select() call to timeout after 10 seconds in order to periodically force a retry of any queued-up (i.e., previously failed) commands.

…lldpctl/lldpcli to return an error code if port doesn't exist

…dify some log message levels

stcheng · 2018-03-08T01:12:44Z

💯

swss: * c712c24 2021-03-04 | Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662) (HEAD -> 202012) [Prince Sunny] utilities: * 9a9bff4 2021-03-03 | [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475) (HEAD -> 202012) [Danny Allen] * d1e7d4e 2021-03-04 | [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470) [Junchao-Mellanox] * a1df1b4 2021-03-03 | [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469) [Danny Allen] * bab4a23 2021-03-03 | [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465) [Lawrence Lee] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

swss: * c712c24 2021-03-04 | Update StateDB with error if state change failed, Update APP_DB in all state chg req (#1662) (HEAD -> 202012) [Prince Sunny] utilities: * 9a9bff4 2021-03-03 | [acl] Expand VLAN into VLAN members when creating an ACL table (#1475) (HEAD -> 202012) [Danny Allen] * d1e7d4e 2021-03-04 | [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (#1470) [Junchao-Mellanox] * a1df1b4 2021-03-03 | [acl-loader] Add support for matching on ICMP and VLAN info (#1469) [Danny Allen] * bab4a23 2021-03-03 | [config reload]: On dual ToR systems, cache ARP and FDB tables (#1465) [Lawrence Lee] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

this PR updates the following commits in sonic-utilities 13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (#1467) f78e7ce [acl-loader] Improve input validation for acl_loader (#1479) 748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (#1368) 64604db [acl] Expand VLAN into VLAN members when creating an ACL table (#1475) 10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (#1465) 10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (#1470) 38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (#1469) e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (#1380) 4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (#1471) dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (#1460) e32b5ac Add soft-reboot reboot type (#1453) 8b3bc18 [reload] Improve reload by using sonic.target. (#1199) 99673bc [reboot] Add platform-specific reboot cause update hook (#1454) 2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (#1445) 1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (#1416) 79ccd03 [show] cli support for show muxcable cableinfo (#1448) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

…t#1469) - Add ICMP and VLAN fields - Add new unit test cases Signed-off-by: Danny Allen <daall@microsoft.com>

this PR updates the following commits in sonic-utilities 13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (sonic-net#1467) f78e7ce [acl-loader] Improve input validation for acl_loader (sonic-net#1479) 748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368) 64604db [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475) 10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465) 10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470) 38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469) e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (sonic-net#1380) 4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471) dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460) e32b5ac Add soft-reboot reboot type (sonic-net#1453) 8b3bc18 [reload] Improve reload by using sonic.target. (sonic-net#1199) 99673bc [reboot] Add platform-specific reboot cause update hook (sonic-net#1454) 2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445) 1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (sonic-net#1416) 79ccd03 [show] cli support for show muxcable cableinfo (sonic-net#1448) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

…tically (#20835) #### Why I did it src/sonic-sairedis ``` * e6ec1424 - (HEAD -> master, origin/master, origin/HEAD) [syncd] Add attribute version check feature (#1470) (14 hours ago) [Kamil Cudnik] * 29a8f86b - [meta] Use metadata to check port notification port_id type (#1469) (2 days ago) [Kamil Cudnik] * d772864e - innovium rename to marvell-teralynx (#1408) (2 days ago) [krismarvell] * 526bca31 - [submodule] Update SAI to lates origin master (#1466) (2 days ago) [Kamil Cudnik] * fc376d50 - [test] Add more testing for NotificationSwitchAsicSdkHealthEvent (#1463) (4 days ago) [Kamil Cudnik] * ed222eca - [submodule] Update SAI to v1.15.1 (#1462) (5 days ago) [Kamil Cudnik] ``` #### How I did it #### How to verify it #### Description for the changelog

jleveque added 4 commits March 7, 2018 02:24

[lldmgrd] Fix potential race condition with interface bring-up

0f41808

Remove lldpd submodule, now clone source repo, add patch that causes …

7b63e7c

…lldpctl/lldpcli to return an error code if port doesn't exist

Increase select() timeout to 10 seconds; Add log_debug() function; Mo…

a5c3b62

…dify some log message levels

Rename: run_pending_cmds() -> process_pending_cmds()

7896275

jleveque added Bug 🐛 Enhancement ➕ labels Mar 7, 2018

jleveque self-assigned this Mar 7, 2018

jleveque requested a review from lguohan March 7, 2018 20:01

lguohan approved these changes Mar 7, 2018

View reviewed changes

jleveque merged commit c161de4 into sonic-net:master Mar 8, 2018

jleveque deleted the lldpmgrd_race_cond_fix branch March 8, 2018 01:08

jleveque mentioned this pull request Aug 24, 2018

[Debian9-S6100]: In LLDP for port id , instead of interface name ,mac address is advertised #1488

Closed

daall mentioned this pull request Oct 26, 2020

[swss] Update swss submodule #5719

Merged

3 tasks

yxieca mentioned this pull request Mar 4, 2021

[202012][swss][utilities] advance submodule head #6969

Merged

vdahiya12 mentioned this pull request Mar 9, 2021

[sonic-utilities] submodule update #6992

Merged

4 tasks

theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022

Add missing lib for lgtm (sonic-net#1469)

f2ad8f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lldpmgrd] Fix potential race condition when interfaces are created #1469

[lldpmgrd] Fix potential race condition when interfaces are created #1469

jleveque commented Mar 7, 2018

stcheng commented Mar 8, 2018

[lldpmgrd] Fix potential race condition when interfaces are created #1469

[lldpmgrd] Fix potential race condition when interfaces are created #1469

Conversation

jleveque commented Mar 7, 2018

stcheng commented Mar 8, 2018