Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[device/accton]:Update Accton-AS7816-64X #1691

Closed
wants to merge 2 commits into from
Closed

[device/accton]:Update Accton-AS7816-64X #1691

wants to merge 2 commits into from

Conversation

pollyhsu2git
Copy link
Contributor

@pollyhsu2git pollyhsu2git commented May 10, 2018 •
edited
Loading

  • Update Accton-AS7816-64X to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure

Signed-off-by: polly_hsu@edge-core.com

- What I did
Update Accton-AS7816-64X to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure the SONiC Porting Guide

- How I did it
Add config.bcm based on the latest update of Device-Specific File Directory Structure the SONiC Porting Guide (https://github.com/Azure/SONiC/wiki/Porting-Guide)

- How to verify it

  1. Target-verified the port mapping of 64x100G as expected
  2. Target-verified the port link of 64x100G as expected
  3. Ran config_checker passed on our config.bcm

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[device/accton]:Update Accton-AS7816-64X
fc6b067 
* Update Accton-AS7816-64X to adapt xxx.config.bcm based on the latest update of `Device-Specific File Directory Structure`
Signed-off-by: polly_hsu@edge-core.com
@lguohan
Copy link
Collaborator

lguohan commented Sep 1, 2018

@pollyhsu2git, can you resolve conflict?

@pollyhsu2git
Copy link
Contributor Author

@lguohan
The conflict was resolved~

@pollyhsu2git
Copy link
Contributor Author

@lguohan @stcheng
May we know when this PR will be merged?

@lguohan
Copy link
Collaborator

lguohan commented Aug 15, 2019

it does not look like we still need this pr, @pollyhsu2git ? if yes, can you resolve the conflict?

stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Jun 29, 2021
@stephenxs
Advance sonic-utilites
8d0743d 
186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672)
7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640)
38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658)
c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691)
57dc403 [ci]: Fix config prompt question issue (sonic-net#1693)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
jleveque pushed a commit that referenced this pull request Jun 30, 2021
@stephenxs
[sonic-utilities] Update submodule (#8028)
7ddb8af 
186d851 Pcieutil to load the platform api first instead of using common api (#1672)
7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (#1640)
38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (#1658)
c5d00ae [pfcwd] Fix the return code in invalid case (#1691)
57dc403 [ci]: Fix config prompt question issue (#1693)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@haslersn haslersn mentioned this pull request Jul 17, 2021
Merged
qiluo-msft pushed a commit that referenced this pull request Jul 17, 2021
@Praveen-Brcm
[sonic-utilities] Update submodule (#8203)
c89b62e 
List of commits (newest first):

sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (#1138)
sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (#1709)
sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (#1705)
sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (#1666)
sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (#1711)
sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual
sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (#1692)
sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (#1706)
sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (#1554)
sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (#1679)
sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (#1699)
sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (#1672)
sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (#1640)
sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (#1658)
sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (#1691)
sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (#1693)
sonic-net/sonic-utilities@5708497 [show] fix show version (#1686)
sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (#1664)
sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (#1473)
sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (#1653)
sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (#1630)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@stephenxs
[sonic-utilities] Update submodule (sonic-net#8028)
835d6a0 
186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672)
7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640)
38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658)
c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691)
57dc403 [ci]: Fix config prompt question issue (sonic-net#1693)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@Praveen-Brcm
[sonic-utilities] Update submodule (sonic-net#8203)
93cefc3 
List of commits (newest first):

sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (sonic-net#1138)
sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (sonic-net#1709)
sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1705)
sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (sonic-net#1666)
sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (sonic-net#1711)
sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual
sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (sonic-net#1692)
sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (sonic-net#1706)
sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (sonic-net#1554)
sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net#1679)
sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (sonic-net#1699)
sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672)
sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640)
sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658)
sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691)
sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (sonic-net#1693)
sonic-net/sonic-utilities@5708497 [show] fix show version (sonic-net#1686)
sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (sonic-net#1664)
sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (sonic-net#1473)
sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (sonic-net#1653)
sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (sonic-net#1630)
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@neethajohn
[pfcwd] Fix the return code in invalid case (sonic-net#1691)
c5d00ae 
Signed-off-by: Neetha John <nejo@microsoft.com>

Fixes sonic-net#1690

What I did
Set the correct return code when pfcwd command is specified with invalid options

How to verify it
Modified the unit test to check for the correct return code and ran them and they passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement ➕ Platform: Accton Submodule Update ⏫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pollyhsu2git @lguohan @stcheng