Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[device/accton]:Update Accton-AS7326-56X #1711

Closed
wants to merge 5 commits into from
Closed

[device/accton]:Update Accton-AS7326-56X #1711

wants to merge 5 commits into from

Conversation

pollyhsu2git
Copy link
Contributor

@pollyhsu2git pollyhsu2git commented May 15, 2018 •
edited
Loading

  • Update Accton-AS7326-56X to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure
  • Update Accton-AS7326-56X upon the port link / led test upon bringing-up the new SAI version, 3.2.1.1 / OpenNSL, 3.5.0.4
  • Update Accton-AS7326-56X to add the MAC RESET opeation before bring-up the SDK based on the HW spec

Signed-off-by: polly_hsu@edge-core.com

- What I did
Update Accton-AS7326-56X based on the port link / led test via self bringing-up the new SAI version, 3.2.1.1 / OpenNSL, 3.5.0.4

- How I did it

  1. Update Accton-AS7326-56X to adapt xxx.config.bcm based on the latest update of Device-Specific File Directory Structure the SONiC Porting Guide.
  2. Update Accton-AS7326-56X against the latest update of the SONiC Porting Guide (https://github.com/Azure/SONiC/wiki/Porting-Guide).

- How to verify it

  1. Target-verified the port mapping of 48x25G+8x100G as expected
  2. Target-verified the port link of -48x25G+8x100G as expected
  3. Target-verified the port led of -48x25G+8x100G as expected
  4. Ran config_checker passed on our config.bcm

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Polly Hsu added 4 commits May 15, 2018 16:41
[device/accton]:Update Accton-AS7326-56X
43f4a2b 
* Update Accton-AS7326-56X to adapt xxx.config.bcm based on the latest update of `Device-Specific File Directory Structure`
* Update Accton-AS7326-56X upon the port link / led test upon bringing-up the new SAI version, 3.2.1.1 / OpenNSL, 3.5.0.4
* Update Accton-AS7326-56X to add the MAC RESET opeation before bring-up the SDK based on the HW spec

Signed-off-by: polly_hsu@edge-core.com
Update Accton-AS7326-56X
b91b14e 
* Update Accton-AS7326-56X to fix the issue of not linkup with other switch
Signed-off-by: polly_hsu@edge-core.com
[device/accton]: Update the build fix due to un-resolved conflicts
9d42150
Update Accton-AS7326-56X
927ee63 
* Update Accton-AS7326-56X to fix the MAC RESET
* Update Accton-AS7326-56X to modify the thermal_policy code
Signed-off-by: polly_hsu@edge-core.com
@lguohan
Copy link
Collaborator

lguohan commented Sep 1, 2018

@pollyhsu2git , can you resolve conflict?

@pollyhsu2git
Copy link
Contributor Author

@lguohan
We've updated our latest submodule code for resolving the conflict here~

@pollyhsu2git
Copy link
Contributor Author

@lguohan @stcheng
May we know whether we still have the conflicting files shown (minigraph.xml / sonic-platform-modules-accton?

@lguohan
Copy link
Collaborator

lguohan commented Sep 26, 2018

yes, we have

Conflicting files
device/accton/x86_64-accton_as7326_56x-r0/minigraph.xml
platform/broadcom/sonic-platform-modules-accton

@lguohan
Copy link
Collaborator

lguohan commented Sep 26, 2018

btw, you no longer need to check-in minigraph.xml due to this commit.

#2050

@pollyhsu2git
Copy link
Contributor Author

@lguohan
Thanks for the info~
For the sonic-platform-modules-accton conflict, do we do the compiling against the latest master base (Kernel 4)? or?

@lguohan
Copy link
Collaborator

lguohan commented Sep 26, 2018

all source code is in buildimage now.

@pollyhsu2git
Copy link
Contributor Author

@lguohan
Thanks!
We'll watch your posted build status here~

nikos-github
nikos-github reviewed Nov 14, 2018
View reviewed changes
Copy link
Collaborator

@nikos-github nikos-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pollyhsu2git Can you please update your PR to latest by resolving any conflicts and also do NOT use submodules? We don't use submodules for the drivers in sonic anymore and everything has been brought into sonic-buildimage.

@pollyhsu2git
Copy link
Contributor Author

@nikos-github
Got it! Sir~ We'll close this PR then. After we've tested it again with the latest Kernel 4, we'll create a new one.

@pollyhsu2git pollyhsu2git deleted the update-as7326_56x branch January 25, 2019 02:28
lguohan pushed a commit that referenced this pull request Apr 21, 2021
@shi-su
[sonic-swss] Update submodule (#7384)
2dc7dc3 
Update the sonic-swss submodule. The following is the new commit in the submodule.
```
b34f783 Resolve neighbor when nexthop does not exist (#1704)
500e2e9 [voq/inbandif] Voq inbandif port (#1602)
9f22ba7 Handle IPv6 and ECMP routes to be programmed to ASIC (#1711)
1b916c3 [acl] Add regression test for `config acl` CLI command (#1694)
8bc7aee Allowing the first time FEC and AN configuration to be pushed to SAI (#1705)
d0dd6ee [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (#1706)
d8b8ca9 fix for CRM available bug (#1699)
97f70d1 NAT : Update the CRM used counters for SNAT and DNAT entries (#1655)
a4e05a7 [vstest] System lag test timing issue fix (#1692)
ca8ba6d [vlan] Add support of VLAN host interface (#1645)
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Apr 23, 2021
@stephenxs
[submodule][202012] Advance submodule head for sonic-swss
4548791 
adf5ab58 [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663)
8a732726 [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650)
7ba813b2 [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634)
ed32e333 [portsorch] Configure hostif tagging for subports (sonic-net#1573)
b5209c43 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711)
515cc1a7 [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706)
0ad524b2 [202012] Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1710)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
lguohan pushed a commit that referenced this pull request Apr 24, 2021
@stephenxs
[submodule][202012] Advance submodule head for sonic-swss (#7411)
c91b02c 
adf5ab58 [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (#1663)
8a732726 [intfsorch] Create subport with the entry contains necessary attributes (#1650)
7ba813b2 [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (#1634)
ed32e333 [portsorch] Configure hostif tagging for subports (#1573)
b5209c43 Handle IPv6 and ECMP routes to be programmed to ASIC (#1711)
515cc1a7 [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (#1706)
0ad524b2 [202012] Allowing the first time FEC and AN configuration to be pushed to SAI (#1710)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@shi-su @raphaelt-nvidia
[sonic-swss] Update submodule (sonic-net#7384)
8522fd7 
Update the sonic-swss submodule. The following is the new commit in the submodule.
```
b34f783 Resolve neighbor when nexthop does not exist (sonic-net#1704)
500e2e9 [voq/inbandif] Voq inbandif port (sonic-net#1602)
9f22ba7 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711)
1b916c3 [acl] Add regression test for `config acl` CLI command (sonic-net#1694)
8bc7aee Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1705)
d0dd6ee [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706)
d8b8ca9 fix for CRM available bug (sonic-net#1699)
97f70d1 NAT : Update the CRM used counters for SNAT and DNAT entries (sonic-net#1655)
a4e05a7 [vstest] System lag test timing issue fix (sonic-net#1692)
ca8ba6d [vlan] Add support of VLAN host interface (sonic-net#1645)
@haslersn haslersn mentioned this pull request Jul 17, 2021
Merged
qiluo-msft pushed a commit that referenced this pull request Jul 17, 2021
@Praveen-Brcm
[sonic-utilities] Update submodule (#8203)
c89b62e 
List of commits (newest first):

sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (#1138)
sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (#1709)
sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (#1705)
sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (#1666)
sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (#1711)
sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual
sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (#1692)
sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (#1706)
sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (#1554)
sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (#1679)
sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (#1699)
sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (#1672)
sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (#1640)
sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (#1658)
sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (#1691)
sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (#1693)
sonic-net/sonic-utilities@5708497 [show] fix show version (#1686)
sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (#1664)
sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (#1473)
sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (#1653)
sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (#1630)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@shi-su
[sonic-swss] Update submodule (sonic-net#7384)
9aaff5d 
Update the sonic-swss submodule. The following is the new commit in the submodule.
```
b34f783 Resolve neighbor when nexthop does not exist (sonic-net#1704)
500e2e9 [voq/inbandif] Voq inbandif port (sonic-net#1602)
9f22ba7 Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711)
1b916c3 [acl] Add regression test for `config acl` CLI command (sonic-net#1694)
8bc7aee Allowing the first time FEC and AN configuration to be pushed to SAI (sonic-net#1705)
d0dd6ee [Dynamic buffer calc][Mellanox] Fix bug: buffer over subscription in buffer pool size calculation (sonic-net#1706)
d8b8ca9 fix for CRM available bug (sonic-net#1699)
97f70d1 NAT : Update the CRM used counters for SNAT and DNAT entries (sonic-net#1655)
a4e05a7 [vstest] System lag test timing issue fix (sonic-net#1692)
ca8ba6d [vlan] Add support of VLAN host interface (sonic-net#1645)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@Praveen-Brcm
[sonic-utilities] Update submodule (sonic-net#8203)
93cefc3 
List of commits (newest first):

sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (sonic-net#1138)
sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (sonic-net#1709)
sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1705)
sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (sonic-net#1666)
sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (sonic-net#1711)
sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual
sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (sonic-net#1692)
sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (sonic-net#1706)
sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (sonic-net#1554)
sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net#1679)
sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (sonic-net#1699)
sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672)
sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640)
sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658)
sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691)
sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (sonic-net#1693)
sonic-net/sonic-utilities@5708497 [show] fix show version (sonic-net#1686)
sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (sonic-net#1664)
sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (sonic-net#1473)
sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (sonic-net#1653)
sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (sonic-net#1630)
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@prsunny
Handle IPv6 and ECMP routes to be programmed to ASIC (sonic-net#1711)
9f22ba7 
*In case of standby mux, associated routes may come to orch with ifname of tun0. Handle the case when nexthop is non-zero
*For ECMP, multiple nexthop IPs can have the same sai nexthop id (tunnel NH). Existing data structure is unable to handle such case. Added a secondary map if nexthops are shared
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@qiluo-msft
Coverage uses top level directory as source (sonic-net#1711)
8fe7e26 
Originally, the Azure pipeline "Code Coverage" page will render folder structure wrongly. The first level of folders disappear and all the files in the first level are combined and de-dup. So we lost many main.py, etc.

Fix the coveragerc file so that the rendering will make sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikos-github nikos-github nikos-github left review comments

Assignees
No one assigned
Labels
Enhancement ➕ Platform: Accton Submodule Update ⏫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pollyhsu2git @lguohan @nikos-github @stcheng