[Edgecore][sonic-platform-modules-accton]Support kernel 6.1 and bookworm #16982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is for fix issue, |
|
Thank you for updating the Accton platform module for Bookworm! Since it looks like there's a dependency on PDDF, I'll get #16954 merged in first and then have the PR checkers be rerun, and verify that the Broadcom build succeeds. |
|
@jostar-yang Could you resolve the conflicts? I think cherry-picking the pddf commit introduced the conflicts. |
OK. Done to fix conflicts. |
saiarcot895
approved these changes
Oct 27, 2023
|
/azpw run Azure.sonic-buildimage |
|
/azpw run |
|
/azpw run Azure.sonic-buildimage |
saiarcot895
pushed a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Nov 7, 2023
…orm (sonic-net#16982) * [Edgecore][sonic-platform-modules-accton]Support kernel 6.1 and bookworm * Modify pddf drv code for i2c_remove_callback function fail
saiarcot895
pushed a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Nov 21, 2023
…orm (sonic-net#16982) * [Edgecore][sonic-platform-modules-accton]Support kernel 6.1 and bookworm * Modify pddf drv code for i2c_remove_callback function fail
yxieca
pushed a commit
that referenced
this pull request
Nov 22, 2023
…orm (#16982) * [Edgecore][sonic-platform-modules-accton]Support kernel 6.1 and bookworm * Modify pddf drv code for i2c_remove_callback function fail
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The sonic-platform-modules-accton package builds were failing to build against the 6.1 kernel in bookworm branch.
Work item tracking
How I did it
Enable rule.mk to let build sonic-platform-modules-accton
Modify accton driver that use "i2c_driver->remove callback function" to use "void" instead of "init".
Because kernel 6.1 has change to be below.
struct i2c_driver {
unsigned int class;
Old kernel define as below,
.....
init (*remove)(struct i2c_client *client);
How to verify it
Build deb.
BLDENV=bookworm make -f Makefile.work $@
Check deb can build successfully
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)