[sonic-telemetry]: Install vendor package management for golang #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Aug 23, 2018
| @@ -242,6 +242,10 @@ RUN export VERSION=1.8.3 \ | |||
| && echo 'export GOROOT=/usr/local/go' >> /etc/bash.bashrc \ | |||
| && echo 'export PATH=$PATH:$GOROOT/bin' >> /etc/bash.bashrc | |||
|
|
|||
| # For go telemetry build | |||
| RUN wget http://ftp.us.debian.org/debian/pool/main/g/golang-glide/golang-glide_0.12.3-2+b3_amd64.deb \ | |||
| && dpkg -i golang-glide_0.12.3-2+b3_amd64.deb | |||
There was a problem hiding this comment.
can we just use apt-get to installer?
There was a problem hiding this comment.
It's failed to use apt-get to install it. Because the glide apt-repository has no appropriate package for debian jessie/stretch.
$ sudo add-apt-repository ppa:masterminds/glide && sudo apt-get update
You are about to add the following PPA to your system:
Glide dist
See https://glide.sh
More info: https://launchpad.net/~masterminds/+archive/ubuntu/glide
Press [ENTER] to continue or ctrl-c to cancel adding it
gpg: keyring `/tmp/tmplu9zsuem/secring.gpg' created
gpg: keyring `/tmp/tmplu9zsuem/pubring.gpg' created
gpg: requesting key 890C81B2 from hkp server keyserver.ubuntu.com
gpg: /tmp/tmplu9zsuem/trustdb.gpg: trustdb created
gpg: key 890C81B2: public key "Launchpad PPA for Masterminds" imported
gpg: Total number processed: 1
gpg: imported: 1 (RSA: 1)
OK
......
Err http://ppa.launchpad.net jessie/main amd64 Packages
404 Not Found
Get:23 http://debian-archive.trafficmanager.net jessie/contrib amd64 Packages [59.2 kB]
Get:24 http://debian-archive.trafficmanager.net jessie/non-free amd64 Packages [101 kB]
Fetched 31.0 MB in 4s (6421 kB/s)
W: Size of file /var/lib/apt/lists/debian-archive.trafficmanager.net_debian-security_dists_jessie_updates_main_binary-amd64_Packages.gz is not what the server reported 645826 645898
W: Size of file /var/lib/apt/lists/security.debian.org_dists_jessie_updates_main_binary-amd64_Packages.gz is not what the server reported 645826 645898
W: Failed to fetch http://ppa.launchpad.net/masterminds/glide/ubuntu/dists/jessie/main/binary-amd64/Packages 404 Not Found
$
$ sudo apt-get install glide
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package glide
There was a problem hiding this comment.
There was a problem hiding this comment.
The docker-salve version is debian jessie in our environment, so it's failed to use 'apt-get' to get golang-glide directly. So I tried the recommend method ( use ppa ) in the Glide github.
https://github.com/Masterminds/glide
If debian stretch has golang-glide package, we can use 'apt-get'. But for jessie, I think we need to use this way.
There was a problem hiding this comment.
Try another docker slave: https://github.com/Azure/sonic-buildimage/blob/master/sonic-slave-stretch/Dockerfile
There was a problem hiding this comment.
then please back port golang-glide to jessie, or upgrade the telemetry docker to stretch.
There was a problem hiding this comment.
directly pull the golang-glide from stretch distribution in jessie docker is not a standard way.
maybe we should just do 'curl https://glide.sh/get | sh' as suggested by the glide website.
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Oct 29, 2021
The submodule update includes the following commits ac3103a Add missing neighbor resolution for MPLS route programming (sonic-net#1968) bfba0ad [vlanmgr]Fix for STATE_DB port check logic (sonic-net#1980) 9ef2ba4 Update VLAN removal code to work with 5.10 kernel and new 41fb26c Handle setting unknown mux state (sonic-net#1984) ac09bde Increase timeout for VS tests (sonic-net#1988) da8a43e Check if appl DB exists before deleting (sonic-net#1983) 553d75a Change tunnel orch order (sonic-net#1977) 7444e96 Add rekey period in macsec mgr (sonic-net#1958) d95823d [Buffermgr]Graceful handling of buffer model change (sonic-net#1956) b0aa6a0 EVPN VxLAN enhancement to support P2MP tunnel based programming for L 85bdf54 Fix the option missing in kernel config issue (sonic-net#1973) 6b15584 Orchagent validates mirror session queue parameter against maximum va fc9ffb9 [copp] Add ISIS, LDP and micro-BFD trap types to CoPP manager (sonic-net#1890) 452cbc1 [macsecorch]: Add IPG adjusting for MACsec gearbox model (sonic-net#1925) Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
lguohan
pushed a commit
that referenced
this pull request
Nov 1, 2021
The submodule update includes the following commits ac3103a Add missing neighbor resolution for MPLS route programming (#1968) bfba0ad [vlanmgr]Fix for STATE_DB port check logic (#1980) 9ef2ba4 Update VLAN removal code to work with 5.10 kernel and new 41fb26c Handle setting unknown mux state (#1984) ac09bde Increase timeout for VS tests (#1988) da8a43e Check if appl DB exists before deleting (#1983) 553d75a Change tunnel orch order (#1977) 7444e96 Add rekey period in macsec mgr (#1958) d95823d [Buffermgr]Graceful handling of buffer model change (#1956) b0aa6a0 EVPN VxLAN enhancement to support P2MP tunnel based programming for L 85bdf54 Fix the option missing in kernel config issue (#1973) 6b15584 Orchagent validates mirror session queue parameter against maximum va fc9ffb9 [copp] Add ISIS, LDP and micro-BFD trap types to CoPP manager (#1890) 452cbc1 [macsecorch]: Add IPG adjusting for MACsec gearbox model (#1925) Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
stepanblyschak
added a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Nov 11, 2021
``` 5f8ebfa (HEAD, origin/master, origin/HEAD, master) [AclOrch] move ACL counters to flex counter infrastructure (sonic-net#1943) 8119ec0 [bfdorch] Orchagent support hardware BFD (sonic-net#1883) 15074ac [sonic-swss]:enable unconfiguring PFC on last TC on a port (sonic-net#1962) 05c7c05 [Mux orch] set default as standby, change mux orch priority (sonic-net#2010) fe5b2a9 [pytest]: Ignore errors deleting host ifs (sonic-net#2005) 70da9af [ci]: use native arm64 and armhf pool (sonic-net#2013) e14a071 [qos] Add EXP to TC map support (sonic-net#1954) c91a7f2 [switchorch] Implement VXLAN src port range feature (sonic-net#1959) b20f0f4 Gcov for swss daemon (sonic-net#1737) 01c243a [CRM][MPLS] Fix the mpls nexthop CRM attribute (sonic-net#2008) 8448a60 [vs tests]Migrating sonic-swss tests to use hwsku instead of fakeplatform (sonic-net#1978) faa26db Fix random failure in PR/CI build. (sonic-net#2006) e03edb6 Allow interface type value none (sonic-net#1991) 71b9650 [orchagent] Fix group name of port-buffer-drop in flexcounterorch.cpp (sonic-net#1967) facdef5 [VS test] Skip flaky virtual chassis test (sonic-net#2004) 8261c1f [pytest]: Increase timeout when checking services (sonic-net#2000) 67278be [teammgrd]: Handle LAGs cleanup gracefully on Warm/Fast reboot. (sonic-net#1934) e92c1df Enable FEC statistics collection for Ethernet ports (sonic-net#1994) 9f30ca1 VxLAN Tunnel Counters and Rates implementation (sonic-net#1859) ac3103a Add missing neighbor resolution for MPLS route programming (sonic-net#1968) bfba0ad [vlanmgr]Fix for STATE_DB port check logic (sonic-net#1980) 9ef2ba4 [vlanmgr]: Update VLAN removal code to work with 5.10 kernel and newer iproute2 versions (sonic-net#1970) 41fb26c [Mux orch] Handle setting unknown mux state (sonic-net#1984) ac09bde [azp]: Increase timeout for VS tests (sonic-net#1988) da8a43e [pytest]: Check if appl DB exists before deleting (sonic-net#1983) 553d75a [tunnel decap] Change tunnel orch order (sonic-net#1977) 7444e96 [macsecmgr]: Add rekey period in macsec mgr (sonic-net#1958) d95823d [Buffermgr]Graceful handling of buffer model change (sonic-net#1956) b0aa6a0 EVPN VxLAN enhancement to support P2MP tunnel based programming for Layer2 extension (sonic-net#1858) 85bdf54 Fix the option missing in kernel config issue (sonic-net#1973) 6b15584 Orchagent validates mirror session queue parameter against maximum value from SAI (sonic-net#1957) fc9ffb9 [copp] Add ISIS, LDP and micro-BFD trap types to CoPP manager (sonic-net#1890) 452cbc1 [macsecorch]: Add IPG adjusting for MACsec gearbox model (sonic-net#1925) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
judyjoseph
added a commit
that referenced
this pull request
Nov 14, 2021
sonic-snmpagent 7e46eb1 [201911][RFC1213]: Initialize lag oid map in reinit_data (#234) aa98ded CPU Spike because of redundant and flooded keyspace notifis handled (#230) sonic-swss bc4e334 [Mux orch] Handle setting unknown mux state (#1984) bd3630b [tunnel decap] Change tunnel orch order (#1977) 87a673a Fix the option missing in kernel config issue (#1973) 57967a1 [orchagent] Fix group name of port-buffer-drop in flexcounterorch.cpp (#1967) sonic-utilities 181e8b0 Fix the option missing in kernel config issue (#1888) 21c0cc0 [watermarkstat] Fix for error in processing empty array from couters db (#1810) 7f15755 [chassis][supervisor][show][interfaces]show interfaces command warning on Supervisor card (#1771)
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Jan 6, 2022
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> 30f5dd6 Update the example for pfcwd start command (sonic-net#1984) 9e30871 [Auto Techsupport] Event driven Techsupport Bug Fixes (sonic-net#1986) fbd565d Fix wrong help message for cable length setting (sonic-net#1978) b3a5052 [GCU] Using simulated config instead of target config when validating replace operation in NoDependencyMoveValidator (sonic-net#1987) 35cb524 [GCU] Copying config_db before callding sonic_yang.loadData (sonic-net#1983) a98858d [GCU] Different apply-patch runs should produce same sorted steps (sonic-net#1988) 8c81ae3 [breakout] Fix the check when port is not present in BREAKOUT_CFG table (sonic-net#1765) bc8fe7c [doc][DPB] Update DPB related interface breakout command Info (sonic-net#1438) 1a2a9a3 [config] Fix 'config reload -l' command to get filename by default (sonic-net#1611) ed2fa69 [debug dump util] FDB debug dump util changes (sonic-net#1968) 3b642c9 [GCU] Loading yang-models only once (sonic-net#1981) bb56fc2 Update swss_ready check to check per namespace swss service (sonic-net#1974) 4f39f9f [GCU] Moving PatchSorter unit-test to json file to make it easier to read/maintain (sonic-net#1977) 1a75870 [CLI][Help string] Changed the show command help text to be more consistent with each other. 818dcbf [GCU] Implementing DryRun by printing patch-sorter steps/imitating config_db (sonic-net#1973)
judyjoseph
added a commit
that referenced
this pull request
Jan 9, 2022
4236bc4 [config reload] Fixing config reload when timer based delayed services are disabled (#1967) d2514e4 [GCU] Different apply-patch runs should produce same sorted steps (#1988) 2878adb [GCU] Using simulated config instead of target config when validating replace operation in NoDependencyMoveValidator (#1987) fb8ca98 [GCU] Loading yang-models only once (#1981) f88ee92 [GCU] Copying config_db before callding sonic_yang.loadData (#1983) 9ed0e91 [GCU] Implementing DryRun by printing patch-sorter steps/imitating config_db (#1973) b36b5e3 [GCU] Moving PatchSorter unit-test to json file to make it easier to read/maintain (#1977) c0fa28b [generic-config-updater] Improving CreateOnly validator and marking /LOOPBACK_INTERFACE/LOOPBACK#/vrf_name as create-only (#1969) 0559d04 [generic-config-updater] Adding non-strict mode (#1929) b07f477 [debug dump util] FDB debug dump util changes (#1968) 6d8757a [warm/fast-reboot] Fix kexec portion to support platforms based on Device Tree (#1966) cc1409e [Auto Techsupport] Event driven Techsupport Bug Fixes (#1986) 6c48bd5 Fix wrong help message for cable length setting (#1978) c0bbbe3 [breakout] Fix the check when port is not present in BREAKOUT_CFG table (#1765) 5bb8cad [doc][DPB] Update DPB related interface breakout command Info (#1438) e6fd990 [config] Fix 'config reload -l' command to get filename by default (#1611) bd8f7bb Update swss_ready check to check per namespace swss service (#1974) 5439f94 [soft-reboot] Add support for platforms based on Device Tree (#1963) 7c5810a [config] Add portchannel support for static route (#1857) 7cb6a1b preserve old order for config reload (#1964) 20bddbd [Auto-Techsupport] Issues related to Multiple Cores crashing handled (#1948)
5 tasks
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
*Tunnel creation and termination attributes to be set after QoS init
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
…read/maintain (sonic-net#1977) #### What I did Moved PatchSorter unit-test to json file to make it easier to read/maintain In the future this test json file can be used for adding nightly tests. While testing I had to set `skip_exact_change_list_match=True` because different runs of the same input produce correct but different changes. It is better to always generate the same steps for easier debugging. Created issue: sonic-net#1976 #### How I did it Copied to Json file the following: - current_config i.e. current running config - patch - expected change list #### How to verify it unit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Install a go tool 'glide' to manage vendor packages.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)