Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Update Mellanox-SN5600-C256S1 buffer calculations #20991

Merged

Conversation

noaOrMlnx
Copy link
Collaborator

@noaOrMlnx noaOrMlnx commented Dec 2, 2024

Why I did it

Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Update lossless pool

How to verify it

Run sonic-mgmt QoS test

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@noaOrMlnx noaOrMlnx marked this pull request as ready for review December 5, 2024 09:37
{% set egress_lossless_pool_size = '158229504' %}
{% set egress_lossy_pool_size = '137779200' %}
{% set egress_lossy_pool_size = '142703616' %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaOrMlnx Are we having both lossless and lossy pool?

@liat-grozovik
Copy link
Collaborator

lossy is small according to the current needs. removing this capability i s not currently support in sonic

@liat-grozovik liat-grozovik merged commit ab16645 into sonic-net:master Dec 12, 2024
22 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 3, 2025
…et#20991)

- Why I did it
Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU.

- How I did it
Update lossless pool

- How to verify it
Run sonic-mgmt QoS test
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #21328

JibinBao added a commit to JibinBao/sonic-mgmt that referenced this pull request Jan 10, 2025
1. For spc4, there is only lossy buffer, so the buffer for lossless buffer will be taken by lossy buffer, if the packet size is too small, the packet number sent to occupy the shared buffer will increase a lot, so it will lead that descriptor will be exhausted, so update testQosSaiPgSharedWatermark, testQosSaiQSharedWatermark and testQosSaiLossyQueue accordingly.
2. Remove the test config of scheduler.block_data_plane, otherwise it might rise yang validation error when do config reload
3. list the relevant Prs:
   sonic-net/sonic-buildimage#20992
   sonic-net/sonic-buildimage#21056
   sonic-net/sonic-buildimage#20991
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Jan 15, 2025
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
…et#20991)

- Why I did it
Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU.

- How I did it
Update lossless pool

- How to verify it
Run sonic-mgmt QoS test
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21499

ayurkiv-nvda pushed a commit to ayurkiv-nvda/sonic-buildimage that referenced this pull request Jan 22, 2025
tshalvi pushed a commit to tshalvi/sonic-buildimage that referenced this pull request Jan 23, 2025
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jan 27, 2025
mssonicbld added a commit that referenced this pull request Jan 29, 2025
…#21328)

- Why I did it
Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU.

- How I did it
Update lossless pool

- How to verify it
Run sonic-mgmt QoS test
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Jan 29, 2025
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants