-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Update Mellanox-SN5600-C256S1 buffer calculations #20991
Merged
liat-grozovik
merged 1 commit into
sonic-net:master
from
noaOrMlnx:SN5600-C256S1-buffer-updates
Dec 12, 2024
Merged
[Mellanox] Update Mellanox-SN5600-C256S1 buffer calculations #20991
liat-grozovik
merged 1 commit into
sonic-net:master
from
noaOrMlnx:SN5600-C256S1-buffer-updates
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprital
approved these changes
Dec 2, 2024
kperumalbfn
reviewed
Dec 10, 2024
{% set egress_lossless_pool_size = '158229504' %} | ||
{% set egress_lossy_pool_size = '137779200' %} | ||
{% set egress_lossy_pool_size = '142703616' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaOrMlnx Are we having both lossless and lossy pool?
liat-grozovik
approved these changes
Dec 12, 2024
lossy is small according to the current needs. removing this capability i s not currently support in sonic |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jan 3, 2025
…et#20991) - Why I did it Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU. - How I did it Update lossless pool - How to verify it Run sonic-mgmt QoS test
Cherry-pick PR to 202405: #21328 |
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Jan 10, 2025
1. For spc4, there is only lossy buffer, so the buffer for lossless buffer will be taken by lossy buffer, if the packet size is too small, the packet number sent to occupy the shared buffer will increase a lot, so it will lead that descriptor will be exhausted, so update testQosSaiPgSharedWatermark, testQosSaiQSharedWatermark and testQosSaiLossyQueue accordingly. 2. Remove the test config of scheduler.block_data_plane, otherwise it might rise yang validation error when do config reload 3. list the relevant Prs: sonic-net/sonic-buildimage#20992 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#20991
12 tasks
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jan 15, 2025
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…et#20991) - Why I did it Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU. - How I did it Update lossless pool - How to verify it Run sonic-mgmt QoS test
12 tasks
Cherry-pick PR to 202411: #21499 |
ayurkiv-nvda
pushed a commit
to ayurkiv-nvda/sonic-buildimage
that referenced
this pull request
Jan 22, 2025
tshalvi
pushed a commit
to tshalvi/sonic-buildimage
that referenced
this pull request
Jan 23, 2025
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jan 27, 2025
mssonicbld
added a commit
that referenced
this pull request
Jan 29, 2025
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jan 29, 2025
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Update buffer calculations for Mellanox-SN5600-C256S1 HwSKU.
Work item tracking
How I did it
Update lossless pool
How to verify it
Run sonic-mgmt QoS test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)