Update qos sai due to no lossless pg for some platforms #16440
+93
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-mgmt |
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JibinBao
changed the title
nhe-NV
approved these changes
Jan 10, 2025
|
/azp run |
|
Pull request contains merge conflicts. |
nhe-NV
added
Request for msft-202412 Branch
and removed
Request for 202411 branch
labels
1. For spc4, there is only lossy buffer, so the buffer for lossless buffer will be taken by lossy buffer, if the packet size is too small, the packet number sent to occupy the shared buffer will increase a lot, so it will lead that descriptor will be exhausted, so update testQosSaiPgSharedWatermark, testQosSaiQSharedWatermark and testQosSaiLossyQueue accordingly. 2. Remove the test config of scheduler.block_data_plane, otherwise it might rise yang validation error when do config reload 3. list the relevant Prs: sonic-net/sonic-buildimage#20992 sonic-net/sonic-buildimage#21056 sonic-net/sonic-buildimage#20991
1. When there is no lossless buffer, return a dump buffer lossless pg profile 2. Skip tests related to lossless buffer case dynamically
1. Update qos sai lossy tests because all lossless queues has changed as lossy queues 2. Skip fixture reaseAllports for mellanox device, because after qos test is finished, the teardown will do config reload, it will restore the config of ports, we don't need this fixture before running tests. Also it can save 2 minutes 3. Relevant PRs: sonic-net/sonic-buildimage#21427, sonic-net/sonic-buildimage#21056
JibinBao
force-pushed
the
qos_no_pg_lossless
branch
from
3cd040a to
abc7410
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
[Mellanox] Update buffer calculations for Mellanox-SN5600-C224O8 SKU sonic-buildimage#20992
[Mellanox] Add x86_64-nvidia_sn5610n-r0 new platform and SKUs sonic-buildimage#21056
[Mellanox] Update Mellanox-SN5600-C256S1 buffer calculations sonic-buildimage#20991
[Mellanox] Add x86_64-nvidia_sn5610n-r0 new platform and SKUs sonic-buildimage#21056
[Mellanox] Update Mellanox-SN5600-C256S1, Mellanox-SN5600-C224O8 buffers and DSCP mapping sonic-buildimage#21427
[Mellanox] Add x86_64-nvidia_sn5610n-r0 new platform and SKUs sonic-buildimage#21056
[Mellanox] Update DSCP mapping for SN5600, SN5610 SKUs sonic-buildimage#21762
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
update the qos sai test for no pg lossless buffer platform
How did you do it?
update for lossy case and skip test relatd to pg buffer lossless
How did you verify/test it?
Run qos sai test on platform without pg lossless buffer plaform
Any platform specific information?
sn5600 and sn5610
Supported testbed topology if it's a new test case?
Documentation