[updategraph] Use empty configuration when DHCP graphurl option is missing #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
approved these changes
Oct 29, 2018
jleveque
approved these changes
Oct 29, 2018
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Apr 2, 2022
13ccaba0 Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2185) Signed-off-by: Stephen Sun <stephens@nvidia.com>
stepanblyschak
added a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Apr 4, 2022
``` 323dc34 [neighsyncd] increase neighsyncd timeout (sonic-net#2209) 7f99941 Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197) f3a0feb [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191) 13ccaba Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2185) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Apr 4, 2022
323dc34 [neighsyncd] increase neighsyncd timeout (sonic-net#2209) 7f99941 Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197) f3a0feb [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191) 13ccaba Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2185) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
6 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Apr 6, 2022
``` 323dc34 [neighsyncd] increase neighsyncd timeout (#2209) 7f99941 Remove redundant and problematic code to skip "pool" field in buffer profile handling (#2197) f3a0feb [Vxlanmgr] vnet netdev cleanup during config reload fix (#2191) 13ccaba Fix issue: sometimes PFC WD unable to create zero buffer pool (#2185) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
As we no longer use default minigraph now, change the behavior of updategraph service when DHCP server returns no graphurl option from using default minigraph to generate empty configuration.
- How I did it
dhclient plugin now write 'N/A' instead of 'default' to /tmp/dhcp_graph_url file when no graphurl option is indicated.