[teamd service] teamd service should start after syncd #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
jleveque
reviewed
Apr 1, 2019
| @@ -2,6 +2,7 @@ | |||
| Description=TEAMD container | |||
| Requires=updategraph.service | |||
| After=updategraph.service | |||
| After=syncd.service | |||
There was a problem hiding this comment.
FYI, you can combine them into one line, i.e., After=updategraph.service syncd.service.
|
The change looks good to me, but I'm not sure whether it could guarantee this: "teamd requires netdevs created by syncd". Having syncd started before teamd doesn't mean all netdev would be ready when teamd nees them. |
|
No, the change doesn't guarantee netdev being created. I just want to state all the dependencies I know. |
jleveque
approved these changes
Apr 1, 2019
Ok, putting the statement here make people think that the change also addresses that issue. |
jipanyang
approved these changes
Apr 1, 2019
|
how is this related this PR? |
yxieca
added a commit
that referenced
this pull request
Apr 1, 2019
* [teamd service] teamd service should start after syncd Signed-off-by: Ying Xie <ying.xie@microsoft.com> * combine after lines
yxieca
added a commit
that referenced
this pull request
Apr 3, 2019
yxieca
added a commit
that referenced
this pull request
Apr 4, 2019
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
* [teamd service] teamd service should start after syncd Signed-off-by: Ying Xie <ying.xie@microsoft.com> * combine after lines
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…-net#2724)" (sonic-net#2733) This reverts commit 0d1efb1.
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
* [teamd service] teamd service should start after syncd Signed-off-by: Ying Xie <ying.xie@microsoft.com> * combine after lines
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…-net#2724)" (sonic-net#2733) This reverts commit 0d1efb1.
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
* [teamd service] teamd service should start after syncd Signed-off-by: Ying Xie <ying.xie@microsoft.com> * combine after lines
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…-net#2724)" (sonic-net#2733) This reverts commit 0d1efb1.
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Mar 10, 2023
Update sonic-utilities submodule pointer to include the following: * 6f05f7ed [202205] Remove timer from FAST_REBOOT STATE_DB entry and use finalizer ([sonic-net#2724](sonic-net/sonic-utilities#2724)) Signed-off-by: dprital <drorp@nvidia.com>
prsunny
added a commit
that referenced
this pull request
Apr 8, 2023
Update swss commits: c161027 - 2023-04-07 : [202012] overlay_dmac change in Vnet configuration. (#2724) [siqbal1986] 50be4e3 - 2023-04-05 : [202012][mux]: Implement rollback for failed mux switchovers (#2716) [Lawrence Lee] 637e4c7 - 2023-03-30 : [202012] Fix orchagent missing request when logrotate happens (#2718) [Prince Sunny]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How to verify it
Have tested this change with recent continuous warm reboot tests, and some nightly tests.