[202205] Remove timer from FAST_REBOOT STATE_DB entry and use finalizer #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2023
Merged
vaibhavhd
reviewed
Mar 9, 2023
tests/db_migrator_input/config_db/reclaiming-buffer-warmreboot-expected.json
Show resolved
Hide resolved
tests/db_migrator_input/config_db/reclaiming-buffer-warmreboot-expected.json
Show resolved
Hide resolved
arfeigin
changed the title
arfeigin
changed the title
vaibhavhd
approved these changes
Mar 9, 2023
vaibhavhd
pushed a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Mar 10, 2023
Dedicated PR for 202205 branch similar to #1213 as part of fast-reboot finalizer implementation. Update syncd_init_common to check if fast-reboot is enabled according to the new value for FAST_REBOOT entry in STATE_DB. This PR should come along with the following PRs: sonic-net/sonic-utilities#2724 sonic-net/sonic-platform-daemons#343 sonic-net/sonic-buildimage#14143 This set of PRs solves the issue sonic-net/sonic-buildimage#13251
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Mar 10, 2023
Update sonic-utilities submodule pointer to include the following: * 6f05f7ed [202205] Remove timer from FAST_REBOOT STATE_DB entry and use finalizer ([sonic-net#2724](sonic-net/sonic-utilities#2724)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
vaibhavhd
pushed a commit
that referenced
this pull request
Mar 14, 2023
Fix DB migrator logic for migrating fast-reboot table, fixing #2724 db_migrator. How I did it Checking if fast-reboot table exists in DB. How to verify it Verified manually, migrating after fast-reboot and after cold/warm reboot.
vaibhavhd
pushed a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
Mar 16, 2023
This PR is similar to #335, dedicated to 202205 branch. Update xcvrd to check if fast-reboot is enabled according to the new value for FAST_REBOOT entry in STATE_DB. This PR should come along with the following PRs: sonic-net/sonic-buildimage#14143 sonic-net/sonic-sairedis#1217 sonic-net/sonic-utilities#2724 This set of PRs solves the issue sonic-net/sonic-buildimage#13251 Description Update xcvrd to check the updated form of fast-reboot entry in state-db as it was changed. Motivation and Context Introducing fast-reboot finalizer on top of warmboot-finalizer, fast-reboot entry in STATE_DB is now changed from "1"/None to "enable: true/false". How Has This Been Tested? Existing tests, and fast-reboot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedicated PR for 202205 branch similar to #2621 as part of fast-reboot finalizer implementation.
This should come along with sonic-buildimage PR implementing fast-reboot finalizing logic in finalize-warmboot script and other submodules PRs utilizing the change.
This PR should come along with the following PRs as well:
sonic-net/sonic-sairedis#1217
sonic-net/sonic-platform-daemons#343
sonic-net/sonic-buildimage#14143
This set of PRs solves the issue sonic-net/sonic-buildimage#13251
What I did
Remove the timer used to clear fast-reboot entry from state-db, instead it will be cleared by fast-reboot finalize function implemented inside finalize-warmboot script (which will be invoked since fast-reboot is using warm-reboot infrastructure).
As well instead of having "1" as the value for fast-reboot entry in state-db and deleting it when done it is now modified to set enable/disable according to the context.
As well all scripts reading this entry should be modified to the new value options.
How I did it
Removed the timer usage in the fast-reboot script and adding fast-reboot finalize logic to warm-reboot in the linked PR.
Use "enable: true/false" instead of "1" as the entry value.
How to verify it
Run fast-reboot and check that the state-db entry for fast-reboot is being deleted after finalizing fast-reboot and not by an expiring timer.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)