Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hostcfgd] Default value of fallthrough for authentication set to be False. #2746

Merged
merged 6 commits into from
Apr 5, 2019

Commits on Mar 15, 2019

  1. Install ipaddress python package that has deprecated current ipaddr. …

    …ipaddress has backport to python2.7
    renukamanavalan committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    a1c3c06 View commit details
    Browse the repository at this point in the history
  2. Install python ipaddress module as required by route_check.py sonic u…

    …tility. BTW, ipaddress deprecates ipaddr and ipaddress has python2 backport
    renukamanavalan committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    c701194 View commit details
    Browse the repository at this point in the history
  3. Revert the old chaneg per review comments.

    Signed-off-by: Renuka Manavalan <remanava@microsoft.com>
    renukamanavalan committed Mar 15, 2019
    Configuration menu
    Copy the full SHA
    3906da0 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. Configuration menu
    Copy the full SHA
    e73f86d View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Merge remote-tracking branch 'upstream/master'

    Sync with upstream
    renukamanavalan committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    e65d9c5 View commit details
    Browse the repository at this point in the history
  2. [hostcfgd] -- Fix the default for failthrough as false.

    This implies that by default, if TACACS is configured properly and it reported auth_err, then don't try fail through to traditional unix authentication through /etc/passwd.
    
    If this failthrough is intended, make it explicit through "sudo config aaa authentication failthrough enable"
    
    Removed an unused variable "aaa.fallback"
    
    Tested manually. Note the presence of 'auth_err=die' in all cases except when failthrough is explicitly enabled.
    
    admin@str-s6000-acs-13:~$ sudo config aaa authentication failthrough default; date
    Wed Apr  3 23:05:18 UTC 2019
    admin@str-s6000-acs-13:~$ ls -lrt /etc/pam.d/common-auth-sonic ; grep 123 /etc/pam.d/common-auth-sonic
    -rw-r--r-- 1 root root 1316 Apr  3 23:05 /etc/pam.d/common-auth-sonic
    auth    [success=done new_authtok_reqd=done default=ignore auth_err=die]        pam_tacplus.so server=100.127.20.22:49 secret=testing123 login=login timeout=5 try_first_pass
    auth    [success=done new_authtok_reqd=done default=ignore auth_err=die]        pam_tacplus.so server=100.127.20.21:49 secret=testing123 login=login timeout=5 try_first_pass
    
    admin@str-s6000-acs-13:~$ sudo config aaa authentication failthrough enable; date ; h4 "AAA|authentication"
    Wed Apr  3 23:06:37 UTC 2019
    admin@str-s6000-acs-13:~$ ls -lrt /etc/pam.d/common-auth-sonic ; grep 123 /etc/pam.d/common-auth-sonic
    -rw-r--r-- 1 root root 1294 Apr  3 23:06 /etc/pam.d/common-auth-sonic
    auth    [success=done new_authtok_reqd=done default=ignore]     pam_tacplus.so server=100.127.20.22:49 secret=testing123 login=login timeout=5 try_first_pass
    auth    [success=done new_authtok_reqd=done default=ignore]     pam_tacplus.so server=100.127.20.21:49 secret=testing123 login=login timeout=5 try_first_pass
    
    admin@str-s6000-acs-13:~$ sudo config aaa authentication failthrough disable; date ; h4 "AAA|authentication"
    Wed Apr  3 23:07:09 UTC 2019
    admin@str-s6000-acs-13:~$ ls -lrt /etc/pam.d/common-auth-sonic ; grep 123 /etc/pam.d/common-auth-sonic
    -rw-r--r-- 1 root root 1321 Apr  3 23:07 /etc/pam.d/common-auth-sonic
    auth    [success=done new_authtok_reqd=done default=ignore auth_err=die]        pam_tacplus.so server=100.127.20.22:49 secret=testing123 login=login timeout=5 try_first_pass
    auth    [success=done new_authtok_reqd=done default=ignore auth_err=die]        pam_tacplus.so server=100.127.20.21:49 secret=testing123 login=login timeout=5 try_first_pass
    renukamanavalan committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    6d7ecc4 View commit details
    Browse the repository at this point in the history