Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hostcfgd] Default value of fallthrough for authentication set to be False. #2746

Merged
merged 6 commits into from
Apr 5, 2019
Merged

[hostcfgd] Default value of fallthrough for authentication set to be False. #2746

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1c3c06
Install ipaddress python package that has deprecated current ipaddr. …
renukamanavalan Mar 15, 2019
c701194
Install python ipaddress module as required by route_check.py sonic u…
renukamanavalan Mar 15, 2019
3906da0
Revert the old chaneg per review comments.
renukamanavalan Mar 15, 2019
e73f86d
Merge remote-tracking branch 'upstream/master'
renukamanavalan Apr 1, 2019
e65d9c5
Merge remote-tracking branch 'upstream/master'
renukamanavalan Apr 3, 2019
6d7ecc4
[hostcfgd] -- Fix the default for failthrough as false.
renukamanavalan Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions files/image_config/hostcfgd/hostcfgd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ class AaaCfg(object):
def __init__(self):
self.auth_default = {
'login': 'local',
'failthrough': True,
'fallback': True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change fallback as well? is fallback same as failthrough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
fallback is an unused variable. Just house cleaning.

}
self.tacplus_global_default = {
'auth_type': TACPLUS_SERVER_AUTH_TYPE_DEFAULT,
Expand Down