[Mellanox] mlnx-sfpd init flow enhancement #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. wait for 5 seconds * 30 times, 150 seconds totally. use constant wait time for each retry. 2. use try/except structure so that error can be handled in a graceful way
… sure SDK is fully up.
|
Retest this please |
qiluo-msft
previously approved these changes
Aug 7, 2019
qiluo-msft
reviewed
Aug 7, 2019
|
Yes. After warm-reboot the file exists.
|
I mean after warm-reboot and before SDK start, is the old file exist? If yes, mlnx-sfpd may think SDK ready but actually not ready. |
|
I got your point.
That won’t happen. That file is destroyed when SDK is going down and recreated after sdk starts.
|
qiluo-msft
approved these changes
Aug 8, 2019
|
retest this please |
yxieca
pushed a commit
that referenced
this pull request
Aug 14, 2019
* fix sfpd initialize issue * fix review comments * rephrase the output log * fix retry counter * change the retry time to 10, means set max waiting time 1024s * fix mlnx-sfpd init flow with new solution * [mlnx-sfpd] address comments 1. wait for 5 seconds * 30 times, 150 seconds totally. use constant wait time for each retry. 2. use try/except structure so that error can be handled in a graceful way * [mlnx-sfpd] wait 5 seconds after SDK_DAEMON_READY_FILE exists to make sure SDK is fully up. * [mlnx-sfpd]simplify initialization by using deinitialize on initializing failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
change the mlnx-sfpd start flow to make it more robust
- How I did it
- How to verify it
test whether mlnx-sfpd can successfully start in procedures like config reload, warm reboot.
- Description for the changelog
[Mellanox] mlnx-sfpd init flow enhancement
- A picture of a cute animal (not mandatory but encouraged)