Commit the Silverstone platform of Celestica to Azure #3474

tiantianlv · 2019-09-18T06:54:56Z

- What I did
Commit the Silverstone platform to Azure
- How I did it
Add 32x400G and 128x100G configuration for Silverstone platform
- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

update master branch

code sync

device/celestica/x86_64-cel_silverstone-r0/Silverstone-128x100/minigraph.xml

lguohan · 2019-09-19T01:56:41Z

device/celestica/x86_64-cel_silverstone-r0/Silverstone/minigraph.xml

@@ -0,0 +1,854 @@
+<DeviceMiniGraph xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="Microsoft.Search.Autopilot.Evolution">


no minigraph, use default sku, can you check the latest porting guide.

We will remove Minigraph

fixed in bf1a418.

device/celestica/x86_64-cel_silverstone-r0/minigraph.xml

zhenggen-xu · 2019-09-19T05:24:42Z

Please share the output for below CLIs:
-- show platform summary
show platform psustatus
show platform syseeprom

-- show environment

-- show interface transceiver eeprom
show interface transceiver eeprom -d
show interface transceiver lpmode
show interface transceiver presence

On each HWSKU:
show interfaces status

device/celestica/x86_64-cel_silverstone-r0/Silverstone/port_config.ini

device/celestica/x86_64-cel_silverstone-r0/Silverstone-128x100/minigraph.xml

device/celestica/x86_64-cel_silverstone-r0/led_proc_init.soc

zhenggen-xu · 2019-09-19T05:10:43Z

device/celestica/x86_64-cel_silverstone-r0/plugins/sfputil.py

+        SfpUtilBase.__init__(self)
+
+    def get_presence(self, port_num):
+


remove this blank line

remove this blank line

This blank line will be removed.

fixed in a2d7757.

device/celestica/x86_64-cel_silverstone-r0/th3-128x100G.config.bcm

platform/broadcom/one-image.mk

*These ports will be added later after BRCM SAI support SFP.

device/celestica/x86_64-cel_silverstone-r0/led_proc_init.soc

tiantianlv · 2019-09-25T09:44:47Z

HwSKU-Silverstone.log
HwSKU-Silverstone-128x100.log

The attachment is for CLI command log.

zhenggen-xu · 2019-09-25T17:27:39Z

-- "show environment" output does not seem to be correct. We should get the fan speed, sensor temperature etc. I assume that is probably from BMC, which means we need someway to get it from there?

-- We need understand why the "show interface transceiver eeprom -d" is failing.

tiantianlv · 2019-09-26T02:53:24Z

About "show environment", I will check with plarform/BMC engineer.
About "show interface transceiver eeprom -d", it seems the issue related with branch, it will be failed in master branch, but it will success in 201811 branch, please check the new attachment.

Anyway, We will check it.
Thanks,
testlog_201811.txt

svc-acs · 2019-10-08T12:03:09Z

Build finished. No test results found.

zhenggen-xu · 2019-10-09T18:54:14Z

A note, "show environment" issue will be addressed in a different PR. This PR is approved itself.

…atically (#20573) #### Why I did it src/sonic-utilities ``` * 32e6de7f - (HEAD -> master, origin/master, origin/HEAD) Update DB migrator script to next branch 202505 (#3664) (3 days ago) [Kumaresh Perumal] * 8d00aba7 - (origin/test_202411_20, origin/test_202411_100, origin/kperumal_202411, origin/202411) Fix save_file command in generate_dump (#3647) (4 days ago) [DavidZagury] * 038aaa5f - Revert "Speed up route_check script" (#3653) (4 days ago) [xwjiang-ms] * 032a0e03 - [config]Restrict YANG validation to Golden Config (#3656) (4 days ago) [jingwenxie] * 47b79bea - Update gcu_field_operation_validators.conf.json with Arista-7260CX3-D108C10 (#3650) (4 days ago) [Dev Ojha] * 845f46ef - Update PR checker pipeline to point to bookworm (#3651) (4 days ago) [bingwang-ms] * 28e645f4 - [show_tech] Filter out a list of commands in generate_dump script which are not applicable to Supervisor (#3646) (5 days ago) [Marty Y. Lok] * b767cb86 - [cisco|express-boot]: Add support for cisco express boot in sonic-utilities (#3056) (6 days ago) [jhli-cisco] * f6b9912c - Fix show command column change issue (#3645) (8 days ago) [Feng-msft] * 9cd6c8de - Debug dump utility dash objects update (#3387) (8 days ago) [Gagan Punathil Ellath] * f705c456 - Validate interface name length in CLI (#3580) (8 days ago) [Stepan Blyshchak] * 3d78cb16 - [Mellanox] Update the save_file command in generate_dump to handle folders (#3631) (13 days ago) [DavidZagury] * 5086a43b - Fix counterpoll show for ENI Counters (#3618) (13 days ago) [Vivek] * 70f81397 - Extra delay between running firmware and updating firmware version (#3610) (2 weeks ago) [Stephen Sun] * 636f7f1d - Add port FEC BER show changes (#3607) (2 weeks ago) [vincentpcng] * 5e60031b - Supports FRR-VRRP configuration (#2949) (3 weeks ago) [Philo] * 9bd37dc6 - [ARM64][Warm-Reboot]: Get boot arguments from uboot environment (#3613) (3 weeks ago) [Parthiv Shah] * 171b16c2 - platform/innovium renaming to platform/marvell-teralynx (#3474) (3 weeks ago) [krismarvell] * 2cbfcc91 - [Mellanox] Add Mellanox-SN5600-C224O8 to gcu_field.json (#3612) (4 weeks ago) [noaOrMlnx] * a8f7bde0 - PVST Feature commit (#3567) (4 weeks ago) [Divya Kumaran Chandralekha] * 0e188076 - Refresh dump file modify timestamp before cleanup call (#3595) (4 weeks ago) [anamehra] * 8f3c5ef5 - [warm-reboot] Add support to pass extra kernel cmdline parameters (#3192) (4 weeks ago) [Pavan Naregundi] * 96774477 - Run yang validation in db migrator (#3102) (4 weeks ago) [ganglv] * 9708f52b - [Mellanox] Update C256X1 SKU to be C256S1 in gcu_field.json (#3611) (4 weeks ago) [noaOrMlnx] * 093ed4aa - [SPM] Add logic to disable the feature before stopping it and enabling it before starting (#3344) (4 weeks ago) [Vadym Hlushko] * 7d013dff - Fix slash in path. (#3573) (5 weeks ago) [Xincun Li] * 0af4386e - Consolidate the get running config way. (#3585) (5 weeks ago) [Xincun Li] * 964b4895 - Fix for integer overflow of counter value if its too large (#3596) (5 weeks ago) [harjotsinghpawra] * 3354d08a - [config] Bypass standard input for reload (#3597) (5 weeks ago) [jingwenxie] * 7cbcfda5 - Speed up route_check script (#3544) (5 weeks ago) [Deepak Singhal] * 329fc223 - Add support of the pensando-dpu platform to generate-dump utility. (#3557) (6 weeks ago) [BHUKYA SIDDHU] * 0ae2ec1e - Add CLI for bmp configdb entity Enable/Disable (#3286) (6 weeks ago) [Feng-msft] * 5b37ee6c - Vnet_route_check TCP socket for DB connection. (#3578) (6 weeks ago) [siqbal1986] * d64a90a0 - Adds logic to get default disk and check disk type (#3399) (6 weeks ago) [Ashwin Srinivasan] * b2b97340 - [Banner] Added CLI commands to configure Banner and display current configuration (#3021) (6 weeks ago) [Sviatoslav Boichuk] * d0aa94a1 - Revert "Record and warn tables which not covered by YANG (#3583)" (#3588) (7 weeks ago) [jingwenxie] * aeda86a1 - Record and warn tables which not covered by YANG (#3583) (7 weeks ago) [jingwenxie] * dd34d7c4 - Revert "Skip default lanes dup check (#3489)" (#3572) (7 weeks ago) [Xincun Li] * 6c8007fa - [Mellanox]Remove deprecated sdk sniffer cli and collect sdk dump in show techsupport (#3491) (7 weeks ago) [Yuanzhe] * 89bb87ad - Add YANG validation for config reload if file is given (#3576) (7 weeks ago) [jingwenxie] ``` #### How I did it #### How to verify it #### Description for the changelog

…atically (sonic-net#20573) #### Why I did it src/sonic-utilities ``` * 32e6de7f - (HEAD -> master, origin/master, origin/HEAD) Update DB migrator script to next branch 202505 (sonic-net#3664) (3 days ago) [Kumaresh Perumal] * 8d00aba7 - (origin/test_202411_20, origin/test_202411_100, origin/kperumal_202411, origin/202411) Fix save_file command in generate_dump (sonic-net#3647) (4 days ago) [DavidZagury] * 038aaa5f - Revert "Speed up route_check script" (sonic-net#3653) (4 days ago) [xwjiang-ms] * 032a0e03 - [config]Restrict YANG validation to Golden Config (sonic-net#3656) (4 days ago) [jingwenxie] * 47b79bea - Update gcu_field_operation_validators.conf.json with Arista-7260CX3-D108C10 (sonic-net#3650) (4 days ago) [Dev Ojha] * 845f46ef - Update PR checker pipeline to point to bookworm (sonic-net#3651) (4 days ago) [bingwang-ms] * 28e645f4 - [show_tech] Filter out a list of commands in generate_dump script which are not applicable to Supervisor (sonic-net#3646) (5 days ago) [Marty Y. Lok] * b767cb86 - [cisco|express-boot]: Add support for cisco express boot in sonic-utilities (sonic-net#3056) (6 days ago) [jhli-cisco] * f6b9912c - Fix show command column change issue (sonic-net#3645) (8 days ago) [Feng-msft] * 9cd6c8de - Debug dump utility dash objects update (sonic-net#3387) (8 days ago) [Gagan Punathil Ellath] * f705c456 - Validate interface name length in CLI (sonic-net#3580) (8 days ago) [Stepan Blyshchak] * 3d78cb16 - [Mellanox] Update the save_file command in generate_dump to handle folders (sonic-net#3631) (13 days ago) [DavidZagury] * 5086a43b - Fix counterpoll show for ENI Counters (sonic-net#3618) (13 days ago) [Vivek] * 70f81397 - Extra delay between running firmware and updating firmware version (sonic-net#3610) (2 weeks ago) [Stephen Sun] * 636f7f1d - Add port FEC BER show changes (sonic-net#3607) (2 weeks ago) [vincentpcng] * 5e60031b - Supports FRR-VRRP configuration (sonic-net#2949) (3 weeks ago) [Philo] * 9bd37dc6 - [ARM64][Warm-Reboot]: Get boot arguments from uboot environment (sonic-net#3613) (3 weeks ago) [Parthiv Shah] * 171b16c2 - platform/innovium renaming to platform/marvell-teralynx (sonic-net#3474) (3 weeks ago) [krismarvell] * 2cbfcc91 - [Mellanox] Add Mellanox-SN5600-C224O8 to gcu_field.json (sonic-net#3612) (4 weeks ago) [noaOrMlnx] * a8f7bde0 - PVST Feature commit (sonic-net#3567) (4 weeks ago) [Divya Kumaran Chandralekha] * 0e188076 - Refresh dump file modify timestamp before cleanup call (sonic-net#3595) (4 weeks ago) [anamehra] * 8f3c5ef5 - [warm-reboot] Add support to pass extra kernel cmdline parameters (sonic-net#3192) (4 weeks ago) [Pavan Naregundi] * 96774477 - Run yang validation in db migrator (sonic-net#3102) (4 weeks ago) [ganglv] * 9708f52b - [Mellanox] Update C256X1 SKU to be C256S1 in gcu_field.json (sonic-net#3611) (4 weeks ago) [noaOrMlnx] * 093ed4aa - [SPM] Add logic to disable the feature before stopping it and enabling it before starting (sonic-net#3344) (4 weeks ago) [Vadym Hlushko] * 7d013dff - Fix slash in path. (sonic-net#3573) (5 weeks ago) [Xincun Li] * 0af4386e - Consolidate the get running config way. (sonic-net#3585) (5 weeks ago) [Xincun Li] * 964b4895 - Fix for integer overflow of counter value if its too large (sonic-net#3596) (5 weeks ago) [harjotsinghpawra] * 3354d08a - [config] Bypass standard input for reload (sonic-net#3597) (5 weeks ago) [jingwenxie] * 7cbcfda5 - Speed up route_check script (sonic-net#3544) (5 weeks ago) [Deepak Singhal] * 329fc223 - Add support of the pensando-dpu platform to generate-dump utility. (sonic-net#3557) (6 weeks ago) [BHUKYA SIDDHU] * 0ae2ec1e - Add CLI for bmp configdb entity Enable/Disable (sonic-net#3286) (6 weeks ago) [Feng-msft] * 5b37ee6c - Vnet_route_check TCP socket for DB connection. (sonic-net#3578) (6 weeks ago) [siqbal1986] * d64a90a0 - Adds logic to get default disk and check disk type (sonic-net#3399) (6 weeks ago) [Ashwin Srinivasan] * b2b97340 - [Banner] Added CLI commands to configure Banner and display current configuration (sonic-net#3021) (6 weeks ago) [Sviatoslav Boichuk] * d0aa94a1 - Revert "Record and warn tables which not covered by YANG (sonic-net#3583)" (sonic-net#3588) (7 weeks ago) [jingwenxie] * aeda86a1 - Record and warn tables which not covered by YANG (sonic-net#3583) (7 weeks ago) [jingwenxie] * dd34d7c4 - Revert "Skip default lanes dup check (sonic-net#3489)" (sonic-net#3572) (7 weeks ago) [Xincun Li] * 6c8007fa - [Mellanox]Remove deprecated sdk sniffer cli and collect sdk dump in show techsupport (sonic-net#3491) (7 weeks ago) [Yuanzhe] * 89bb87ad - Add YANG validation for config reload if file is given (sonic-net#3576) (7 weeks ago) [jingwenxie] ``` #### How I did it #### How to verify it #### Description for the changelog

bbinxie and others added 9 commits August 23, 2019 17:20

Merge pull request #107 from Azure/master

a65721c

update master branch

Merge pull request #113 from Azure/master

b4a4b26

code sync

[platform/broadcom] Add Celestica silverstone platform module.

690040d

[device/celestica] Add silverstone device plugins and configs

3e04157

Add switch configuration Silverstone!

e855f0e

add port led fireware of PAM4!

f6c6656

Add 128x100 configuration!

5bed0eb

Delete serdes copper parameter!

24122e9

[device/celestica] Fix incorrect index in Silverstone 128x100G port cfg

944cfb7

tiantianlv changed the title ~~Master dev~~ Commit the Silverstone platform of Celestica to Azure Sep 18, 2019

jleveque added Enhancement ➕ Platform: Celestica labels Sep 18, 2019

lguohan reviewed Sep 19, 2019

View reviewed changes

device/celestica/x86_64-cel_silverstone-r0/Silverstone-128x100/minigraph.xml Outdated Show resolved Hide resolved

lguohan reviewed Sep 19, 2019

View reviewed changes

device/celestica/x86_64-cel_silverstone-r0/minigraph.xml Outdated Show resolved Hide resolved

zhenggen-xu suggested changes Sep 19, 2019

View reviewed changes

pphuchar added 6 commits September 24, 2019 16:47

[platform/broadcom] Remove unrelated platform other than Silverstone

eccb788

[device/celestica] Silverstone remove minigraphs

bf1a418

[device/celestica] Silverstone update sai.profile to use hwsku path

2e3ce7e

[device/celestica] Silverstone format sfputil codes

a2d7757

[device/celestica] Add speed column to Silverstone 32x400G port conf

cc0cb4c

[device/celestica] Silverstone disable 10G ports prevent orchagent crash

20a2fed

*These ports will be added later after BRCM SAI support SFP.

zhenggen-xu suggested changes Sep 24, 2019

View reviewed changes

device/celestica/x86_64-cel_silverstone-r0/led_proc_init.soc Outdated Show resolved Hide resolved

device/celestica/x86_64-cel_silverstone-r0/led_proc_init.soc Outdated Show resolved Hide resolved

Remove LED redundancy configuration and add comments!

2294129

pphuchar added 2 commits October 8, 2019 17:36

[plugins/sfputil] update Silverstone ports to QSFP-DD type

4e5e002

[plugins/sfputil] Silverstone fix return NotImplementedError with raise

2bf1134

zhenggen-xu approved these changes Oct 9, 2019

View reviewed changes

lguohan approved these changes Oct 10, 2019

View reviewed changes

lguohan merged commit 368c4fa into sonic-net:master Oct 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commit the Silverstone platform of Celestica to Azure #3474

Commit the Silverstone platform of Celestica to Azure #3474

tiantianlv commented Sep 18, 2019

lguohan Sep 19, 2019

tiantianlv Sep 23, 2019

pphuchar Sep 24, 2019

zhenggen-xu commented Sep 19, 2019

zhenggen-xu Sep 19, 2019

pphuchar Sep 19, 2019

pphuchar Sep 24, 2019

tiantianlv commented Sep 25, 2019

zhenggen-xu commented Sep 25, 2019

tiantianlv commented Sep 26, 2019

svc-acs commented Oct 8, 2019

zhenggen-xu commented Oct 9, 2019

		@@ -0,0 +1,854 @@
		<DeviceMiniGraph xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="Microsoft.Search.Autopilot.Evolution">

Commit the Silverstone platform of Celestica to Azure #3474

Commit the Silverstone platform of Celestica to Azure #3474

Conversation

tiantianlv commented Sep 18, 2019

lguohan Sep 19, 2019

Choose a reason for hiding this comment

tiantianlv Sep 23, 2019

Choose a reason for hiding this comment

pphuchar Sep 24, 2019

Choose a reason for hiding this comment

zhenggen-xu commented Sep 19, 2019

zhenggen-xu Sep 19, 2019

Choose a reason for hiding this comment

pphuchar Sep 19, 2019

Choose a reason for hiding this comment

pphuchar Sep 24, 2019

Choose a reason for hiding this comment

tiantianlv commented Sep 25, 2019

zhenggen-xu commented Sep 25, 2019

tiantianlv commented Sep 26, 2019

svc-acs commented Oct 8, 2019

zhenggen-xu commented Oct 9, 2019