Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save fast-reboot state into the db #3741

Merged
merged 8 commits into from
Dec 4, 2019

Conversation

pavel-shirshov
Copy link
Contributor

@pavel-shirshov pavel-shirshov commented Nov 12, 2019

Fixes #3697

- What I did

  1. Put a flag for fast-reboot to the db
  2. Using this flag in other part of SONiC to start in Fast-reboot mode

- How I did it

  1. Using EXPIRE feature of db
  2. If we reload a config, the state in the db will be removed.

- How to verify it
Build your DUT and test on your dut.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@yxieca
Copy link
Contributor

yxieca commented Nov 12, 2019

Looks generally good to me. I am wondering what is your plan of using the EX 180 information?

We might want to run a test fast-reboot -> make sure it is executed as fast-reboot. Then restart swss, make sure it is a cold restart.

@pavel-shirshov
Copy link
Contributor Author

@yxieca This is instruction to redis to remove the key in 180 seconds.

@yxieca
Copy link
Contributor

yxieca commented Nov 12, 2019

I see. Interesting. Do we need this expiry? swss restart should clear the db including this key, right?

@pavel-shirshov
Copy link
Contributor Author

@yxieca But if we restart bgpd only it will be always fast-reboot start of bgpd

@yxieca
Copy link
Contributor

yxieca commented Nov 12, 2019

Good point!

@pavel-shirshov
Copy link
Contributor Author

retest broadcom please

@pavel-shirshov
Copy link
Contributor Author

retest vsimage please

1 similar comment
@yxieca
Copy link
Contributor

yxieca commented Nov 17, 2019

retest vsimage please

@yxieca
Copy link
Contributor

yxieca commented Nov 17, 2019

retest broadcom please

@pavel-shirshov
Copy link
Contributor Author

retest vs please

@pavel-shirshov
Copy link
Contributor Author

retest broadcom please

@pavel-shirshov
Copy link
Contributor Author

retest vs please

@pavel-shirshov pavel-shirshov marked this pull request as ready for review November 20, 2019 23:50
@pavel-shirshov
Copy link
Contributor Author

retest vsimage please

2 similar comments
@pavel-shirshov
Copy link
Contributor Author

retest vsimage please

@pavel-shirshov
Copy link
Contributor Author

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Dec 2, 2019

can you rebase and resolve conflict?

@lguohan
Copy link
Collaborator

lguohan commented Dec 4, 2019

for master we are using frr, so sonic-frr init should be modified. I will let pavel fix that.

@lguohan lguohan merged commit 1848fb2 into sonic-net:master Dec 4, 2019
@pavel-shirshov pavel-shirshov deleted the pavelsh/fr_state branch December 9, 2019 20:25
@yxieca
Copy link
Contributor

yxieca commented Dec 13, 2019

Separate PR was created for 201811 branch due to merge conflicts.

lguohan pushed a commit that referenced this pull request Dec 13, 2019
abdosi pushed a commit that referenced this pull request Jan 6, 2020
Put a flag for fast-reboot to the db using EXPIRE feature. Using this flag in other part of SONiC to start in Fast-reboot mode. If we reload a config, the state in the db will be removed.
dawnbeauty added a commit to dawnbeauty/sonic-utilities that referenced this pull request Jan 10, 2020
Fixes sonic-net/sonic-buildimage#4006

1. save fast-reboot state into the db(aligned with sonic-net/sonic-buildimage#3741)
2. `sonic-buildimage/files/scripts/syncd.sh` could detect the FAST reboot type by the saved fast-reboot state, and request syncd to fast shutdown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boot type during config reload after fast reboot is invalid
5 participants