-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save fast-reboot state into the db #3741
Conversation
Looks generally good to me. I am wondering what is your plan of using the EX 180 information? We might want to run a test fast-reboot -> make sure it is executed as fast-reboot. Then restart swss, make sure it is a cold restart. |
@yxieca This is instruction to redis to remove the key in 180 seconds. |
I see. Interesting. Do we need this expiry? swss restart should clear the db including this key, right? |
@yxieca But if we restart bgpd only it will be always fast-reboot start of bgpd |
Good point! |
retest broadcom please |
retest vsimage please |
1 similar comment
retest vsimage please |
retest broadcom please |
retest vs please |
retest broadcom please |
retest vs please |
b4eceef
to
6b10f7f
Compare
retest vsimage please |
2 similar comments
retest vsimage please |
retest vsimage please |
can you rebase and resolve conflict? |
This reverts commit 184c1cb22541f417a6cb878838530be5337ae971.
This reverts commit 649b5346161c50ffc98589ff68d35df32ff1eb84.
83bf95b
to
7e273d5
Compare
for master we are using frr, so sonic-frr init should be modified. I will let pavel fix that. |
Separate PR was created for 201811 branch due to merge conflicts. |
Put a flag for fast-reboot to the db using EXPIRE feature. Using this flag in other part of SONiC to start in Fast-reboot mode. If we reload a config, the state in the db will be removed.
Fixes sonic-net/sonic-buildimage#4006 1. save fast-reboot state into the db(aligned with sonic-net/sonic-buildimage#3741) 2. `sonic-buildimage/files/scripts/syncd.sh` could detect the FAST reboot type by the saved fast-reboot state, and request syncd to fast shutdown.
Fixes #3697
- What I did
- How I did it
- How to verify it
Build your DUT and test on your dut.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)