Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MultiDB] (./dockers dir) : replace redis-cli with sonic-db-cli and use new DBConnector #3923

Merged
merged 3 commits into from
Jan 22, 2020
Merged

[MultiDB] (./dockers dir) : replace redis-cli with sonic-db-cli and use new DBConnector #3923

merged 3 commits into from
Jan 22, 2020

Conversation

dzhangalibaba
Copy link
Collaborator

this commit made changes in sonic-buildimage/dockers/ directory:

  • replace redis-cli with sonic-db-cli
  • replace old DBConnector with new DBConnector
  • vs tests passed, loaded on DUT, looks good, script works fine.

Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

1 similar comment
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

@qiluo-msft FYI

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

qiluo-msft
qiluo-msft previously approved these changes Dec 18, 2019
View reviewed changes
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

1 similar comment
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@sonic-net sonic-net deleted a comment from dzhangalibaba Dec 19, 2019
@dzhangalibaba
Copy link
Collaborator Author

dzhangalibaba commented Dec 20, 2019 •
edited
Loading

retest vsimage please

8 similar comments
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Dec 27, 2019

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Dec 28, 2019

test failure. @dzhangalibaba , looks like the bgp_fact test failed, and it seems the bgpd.conf does not have all the neighbor information. Can you check?

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

4 similar comments
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

test failure. @dzhangalibaba , looks like the bgp_fact test failed, and it seems the bgpd.conf does not have all the neighbor information. Can you check?

Hi @lguohan , looks without my changes in other PRs, it failed at the same place, looks it is not my changes caused this failure. It is something else in basic test.

e.g.
https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/1964/consoleFull

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/1962/consoleFull

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/1960/consoleFull

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/1959/consoleFull

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/1957/consoleFull

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/1956/consoleFull

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/1955/consoleFull

https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/1954/

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

2 similar comments
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

6 similar comments
@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba dzhangalibaba changed the title [MultiDB] dockers : replace redis-cli with sonic-db-cli and use new DBConnector [MultiDB] DONT MERGE FOR NOW, dockers : replace redis-cli with sonic-db-cli and use new DBConnector Jan 17, 2020
@dzhangalibaba
Copy link
Collaborator Author

retest vs please

@dzhangalibaba
Copy link
Collaborator Author

retest vsimage please

@dzhangalibaba dzhangalibaba changed the title [MultiDB] DONT MERGE FOR NOW, dockers : replace redis-cli with sonic-db-cli and use new DBConnector [MultiDB] dockers : replace redis-cli with sonic-db-cli and use new DBConnector Jan 20, 2020
@dzhangalibaba dzhangalibaba changed the title [MultiDB] dockers : replace redis-cli with sonic-db-cli and use new DBConnector [MultiDB] (./dockers dirs : replace redis-cli with sonic-db-cli and use new DBConnector Jan 20, 2020
@dzhangalibaba dzhangalibaba changed the title [MultiDB] (./dockers dirs : replace redis-cli with sonic-db-cli and use new DBConnector [MultiDB] (./dockers dir) : replace redis-cli with sonic-db-cli and use new DBConnector Jan 20, 2020
@dzhangalibaba
Copy link
Collaborator Author

@qiluo-msft We can start review on this PR now

@qiluo-msft qiluo-msft requested a review from hui-ma January 21, 2020 21:44
@qiluo-msft qiluo-msft merged commit 5057ac3 into sonic-net:master Jan 22, 2020
abdosi pushed a commit that referenced this pull request Feb 4, 2020
@dzhangalibaba @abdosi
[MultiDB] (./dockers dir) : replace redis-cli with sonic-db-cli and u…
a265641 
…se new DBConnector (#3923)

* [MultiDB] (./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector

* remove unnecessary quota

* update typo
@dzhangalibaba dzhangalibaba deleted the dockers branch February 20, 2020 19:40
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
@dzhangalibaba @pphuchar
[MultiDB] (./dockers dir) : replace redis-cli with sonic-db-cli and u…
a180ff0 
…se new DBConnector (sonic-net#3923)

* [MultiDB] (./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector

* remove unnecessary quota

* update typo
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
@dzhangalibaba @tiantianlv
[MultiDB] (./dockers dir) : replace redis-cli with sonic-db-cli and u…
3cfdfc2 
…se new DBConnector (sonic-net#3923)

* [MultiDB] (./dockers dirs): replace redis-cli with sonic-db-cli and use new DBConnector

* remove unnecessary quota

* update typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@hui-ma hui-ma Awaiting requested review from hui-ma

Assignees
No one assigned
Labels
Included in 201911 Branch Request for 201911 Branch :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzhangalibaba @lguohan @qiluo-msft @abdosi