Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build]: install cmake 3.13.2 #4319

Merged
merged 2 commits into from
Mar 27, 2020
Merged

[build]: install cmake 3.13.2 #4319

merged 2 commits into from
Mar 27, 2020

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Mar 25, 2020

…-sloppy

  • debhelper requires cmake (>= 3.9)
  • cmake v13.6.3 requires libarchive13 (>= 3.3.3)
  • libarchive13 (3.4.0-2~bpo9+1) is in stretch-backports-sloppy

Signed-off-by: Guohan Lu lguohan@gmail.com

- What I did

- How I did it

- How to verify it
locally build sonic-slave-stretch docker

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator Author

lguohan commented Mar 25, 2020

retest vs please

@lguohan
Copy link
Collaborator Author

lguohan commented Mar 25, 2020

i am not sure why only vs build fails on libyang

@lguohan lguohan changed the title [build]: install cmake from backports and libarchive13 from backports… [build]: install cmake 3.13.2 Mar 27, 2020
debian stretch-backports upgraded cmake 3.16.3 breaks
the build of libyang 1.0.73

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@baxia-lan
Copy link
Contributor

A possible way to install cmake 3.13.2:

# Install cmake-3.13.2, since installing debhelper removed cmake, and cmake-3.16.1 breaks libyang build.
RUN wget -q -O cmake-linux.sh https://github.com/Kitware/CMake/releases/download/v3.13.2/cmake-3.13.2-Linux-x86_64.sh
RUN sh cmake-linux.sh -- --skip-license --prefix=/usr
RUN rm cmake-linux.sh

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan
Copy link
Collaborator Author

lguohan commented Mar 27, 2020

@baxia-lan, thanks for the suggestion. @qiluo-msft has found the pre-built binary for 3.13.2. we are fixing using this approach.

@lguohan
Copy link
Collaborator Author

lguohan commented Mar 27, 2020

retest mellanox please

@lguohan lguohan merged commit 4424826 into sonic-net:master Mar 27, 2020
@lguohan lguohan deleted the cmake branch March 27, 2020 17:49
rlhui pushed a commit that referenced this pull request Mar 30, 2020
fix #4315

download and install cmake 3.13.2 from azure storage 

latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build

Signed-off-by: Guohan Lu <lguohan@gmail.com>
taocy001 pushed a commit to CentecNetworks/sonic-buildimage that referenced this pull request Apr 7, 2020
fix sonic-net#4315

download and install cmake 3.13.2 from azure storage

latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build

Signed-off-by: Guohan Lu <lguohan@gmail.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
fix sonic-net#4315

download and install cmake 3.13.2 from azure storage 

latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build

Signed-off-by: Guohan Lu <lguohan@gmail.com>
YuriiHordynskyi pushed a commit to YuriiHordynskyi/sonic-buildimage that referenced this pull request May 18, 2020
fix sonic-net#4315

download and install cmake 3.13.2 from azure storage 

latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build

Signed-off-by: Guohan Lu <lguohan@gmail.com>
vitalivanov pushed a commit to InterfaceMasters/sonic-buildimage that referenced this pull request May 20, 2020
fix sonic-net#4315

download and install cmake 3.13.2 from azure storage 

latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build

Signed-off-by: Guohan Lu <lguohan@gmail.com>
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request May 22, 2020
fix sonic-net#4315

download and install cmake 3.13.2 from azure storage 

latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sonic-slave-stretch build failed
4 participants