FRR patches to support IPv6 Link local enhancements. #5584

AkhileshSamineni · 2020-10-10T14:37:55Z

FRR Patches:

0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch
Files modified : bgpd_network.c and bgpd/bgp_zebra.c
Fix for : Link local scope was not set while binding socket with local address causing socket errors for bgp ipv6 link local neighbors.

0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch
Files modified : staticd/static_zebra.c
Fix for : VRF interface lookup was still done in the default-vrf which was causing the interface lookup to fail. Due to this static-route pointing to link-local was not getting installed.

0011-Changes-to-send-ipv6-link-local-address-as-nexthop-to-fpmsyncd.patch
Files modified : zebra/zebra_fpm_netlink.c
Fix for : Made changes to send ipv6 address as nexthop to fpmsyncd.

Depends on:
sonic-net/sonic-utilities#1159
sonic-net/sonic-swss#1463

Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com

AkhileshSamineni · 2020-10-11T05:44:59Z

retest this please

AkhileshSamineni · 2020-10-27T11:07:52Z

retest vsimage please.

AkhileshSamineni · 2020-10-27T11:09:28Z

Retest this please.

pavel-shirshov · 2020-10-27T16:12:18Z

Hi @AkhileshSamineni

Can you please make a PR with your changes to https://github.com/FRRouting/frr ?
As soon as your change is reviewed there, we can backport your change to sonic.

Thanks

AkhileshSamineni · 2020-10-27T18:59:47Z

Hi @AkhileshSamineni

Can you please make a PR with your changes to https://github.com/FRRouting/frr ?
As soon as your change is reviewed there, we can backport your change to sonic.

Thanks

Sure @pavel-shirshov , Could you please tell me on which branch need to raise the PR, is it master or frr 7.4 branch ?

pavel-shirshov · 2020-10-28T16:12:20Z

@AkhileshSamineni master please

AkhileshSamineni · 2020-11-16T17:00:35Z

retest vsimage please.

prsunny · 2020-11-17T04:48:29Z

files/image_config/sysctl/sysctl-net.conf

@@ -32,6 +32,10 @@ net.ipv6.conf.eth0.accept_dad=0
 net.ipv6.conf.default.keep_addr_on_down=1
 net.ipv6.conf.all.keep_addr_on_down=1
 net.ipv6.conf.eth0.keep_addr_on_down=1
+net.ipv6.conf.default.disable_ipv6=1


Based on the review comment, have we agreed to enable IPv6 by default and disable based on some profile?

sonic-net/SONiC#625 (comment)

As per design change, enabled the ipv6 by default.

pavel-shirshov · 2020-11-17T19:11:21Z

Has the patches pushed into FRR master as PRs?

AkhileshSamineni · 2020-11-18T06:35:14Z

Has the patches pushed into FRR master as PRs?

@pavel-shirshov Here are the details :

0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch => PR FRRouting/frr#7434

0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch => This fix is not needed in master branch as all interface up/down/add/delete events are replaced with ifp callbacks using PR FRRouting/frr#5009, and it is merged.

0011-Changes-to-send-ipv6-link-local-address-as-nexthop-to-fpmsyncd.patch => This fix is not needed in master as already relevant below PRs are raised and merged.
BGP : Fix for nexthop as IPv4 mapped IPv6 address : FRRouting/frr#6821
Clean up the zebra's Netlink API : FRRouting/frr#6569

AkhileshSamineni · 2020-11-18T06:35:45Z

Retest this please.

arlakshm · 2021-04-06T18:47:54Z

src/sonic-frr/patch/0011-Changes-to-send-ipv6-link-local-address-as-nexthop-to-fpmsyncd.patch

@@ -0,0 +1,50 @@
+From 6a74cc3b97f405473c7500d5cd0adadba854067f Mon Sep 17 00:00:00 2001


Do we need still need this patch file, looks like we are not using it

As FRR updated to 7.5 version, not needed this patch file at all.

src/sonic-frr/patch/0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch

arlakshm · 2021-04-06T18:48:35Z

src/sonic-frr/patch/series

@@ -5,3 +5,6 @@
 0005-nexthops-compare-vrf-only-if-ip-type.patch
 0007-frr-remove-frr-log-outchannel-to-var-log-frr.log.patch
 0008-Add-support-of-bgp-l3vni-evpn.patch
+0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch
+#0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch


Can you remove them instead of commenting these lines

AkhileshSamineni · 2021-04-08T06:28:20Z

/Azurepipelines run

azure-pipelines · 2021-04-08T06:28:25Z

Commenter does not have sufficient privileges for PR 5584 in repo Azure/sonic-buildimage

AkhileshSamineni · 2021-04-08T06:31:59Z

@arlakshm Please retest it, as I don't have permission for Azurepipelines.

prsunny · 2021-04-08T21:23:28Z

/azp run

azure-pipelines · 2021-04-08T21:23:45Z

Azure Pipelines successfully started running 1 pipeline(s).

lguohan · 2021-04-14T21:21:22Z

is this patch being accepted by upstream?

0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch

AkhileshSamineni · 2021-04-15T04:14:30Z

is this patch being accepted by upstream?

0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch

Yes, it is, merged to FRR community.
FRRouting/frr#7434

…upport IPv6 Link local enchancements Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

adyeung · 2021-06-24T23:50:07Z

@lguohan Pls help merge this patch, nothing else pending on this Code PR

anshuv-mfst · 2021-07-07T23:08:18Z

@arlakshm - can you please help with merge

As per HLD - sonic-net/SONiC#625 FRR Patches: 0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch Files modified : bgpd_network.c and bgpd/bgp_zebra.c Fix for : Link local scope was not set while binding socket with local address causing socket errors for bgp ipv6 link local neighbors. 0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch Files modified : staticd/static_zebra.c Fix for : VRF interface lookup was still done in the default-vrf which was causing the interface lookup to fail. Due to this static-route pointing to link-local was not getting installed. 0011-Changes-to-send-ipv6-link-local-address-as-nexthop-to-fpmsyncd.patch Files modified : zebra/zebra_fpm_netlink.c Fix for : Made changes to send ipv6 address as nexthop to fpmsyncd. Depends on: sonic-net/sonic-utilities#1159 sonic-net/sonic-swss#1463 Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com

This was referenced Oct 10, 2020

Global and Interface commands for IPv6 Link local address enhancements sonic-net/sonic-utilities#1159

Merged

Code changes to support IPv6 Link local enhancements sonic-net/sonic-swss#1463

Merged

prsunny requested review from lguohan and pavel-shirshov October 14, 2020 21:12

prsunny reviewed Nov 17, 2020

View reviewed changes

lguohan force-pushed the master branch from 3690c1a to 512eb6b Compare December 25, 2020 18:34

AkhileshSamineni force-pushed the ipv6-link-local-changes branch from c231c92 to 5526139 Compare April 5, 2021 19:55

AkhileshSamineni changed the title ~~Setting disable ipv6 defaults for interfaces and few FRR changes to support IPv6 Link local enchancements.~~ FRR patches to support IPv6 Link local enhancements. Apr 5, 2021

arlakshm reviewed Apr 6, 2021

View reviewed changes

AkhileshSamineni added 4 commits June 7, 2021 05:34

Setting disable ipv6 defaults for interfaces and few FRR changes to s…

934aa0c

…upport IPv6 Link local enchancements Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

Splitted the single path file to 3 patch files for better tracking.

7e29215

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

Corrected the changes as per design change.

93f9ebd

Modified the sonic-frr series file.

d9f6539

Removed the patch files which are not needed.

79deaa2

AkhileshSamineni force-pushed the ipv6-link-local-changes branch from c469c90 to 79deaa2 Compare June 7, 2021 12:47

lguohan approved these changes Jun 9, 2021

View reviewed changes

arlakshm approved these changes Jun 10, 2021

View reviewed changes

rlhui merged commit a31ee03 into sonic-net:master Jul 20, 2021

prsunny added the Request for 202106 Branch label Aug 6, 2021

judyjoseph added the Included in 202106 Branch label Aug 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FRR patches to support IPv6 Link local enhancements. #5584

FRR patches to support IPv6 Link local enhancements. #5584

AkhileshSamineni commented Oct 10, 2020 •

edited

Loading

AkhileshSamineni commented Oct 11, 2020

AkhileshSamineni commented Oct 27, 2020

AkhileshSamineni commented Oct 27, 2020

pavel-shirshov commented Oct 27, 2020

AkhileshSamineni commented Oct 27, 2020

pavel-shirshov commented Oct 28, 2020

AkhileshSamineni commented Nov 16, 2020

prsunny Nov 17, 2020

AkhileshSamineni Apr 5, 2021

pavel-shirshov commented Nov 17, 2020

AkhileshSamineni commented Nov 18, 2020 •

edited

Loading

AkhileshSamineni commented Nov 18, 2020

arlakshm Apr 6, 2021

AkhileshSamineni Apr 7, 2021

arlakshm Apr 6, 2021

AkhileshSamineni Apr 7, 2021

AkhileshSamineni commented Apr 8, 2021

azure-pipelines bot commented Apr 8, 2021

AkhileshSamineni commented Apr 8, 2021

prsunny commented Apr 8, 2021

azure-pipelines bot commented Apr 8, 2021

lguohan commented Apr 14, 2021

AkhileshSamineni commented Apr 15, 2021

adyeung commented Jun 24, 2021

anshuv-mfst commented Jul 7, 2021

		@@ -0,0 +1,50 @@
		From 6a74cc3b97f405473c7500d5cd0adadba854067f Mon Sep 17 00:00:00 2001

FRR patches to support IPv6 Link local enhancements. #5584

FRR patches to support IPv6 Link local enhancements. #5584

Conversation

AkhileshSamineni commented Oct 10, 2020 • edited Loading

AkhileshSamineni commented Oct 11, 2020

AkhileshSamineni commented Oct 27, 2020

AkhileshSamineni commented Oct 27, 2020

pavel-shirshov commented Oct 27, 2020

AkhileshSamineni commented Oct 27, 2020

pavel-shirshov commented Oct 28, 2020

AkhileshSamineni commented Nov 16, 2020

prsunny Nov 17, 2020

Choose a reason for hiding this comment

AkhileshSamineni Apr 5, 2021

Choose a reason for hiding this comment

pavel-shirshov commented Nov 17, 2020

AkhileshSamineni commented Nov 18, 2020 • edited Loading

AkhileshSamineni commented Nov 18, 2020

arlakshm Apr 6, 2021

Choose a reason for hiding this comment

AkhileshSamineni Apr 7, 2021

Choose a reason for hiding this comment

arlakshm Apr 6, 2021

Choose a reason for hiding this comment

AkhileshSamineni Apr 7, 2021

Choose a reason for hiding this comment

AkhileshSamineni commented Apr 8, 2021

azure-pipelines bot commented Apr 8, 2021

AkhileshSamineni commented Apr 8, 2021

prsunny commented Apr 8, 2021

azure-pipelines bot commented Apr 8, 2021

lguohan commented Apr 14, 2021

AkhileshSamineni commented Apr 15, 2021

adyeung commented Jun 24, 2021

anshuv-mfst commented Jul 7, 2021

AkhileshSamineni commented Oct 10, 2020 •

edited

Loading

AkhileshSamineni commented Nov 18, 2020 •

edited

Loading