Global and Interface commands for IPv6 Link local address enhancements #1159

AkhileshSamineni · 2020-10-10T04:55:45Z

As per the HLD - sonic-net/SONiC#625 , added config and interface commands.

SONiC CLI per interface configuration command to enable and disable the IPv6 link-local address mode when addresses are not configured manually.

Example:

config interface ipv6 enable use-link-local-only Ethernet24
config interface ipv6 disable use-link-local-only Ethernet24

SONiC CLI global command to enable or disable the IPv6 auto link-local address mode on all eligible interfaces.

config ipv6 enable link-local
config ipv6 disable link-local

Show command to display the link local mode of all interfaces.

root@sonic:/home/admin# show ipv6 link-local-mode 
+------------------+----------+
| Interface Name   | Mode     |
+==================+==========+
| Ethernet16       | Disabled |
+------------------+----------+
| Ethernet18       | Enabled  |
+------------------+----------+
root@sonic:/home/admin#

Depends on:
sonic-net/sonic-buildimage#5584
sonic-net/sonic-swss#1463

Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com

lguohan

please add unit tests.

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

lgtm-com · 2021-04-15T09:36:24Z

This pull request introduces 1 alert when merging 56f74cd into eba5c04 - view on LGTM.com

new alerts:

1 for Unused local variable

AkhileshSamineni · 2021-04-15T14:35:40Z

please add unit tests.

@lguohan Added unit tests.

AkhileshSamineni · 2021-04-15T14:37:21Z

The failures are not related to the code changes, Please check it.

AkhileshSamineni · 2021-05-03T11:05:28Z

Please re-run the build, as the failures are not related to the code changes.

anshuv-mfst · 2021-05-04T15:59:11Z

Hi @prsunny - could you please help with re-run.

prsunny · 2021-05-05T01:51:42Z

/azp run

azure-pipelines · 2021-05-05T01:51:53Z

Azure Pipelines successfully started running 1 pipeline(s).

lguohan · 2021-05-12T21:24:41Z

@prsunny to review

prsunny · 2021-06-10T00:27:07Z

@venkatmahalingam , could you please review

config/main.py

tests/mock_tables/config_db.json

config/main.py

AkhileshSamineni · 2021-06-11T07:15:03Z

3 vs testcases are failing which are not related to this PR changes.

prsunny

please also update command reference guide

config/main.py

AkhileshSamineni · 2021-06-25T11:30:37Z

please also update command reference guide

@prsunny Updated.

As per HLD - sonic-net/SONiC#625 FRR Patches: 0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch Files modified : bgpd_network.c and bgpd/bgp_zebra.c Fix for : Link local scope was not set while binding socket with local address causing socket errors for bgp ipv6 link local neighbors. 0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch Files modified : staticd/static_zebra.c Fix for : VRF interface lookup was still done in the default-vrf which was causing the interface lookup to fail. Due to this static-route pointing to link-local was not getting installed. 0011-Changes-to-send-ipv6-link-local-address-as-nexthop-to-fpmsyncd.patch Files modified : zebra/zebra_fpm_netlink.c Fix for : Made changes to send ipv6 address as nexthop to fpmsyncd. Depends on: sonic-net/sonic-utilities#1159 sonic-net/sonic-swss#1463 Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com

anshuv-mfst · 2021-07-21T21:14:15Z

Hi @prsunny - could you please help with merge.

prsunny · 2021-07-21T21:16:14Z

@lguohan , could you please signoff?

prsunny · 2021-07-31T01:02:24Z

@lguohan , reminder

@lguohan , could you please signoff?

config/main.py

venkatmahalingam

I dont think, global implementation is done as per HLD comments (IMO, looping all the available interfaces for global config is a work-around and it doesnt work for any new interfaces after global config), please re-visit.

AkhileshSamineni · 2021-08-03T09:41:08Z

I dont think, global implementation is done as per HLD comments (IMO, looping all the available interfaces for global config is a work-around and it doesnt work for any new interfaces after global config), please re-visit.

@venkatmahalingam
Global field in device_metadata is not planned as part this PR, it should be an future item.

anshuv-mfst · 2021-08-03T15:10:04Z

hi @prsunny - could you please review and approve asap, this is needed in 202106 release

adyeung · 2021-08-05T22:02:42Z

@prsunny pls help merge this

lguohan · 2021-08-05T22:35:48Z

/azp run

azure-pipelines · 2021-08-05T22:35:58Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2021-08-06T02:01:31Z

/azp run

azure-pipelines · 2021-08-06T02:01:41Z

Azure Pipelines successfully started running 1 pipeline(s).

adyeung · 2021-08-06T16:00:50Z

@prsunny build test pass, pls help merge

As per HLD - sonic-net/SONiC#625 FRR Patches: 0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch Files modified : bgpd_network.c and bgpd/bgp_zebra.c Fix for : Link local scope was not set while binding socket with local address causing socket errors for bgp ipv6 link local neighbors. 0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch Files modified : staticd/static_zebra.c Fix for : VRF interface lookup was still done in the default-vrf which was causing the interface lookup to fail. Due to this static-route pointing to link-local was not getting installed. 0011-Changes-to-send-ipv6-link-local-address-as-nexthop-to-fpmsyncd.patch Files modified : zebra/zebra_fpm_netlink.c Fix for : Made changes to send ipv6 address as nexthop to fpmsyncd. Depends on: sonic-net/sonic-utilities#1159 sonic-net/sonic-swss#1463 Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com

adyeung · 2021-08-12T22:07:40Z

@lguohan pls help merge

#1159) * Global and Interface commands for IPv6 Link local feature * SONiC CLI per interface configuration command to enable and disable the IPv6 link-local address mode when addresses are not configured manually. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

This was referenced Oct 10, 2020

FRR patches to support IPv6 Link local enhancements. sonic-net/sonic-buildimage#5584

Merged

Code changes to support IPv6 Link local enhancements sonic-net/sonic-swss#1463

Merged

lguohan requested changes Oct 11, 2020

View reviewed changes

Global and Interface commands for IPv6 Link local feature

5652ee6

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

AkhileshSamineni force-pushed the ipv6-link-local-changes branch from c7ce903 to 5652ee6 Compare April 5, 2021 11:27

AkhileshSamineni added 3 commits April 5, 2021 09:27

Corrected changes as per design change.

c5d8578

Pushing for retest the build.

a4460b7

Pushing for retest the build.

a04176d

lguohan requested a review from prsunny April 14, 2021 21:23

Added show command and test case.

56f74cd

Fixed LGTM unused variable issue.

603b76e

venkatmahalingam reviewed Jun 10, 2021

View reviewed changes

config/main.py Show resolved Hide resolved

venkatmahalingam reviewed Jun 10, 2021

View reviewed changes

tests/mock_tables/config_db.json Outdated Show resolved Hide resolved

venkatmahalingam reviewed Jun 11, 2021

View reviewed changes

config/main.py Show resolved Hide resolved

Removed NULL attributes.

2908fcc

prsunny reviewed Jun 17, 2021

View reviewed changes

config/main.py Show resolved Hide resolved

config/main.py Show resolved Hide resolved

config/main.py Show resolved Hide resolved

config/main.py Show resolved Hide resolved

AkhileshSamineni added 2 commits June 25, 2021 02:39

Addressed review comment

e31d300

Updated the Command Reference

7edd67f

prsunny approved these changes Jul 14, 2021

View reviewed changes

venkatmahalingam reviewed Jul 31, 2021

View reviewed changes

config/main.py Show resolved Hide resolved

venkatmahalingam suggested changes Jul 31, 2021

View reviewed changes

venkatmahalingam approved these changes Aug 5, 2021

View reviewed changes

prsunny added the Request for 202106 Branch label Aug 6, 2021

lguohan approved these changes Aug 18, 2021

View reviewed changes

prsunny merged commit 29f4a16 into sonic-net:master Aug 18, 2021

judyjoseph added the Included in 202106 Branch label Aug 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Global and Interface commands for IPv6 Link local address enhancements #1159

Global and Interface commands for IPv6 Link local address enhancements #1159

AkhileshSamineni commented Oct 10, 2020 •

edited

Loading

lguohan left a comment

lgtm-com bot commented Apr 15, 2021

AkhileshSamineni commented Apr 15, 2021

AkhileshSamineni commented Apr 15, 2021

AkhileshSamineni commented May 3, 2021

anshuv-mfst commented May 4, 2021

prsunny commented May 5, 2021

azure-pipelines bot commented May 5, 2021

lguohan commented May 12, 2021

prsunny commented Jun 10, 2021

AkhileshSamineni commented Jun 11, 2021

prsunny left a comment

AkhileshSamineni commented Jun 25, 2021

anshuv-mfst commented Jul 21, 2021

prsunny commented Jul 21, 2021

prsunny commented Jul 31, 2021

venkatmahalingam left a comment

AkhileshSamineni commented Aug 3, 2021

anshuv-mfst commented Aug 3, 2021

adyeung commented Aug 5, 2021

lguohan commented Aug 5, 2021

azure-pipelines bot commented Aug 5, 2021

prsunny commented Aug 6, 2021

azure-pipelines bot commented Aug 6, 2021

adyeung commented Aug 6, 2021

adyeung commented Aug 12, 2021

Global and Interface commands for IPv6 Link local address enhancements #1159

Global and Interface commands for IPv6 Link local address enhancements #1159

Conversation

AkhileshSamineni commented Oct 10, 2020 • edited Loading

lguohan left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Apr 15, 2021

AkhileshSamineni commented Apr 15, 2021

AkhileshSamineni commented Apr 15, 2021

AkhileshSamineni commented May 3, 2021

anshuv-mfst commented May 4, 2021

prsunny commented May 5, 2021

azure-pipelines bot commented May 5, 2021

lguohan commented May 12, 2021

prsunny commented Jun 10, 2021

AkhileshSamineni commented Jun 11, 2021

prsunny left a comment

Choose a reason for hiding this comment

AkhileshSamineni commented Jun 25, 2021

anshuv-mfst commented Jul 21, 2021

prsunny commented Jul 21, 2021

prsunny commented Jul 31, 2021

venkatmahalingam left a comment

Choose a reason for hiding this comment

AkhileshSamineni commented Aug 3, 2021

anshuv-mfst commented Aug 3, 2021

adyeung commented Aug 5, 2021

lguohan commented Aug 5, 2021

azure-pipelines bot commented Aug 5, 2021

prsunny commented Aug 6, 2021

azure-pipelines bot commented Aug 6, 2021

adyeung commented Aug 6, 2021

adyeung commented Aug 12, 2021

AkhileshSamineni commented Oct 10, 2020 •

edited

Loading