Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build]: Provide support for apt install packages #7346

Merged
merged 2 commits into from
Apr 23, 2021
Merged

[build]: Provide support for apt install packages #7346

merged 2 commits into from
Apr 23, 2021

Conversation

VenkatCisco
Copy link
Contributor

@VenkatCisco VenkatCisco commented Apr 16, 2021

Why I did it

apt-package handling: These are part of the Export variables for .j2 files and is needed for Debian and its derivatives.

How I did it

Add support to slave.mk files to export APT_PACKAGES and DBG_APT_PACKAGES

How to verify it

The apt package, provides the apt management tool, a high-level command-line interface for better interactive usage. APT also includes command-line programs for dealing with packages, which use the library. Three such programs are apt, apt-get and apt-cache and can be verified for their existence.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@VenkatCisco VenkatCisco marked this pull request as ready for review April 16, 2021 18:02
slave.mk Outdated Show resolved Hide resolved
@lguohan lguohan changed the title Provide support for apt install packages [build]: Provide support for apt install packages Apr 18, 2021
@lguohan
Copy link
Collaborator

lguohan commented Apr 18, 2021

@xumia, can you take a looK?

@xumia
Copy link
Collaborator

xumia commented Apr 19, 2021

@xumia, can you take a looK?

The PR looks good to me.
It has small impact for reproducible build, when a version not specified in version control file, we will use the latest version. I have created an issue #7363 to fix it. Our auto-upgrade version azure pipeline can detect all the debian packages, not relative to how a package is installed. And apt package preference, supports for both apt and apt-get.

@lguohan
Copy link
Collaborator

lguohan commented Apr 19, 2021

@VenkatCisco, do we need to backport these to released branch? looks like there is more work to be done on w.r.t reproducible build part.

@VenkatCisco
Copy link
Contributor Author

@VenkatCisco, do we need to backport these to released branch? looks like there is more work to be done on w.r.t reproducible build part.

I see @xumia raised PR#7363 to address reproducible builds. We can park this in sonic/master until that resolves ?

@lguohan lguohan merged commit adc5b50 into sonic-net:master Apr 23, 2021
@lguohan lguohan added the Build label Apr 23, 2021
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
apt-package handling: These are part of the Export variables for .j2 files and is needed for Debian and its derivatives.

How I did it
Add support to slave.mk files to export APT_PACKAGES and DBG_APT_PACKAGES

How to verify it
The apt package, provides the apt management tool, a high-level command-line interface for better interactive usage. APT also includes command-line programs for dealing with packages, which use the library. Three such programs are apt, apt-get and apt-cache and can be verified for their existence.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
apt-package handling: These are part of the Export variables for .j2 files and is needed for Debian and its derivatives.

How I did it
Add support to slave.mk files to export APT_PACKAGES and DBG_APT_PACKAGES

How to verify it
The apt package, provides the apt management tool, a high-level command-line interface for better interactive usage. APT also includes command-line programs for dealing with packages, which use the library. Three such programs are apt, apt-get and apt-cache and can be verified for their existence.
qiluo-msft pushed a commit that referenced this pull request Aug 25, 2021
apt-package handling: These are part of the Export variables for .j2 files and is needed for Debian and its derivatives.

How I did it
Add support to slave.mk files to export APT_PACKAGES and DBG_APT_PACKAGES

How to verify it
The apt package, provides the apt management tool, a high-level command-line interface for better interactive usage. APT also includes command-line programs for dealing with packages, which use the library. Three such programs are apt, apt-get and apt-cache and can be verified for their existence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants