-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Fix the boolean value case sensitive issue in Azure Pipelines #7399
Conversation
how do you differentiate if this is a pr build v.s. nightly build? |
For PR build, use the default variables, all variables, like dbg_image, swi_image, raw_image, etc, are the default value “no”. It is the old behavior, keep not changed. We can change options if needed. Take broadcom as an example.
For PR build, the we do not set any variables:
Default variables:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…onic-net#7399) Why I did it Fix the boolean value case sensitive issue in Azure Pipelines When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue. To fix it, we change the true/false to yes/no, to escape the trap. Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
…onic-net#7399) Why I did it Fix the boolean value case sensitive issue in Azure Pipelines When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue. To fix it, we change the true/false to yes/no, to escape the trap. Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
…7399) Why I did it Fix the boolean value case sensitive issue in Azure Pipelines When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue. To fix it, we change the true/false to yes/no, to escape the trap. Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
…onic-net#7399) Why I did it Fix the boolean value case sensitive issue in Azure Pipelines When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue. To fix it, we change the true/false to yes/no, to escape the trap. Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
…onic-net#7399) Why I did it Fix the boolean value case sensitive issue in Azure Pipelines When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue. To fix it, we change the true/false to yes/no, to escape the trap. Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
…7399) Why I did it Fix the boolean value case sensitive issue in Azure Pipelines When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue. To fix it, we change the true/false to yes/no, to escape the trap. Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
…7399) Why I did it Fix the boolean value case sensitive issue in Azure Pipelines When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue. To fix it, we change the true/false to yes/no, to escape the trap. Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
…onic-net#7399) Why I did it Fix the boolean value case sensitive issue in Azure Pipelines When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue. To fix it, we change the true/false to yes/no, to escape the trap. Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
…onic-net#7399) Why I did it Fix the boolean value case sensitive issue in Azure Pipelines When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue. To fix it, we change the true/false to yes/no, to escape the trap. Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
Why I did it
Fix the boolean value case sensitive issue in Azure Pipelines
When passing parameters to a template, the "true" or "false" will have case sensitive issue, it should be a type casting issue.
To fix it, we change the true/false to yes/no, to escape the trap.
Support to override the job groups in the template, so PR build has chance to use different build parameters, only build simple targets. For example, for broadcom, we only build target/sonic-broadcom.bin, the other images, such as swi, debug bin, etc, will not be built.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)