DellEMC S6100: Determine pcie.yaml revision based on firmware version #7875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArunSaravananBalachandran
requested review from
jleveque and
lguohan
as code owners
|
This pull request introduces 2 alerts when merging 1c51f46 into 94441f4 - view on LGTM.com new alerts:
|
jleveque
approved these changes
Jun 17, 2021
sujinmkang
approved these changes
Jun 29, 2021
|
do we need this in 202012 version? |
|
Since sonic-net/sonic-platform-common#195 and sonic-net/sonic-utilities#1672 are included in 202012 branch, this PR can be directly ported to 202012 branch. |
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 14, 2021
Why I did it To determine the revision of the pcie.yaml to be used based on BIOS version in DellEMC S6100 platform. Depends on: sonic-net/sonic-platform-common#195 How I did it Added two revisions of pcie.yaml pcie_1.yaml and pcie_2.yaml Included a platform-specific Pcie class to provide the revision of the pcie.yaml to be used by pcieutil/pcied. How to verify it Execute pcieutil check (sonic-net/sonic-utilities#1672) command and verify the list of PCIe devices displayed. Logs: UT_logs.txt
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…net#7875) Why I did it To determine the revision of the pcie.yaml to be used based on BIOS version in DellEMC S6100 platform. Depends on: sonic-net/sonic-platform-common#195 How I did it Added two revisions of pcie.yaml pcie_1.yaml and pcie_2.yaml Included a platform-specific Pcie class to provide the revision of the pcie.yaml to be used by pcieutil/pcied. How to verify it Execute pcieutil check (sonic-net/sonic-utilities#1672) command and verify the list of PCIe devices displayed. Logs: UT_logs.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To determine the revision of the pcie.yaml to be used based on BIOS version in DellEMC S6100 platform.
Depends on: sonic-net/sonic-platform-common#195
How I did it
pcie_1.yamlandpcie_2.yamlPcieclass to provide the revision of the pcie.yaml to be used by pcieutil/pcied.How to verify it
Execute
pcieutil check(sonic-net/sonic-utilities#1672) command and verify the list of PCIe devices displayed.Logs: UT_logs.txt
Which release branch to backport (provide reason below if selected)
Description for the changelog
DellEMC S6100: Determine pcie.yaml revision based on firmware version
A picture of a cute animal (not mandatory but encouraged)